ZacharyZhang-NYandClaude Opus 5.5
bcce34cda1
MyGo v0.5.5 returns ui.Element as a checked value handle instead of a
pointer. Migrated with `mygo migrate-ui`, then fixed what the codemod
leaves to review:
- Element nil checks become .Valid(); absent elements are ui.Element{}.
- Input handlers and paint callbacks run outside the build pass, where
elements expire and Context methods are inert: read IsDisabled into a
local during the build, keep a ui.Handle for Focus, use c.Services()
for clipboard access, create ui.Local state during the build.
- Add core.AutoFocus: v0.5.5 records an overlay's opener after its
content builds, so same-frame autofocus lost focus restore on close.
It focuses one frame later; cascader rows defer their focus likewise.
- core.OverlayLayer identifies build passes by the root element, not
c.Now(), which repeats across passes and under the Tester clock.
- Context menus survive the opening press counted as PressedOutside;
split button tooltip no longer reorders its open menu; disabled
menubar rows pass presses to the panel; Form defers blur-started
async checks so the growing message no longer moves Submit away
from the release; Combobox drops its disabled copy now that MyGo
blocks typing under a disabled wrapper (canary flipped to a guard).
- The Tester clock is virtual: tests use Advance/Now instead of
time.Sleep/time.Now and read element state inside the view. The web
mirror advances the clock to wall time before each frame and input.
- AGENTS.md and docs describe the value Element API and the new pin.
Snapshot goldens are darwin-only and were not re-verified here.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
73 lines
2.2 KiB
Go
73 lines
2.2 KiB
Go
package layout
|
|
|
|
import (
|
|
"github.com/egoist/mygo/ui"
|
|
|
|
"git.zacharyzhang.com/ZacharyZhang-NY/MujicaUI/core"
|
|
"git.zacharyzhang.com/ZacharyZhang-NY/MujicaUI/internal"
|
|
"git.zacharyzhang.com/ZacharyZhang-NY/MujicaUI/theme"
|
|
)
|
|
|
|
// dividerDiamond is the ornament's size in DIPs.
|
|
const dividerDiamond float32 = 7
|
|
|
|
// DividerOptions configure a Divider.
|
|
type DividerOptions struct {
|
|
// Vertical draws a line down a row instead of across a column.
|
|
Vertical bool
|
|
// Label sits in the middle of a horizontal divider.
|
|
Label string
|
|
// Ornament draws the line in the ornament color with a single diamond in the middle; a Label replaces the diamond.
|
|
Ornament bool
|
|
}
|
|
|
|
// Divider is a thin separating line. It never takes focus and its ornament is not read out.
|
|
func Divider(c *ui.Context, opts DividerOptions) ui.Element {
|
|
if opts.Vertical && opts.Label != "" {
|
|
panic("mujica: a vertical Divider cannot have a Label")
|
|
}
|
|
k := core.Tokens(c)
|
|
line := k.Border
|
|
if opts.Ornament {
|
|
line = k.Ornament
|
|
}
|
|
if opts.Label == "" && !opts.Ornament {
|
|
e := ui.Box(c).Background(line).Shrink(0).AlignSelf(ui.Stretch)
|
|
if opts.Vertical {
|
|
return e.Width(theme.BorderWidth)
|
|
}
|
|
return e.Height(theme.BorderWidth)
|
|
}
|
|
if opts.Label == "" && !opts.Vertical {
|
|
gap := core.Density(c).Unit()*2 + dividerDiamond/2
|
|
return ui.Box(c).Height(dividerDiamond).Shrink(0).AlignSelf(ui.Stretch).Draw(func(p *ui.Painter, r ui.Rect) {
|
|
internal.RuleDiamond(p, r, gap, dividerDiamond, line)
|
|
})
|
|
}
|
|
e := ui.Row(c).Gap(core.Density(c).Unit() * 2).Shrink(0).AlignSelf(ui.Stretch)
|
|
if opts.Vertical {
|
|
e.Column().AlignItems(ui.Center)
|
|
}
|
|
segment := func() {
|
|
s := ui.Box(c).Grow(1).Background(line)
|
|
if opts.Vertical {
|
|
s.Width(theme.BorderWidth)
|
|
} else {
|
|
s.Height(theme.BorderWidth)
|
|
}
|
|
}
|
|
return e.Children(func() {
|
|
segment()
|
|
if opts.Label != "" {
|
|
ui.Text(c, opts.Label).Font(theme.SerifFont).FontSize(core.FontSize(c, theme.CaptionSize)).
|
|
TextColor(k.TextMuted).SingleLine().Shrink(0)
|
|
} else {
|
|
ui.Box(c).Size(dividerDiamond, dividerDiamond).Shrink(0).Role(ui.RoleNone).
|
|
Draw(func(p *ui.Painter, r ui.Rect) {
|
|
p.FillPath(internal.Diamond(r.X+r.W/2, r.Y+r.H/2, r.W), k.Ornament)
|
|
})
|
|
}
|
|
segment()
|
|
})
|
|
}
|