ZacharyZhang-NYandClaude Opus 5.5
bcce34cda1
MyGo v0.5.5 returns ui.Element as a checked value handle instead of a
pointer. Migrated with `mygo migrate-ui`, then fixed what the codemod
leaves to review:
- Element nil checks become .Valid(); absent elements are ui.Element{}.
- Input handlers and paint callbacks run outside the build pass, where
elements expire and Context methods are inert: read IsDisabled into a
local during the build, keep a ui.Handle for Focus, use c.Services()
for clipboard access, create ui.Local state during the build.
- Add core.AutoFocus: v0.5.5 records an overlay's opener after its
content builds, so same-frame autofocus lost focus restore on close.
It focuses one frame later; cascader rows defer their focus likewise.
- core.OverlayLayer identifies build passes by the root element, not
c.Now(), which repeats across passes and under the Tester clock.
- Context menus survive the opening press counted as PressedOutside;
split button tooltip no longer reorders its open menu; disabled
menubar rows pass presses to the panel; Form defers blur-started
async checks so the growing message no longer moves Submit away
from the release; Combobox drops its disabled copy now that MyGo
blocks typing under a disabled wrapper (canary flipped to a guard).
- The Tester clock is virtual: tests use Advance/Now instead of
time.Sleep/time.Now and read element state inside the view. The web
mirror advances the clock to wall time before each frame and input.
- AGENTS.md and docs describe the value Element API and the new pin.
Snapshot goldens are darwin-only and were not re-verified here.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
42 lines
1.1 KiB
Go
42 lines
1.1 KiB
Go
package overlay
|
|
|
|
import (
|
|
"log/slog"
|
|
|
|
"github.com/egoist/mygo/ui"
|
|
)
|
|
|
|
// DropdownMenuOptions configure a DropdownMenu.
|
|
type DropdownMenuOptions struct {
|
|
// Icon goes before the label.
|
|
Icon *ui.SVG
|
|
Disabled bool
|
|
// Label names an icon-only trigger for assistive technology.
|
|
Label string
|
|
}
|
|
|
|
// DropdownMenu is a button opening an in-window menu that build fills; it returns the button.
|
|
func DropdownMenu(c *ui.Context, label string, opts DropdownMenuOptions, build func(m *PopupMenu)) ui.Element {
|
|
if build == nil {
|
|
panic("mujica: DropdownMenu needs a build function")
|
|
}
|
|
if label == "" && opts.Label == "" {
|
|
panic("mujica: DropdownMenu needs a label or Label")
|
|
}
|
|
b := ui.ButtonBase(c).Role(ui.RoleMenuButton).Disabled(opts.Disabled)
|
|
if opts.Label != "" {
|
|
b.Label(opts.Label)
|
|
}
|
|
open := ui.Local(b, "mujica.dropdown", func() bool { return false })
|
|
if opts.Disabled {
|
|
*open = false
|
|
}
|
|
if b.Clicked() || b.Shortcut(0, ui.KeyDown) {
|
|
*open = true
|
|
slog.Debug("mujica: dropdown_menu open")
|
|
}
|
|
popupMenuTrigger(c, b, label, opts.Icon, *open)
|
|
PopupMenuOpen(c, b, open, build)
|
|
return b
|
|
}
|