ZacharyZhang-NY/OmaPhoto
1
1 Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 2 Wiki Activity

Review fixes in progress, unverified: stopped by the user before the tests ran

Browse Source
This commit is contained in:
ZacharyZhang-NY committed 2026-10-01 23:01:53 -04:00
1 parent 81894f744a
commit 2190a1b67e
4 files changed
+87 -4
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

tests/MaskAloneTests.cpp
+52
View File
@@ -18,6 +18,8 @@ private slots:
void aPlacedOrDisabledMaskShowsAlone();
void theBadgeNamesTheMaskAndTakesItsOwnClicks();
void altClickOnTheThumbnailTogglesItAndOutlinesItWhite();
void theViewOutlastsUndoRedoAndTargetingTheMaskAgain();
void aPendingGradientElsewhereStaysOutOfTheView();
};
namespace {
@@ -294,5 +296,55 @@ void MaskAloneTests::altClickOnTheThumbnailTogglesItAndOutlinesItWhite()
QCOMPARE(accent, thumbnail->palette().color(QPalette::Highlight));
}
void MaskAloneTests::theViewOutlastsUndoRedoAndTargetingTheMaskAgain()
{
QUuid id;
const auto session = maskedSession(id);
session->toggleMaskAlone(id);
// A plain click on the shown mask targets it again.
session->selectLayerTarget(id, true);
QCOMPARE(session->maskAloneLayer().value().id, id);
// A stroke on it, undone and redone, keeps the view.
session->selectTool(NavigationTool::brush);
session->setBrushSettings(brush(20, 1, 0, 0, 0));
session->beginBrush(QPointF(50, 50));
QVERIFY(session->finishBrushImmediately());
QCOMPARE(session->history.undoName(), QString("Paint Mask"));
session->undo();
QCOMPARE(session->maskAloneLayer().value().id, id);
session->redo();
QCOMPARE(session->maskAloneLayer().value().id, id);
}
void MaskAloneTests::aPendingGradientElsewhereStaysOutOfTheView()
{
Canvas shown;
EditorSession &session = shown.session;
session.setForegroundColor(PaletteColor{0, 0, 1});
session.selectTool(NavigationTool::gradient);
// The layer's own pixels take a blue gradient, still pending.
session.selectLayerTarget(shown.id, false);
session.beginGradient(QPointF(0, 80));
session.moveGradient(std::nullopt, QPointF(200, 80));
QVERIFY(session.gradientEdit().has_value() && !session.gradientEdit()->raster->isMask);
session.toggleMaskAlone(shown.id);
// The commit is posted: the pixels' raster lingers, unshown.
QVERIFY(session.maskAloneLayer().has_value() && session.gradientEdit().has_value());
QVERIFY(gray(shown.at(QPointF(50, 50)), 255) && gray(shown.at(QPointF(150, 50)), 0));
QTRY_VERIFY(!session.gradientEdit().has_value());
// Another layer's mask gradient stays out of this view.
session.addBlankLayer();
const QUuid other = session.activeLayerID().value();
session.addLayerMask();
session.beginGradient(QPointF(0, 80));
session.moveGradient(std::nullopt, QPointF(200, 80));
QVERIFY(session.gradientEdit().has_value() && session.gradientEdit()->raster->isMask && session.gradientEdit()->raster->layer.id == other);
session.toggleMaskAlone(shown.id);
QCOMPARE(session.maskAloneLayer().value().id, shown.id);
QVERIFY(session.gradientEdit().has_value());
QVERIFY(gray(shown.at(QPointF(50, 50)), 255) && gray(shown.at(QPointF(150, 50)), 0));
QTRY_VERIFY(!session.gradientEdit().has_value());
}
QTEST_MAIN(MaskAloneTests)
#include "MaskAloneTests.moc"