ZacharyZhang-NY/OmaPhoto
1
1 Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 2 Wiki Activity

14.10 round 1: Space let go mid-pan keeps the hand closed, tested

Browse Source
This commit is contained in:
ZacharyZhang-NY committed 2026-10-11 06:43:21 -04:00
1 parent e6575685ea
commit b7c3f74575
2 files changed
+12 -2
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

tests/CanvasNavigationTests.cpp
+11 -1
View File
@@ -116,12 +116,22 @@ void CanvasNavigationTests::theHandToolAndSpaceDragTheView()
QCOMPARE(canvas.cursor().shape(), Qt::OpenHandCursor);
QTest::keyRelease(&canvas, Qt::Key_Space);
QCOMPARE(canvas.cursor().shape(), Qt::ArrowCursor);
// Space let go mid-pan: the pan goes on, closed.
QTest::keyPress(&canvas, Qt::Key_Space);
QTest::mousePress(&canvas, Qt::LeftButton, Qt::NoModifier, QPoint(50, 50));
QTest::keyRelease(&canvas, Qt::Key_Space);
QCOMPARE(canvas.cursor().shape(), Qt::ClosedHandCursor);
drag(canvas, QPointF(55, 50));
QCOMPARE(canvas.cursor().shape(), Qt::ClosedHandCursor);
QCOMPARE(session.viewport.pan, pan + QSizeF(50, 40));
QTest::mouseRelease(&canvas, Qt::LeftButton, Qt::NoModifier, QPoint(55, 50));
QCOMPARE(canvas.cursor().shape(), Qt::ArrowCursor);
// Importing, a press starts no drag.
session.selectTool(NavigationTool::hand);
session.setIsImporting(true);
QTest::mousePress(&canvas, Qt::LeftButton, Qt::NoModifier, QPoint(50, 50));
drag(canvas, QPointF(90, 90));
QCOMPARE(session.viewport.pan, pan + QSizeF(45, 40));
QCOMPARE(session.viewport.pan, pan + QSizeF(50, 40));
QTest::mouseRelease(&canvas, Qt::LeftButton, Qt::NoModifier, QPoint(90, 90));
}