Filter › Dither, as Compositor 1.3.3 (12.15)

This commit is contained in:
雷电芽衣 committed 2026-09-30 07:55:57 -04:00
1 parent aa5a44e517
commit bc9d43f1e8
25 files changed
+1973 -17

No files matched your search

+363
View File
@@ -0,0 +1,363 @@
#include "Document/BrushStroke.h"
#include "Document/Dither.h"
#include "Document/EditorSession.h"
#include <QtTest>
#include <set>
// Swift 1.3.3's Dither: the model and the kernel through `apply`.
namespace {
QImage filled(int width, int height, QColor colour)
{
QImage image = BrushRaster::context(width, height, false);
image.fill(colour);
return image;
}
// A horizontal ramp of grays, left black, right white.
QImage ramp(int width, int height)
{
QImage image = BrushRaster::context(width, height, false);
for (int y = 0; y < height; ++y)
for (int x = 0; x < width; ++x)
image.setPixelColor(x, y, QColor::fromRgbF(float(x) / float(width - 1), float(x) / float(width - 1), float(x) / float(width - 1)));
return image;
}
std::set<QRgb> colours(const QImage &image)
{
std::set<QRgb> found;
for (int y = 0; y < image.height(); ++y)
for (int x = 0; x < image.width(); ++x)
found.insert(image.pixel(x, y));
return found;
}
DitherSettings style(DitherStyle each, double pixelSize = 1)
{
DitherSettings settings;
settings.style = each;
settings.pixelSize = pixelSize;
return settings;
}
}
class DitherTests : public QObject {
Q_OBJECT
private slots:
void stylesKeepSwiftsNamesOrderAndGroups();
void normalizingClampsRoundsAndTrimsTheCharacters();
void bayerThresholdsAGrayIntoItsPattern();
void diffusionMakesTwoTonesOrMore();
void twoColorsAndTheOriginalOnes();
void alphaIsKeptAndClearPixelsLeftAlone();
void chunkyPixelsFillTheirBlocks();
void dotsLeaveTheirCornersToTheDarkColour();
void marksDrawLightOnDarkOrDarkOnLight();
void glyphsAreSortedByTheirInk();
void densityAndContrastMoveTheThreshold();
void theScreenTurnsWithItsAngle();
void asciiDrawsWithItsOwnCharacters();
};
void DitherTests::stylesKeepSwiftsNamesOrderAndGroups()
{
QStringList names;
for (const DitherStyle each : allDitherStyles)
names << rawValue(each);
QCOMPARE(names, (QStringList{"Atkinson (Classic Mac)", "Floyd–Steinberg", "Bayer 2 × 2", "Bayer 4 × 4", "Bayer 8 × 8", "Halftone Dots",
"Halftone Lines", "Halftone Diamonds", "Mac Patterns", "ASCII"}));
QString groups;
for (const DitherStyle each : allDitherStyles)
groups += QString::number(ditherGroup(each));
QCOMPARE(groups, QString("0011122233"));
QVERIFY(diffuses(DitherStyle::floydSteinberg) && !diffuses(DitherStyle::bayer2));
QVERIFY(hasTones(DitherStyle::bayer8) && !hasTones(DitherStyle::dots));
QVERIFY(isHalftone(DitherStyle::diamonds) && !isHalftone(DitherStyle::patterns));
QVERIFY(drawsMarks(DitherStyle::ascii) && drawsMarks(DitherStyle::lines) && !drawsMarks(DitherStyle::atkinson));
QCOMPARE(rawValue(DitherPixelShape::dot), QString("Dot"));
QCOMPARE(rawValue(DitherColors::twoColors), QString("Two Colors"));
// Chunky square pixels, 1-bit Atkinson, glowing marks by default.
const DitherSettings defaults;
QVERIFY(defaults.style == DitherStyle::atkinson && defaults.pixelSize == 2 && defaults.pixelShape == DitherPixelShape::square);
QVERIFY(defaults.levels == 2 && defaults.lightOnDark && defaults.colors == DitherColors::blackWhite);
}
void DitherTests::normalizingClampsRoundsAndTrimsTheCharacters()
{
DitherSettings wild;
wild.pixelSize = 40.6;
wild.cellSize = 2;
wild.angle = std::nan("");
wild.levels = 4.5;
wild.diffusion = -5;
wild.density = 300;
wild.contrast = std::numeric_limits<double>::infinity();
wild.dark = AdjustmentColor(-1, 0.5, 2);
wild.light = AdjustmentColor(3, -2, 0.25);
wild.characters = QStringLiteral("ab\ncd\r\ne\u2028f\u000Bg\u000Ch\u0085i\u2029\t j") + QString(80, u'x');
const DitherSettings normal = wild.normalized();
QCOMPARE(normal.pixelSize, 32.0);
QCOMPARE(normal.cellSize, 4.0);
QCOMPARE(normal.angle, 45.0);
QCOMPARE(normal.levels, 5.0);
QCOMPARE(normal.diffusion, 0.0);
QCOMPARE(normal.density, 100.0);
QCOMPARE(normal.contrast, 0.0);
QVERIFY(normal.dark == AdjustmentColor(0, 0.5, 1) && normal.light == AdjustmentColor(1, 0, 0.25));
// Every line break goes, tabs and spaces stay; 64 kept.
QCOMPARE(normal.characters, QStringLiteral("abcdefghi\t j") + QString(52, u'x'));
// A grapheme of many units counts once, never split.
DitherSettings emoji;
emoji.characters = QString(63, u'.') + QStringLiteral("\U0001F44D\U0001F3FD") + QStringLiteral("zz");
QCOMPARE(emoji.normalized().characters, QString(63, u'.') + QStringLiteral("\U0001F44D\U0001F3FD"));
QCOMPARE(DitherSettings().normalized(), DitherSettings());
}
void DitherTests::bayerThresholdsAGrayIntoItsPattern()
{
// Half gray over Bayer 2 × 2: high thresholds light.
const QImage out = style(DitherStyle::bayer2).apply(filled(4, 4, QColor(128, 128, 128)));
const QRgb black = qRgb(0, 0, 0), white = qRgb(255, 255, 255);
const std::array<QRgb, 4> pattern{black, white, white, black};
for (int y = 0; y < 4; ++y)
for (int x = 0; x < 4; ++x)
QCOMPARE(out.pixel(x, y), pattern[size_t((y & 1) * 2 + (x & 1))]);
// Four tones on a ramp: 0, 85, 170, 255 alone.
DitherSettings tones = style(DitherStyle::bayer4);
tones.levels = 4;
std::set<int> levels;
const QImage toned = tones.apply(ramp(64, 8));
for (int x = 0; x < 64; ++x)
levels.insert(qRed(toned.pixel(x, 3)));
QCOMPARE(levels, (std::set<int>{0, 85, 170, 255}));
}
void DitherTests::diffusionMakesTwoTonesOrMore()
{
for (const DitherStyle each : {DitherStyle::atkinson, DitherStyle::floydSteinberg}) {
const QImage out = style(each).apply(ramp(64, 16));
QCOMPARE(colours(out), (std::set<QRgb>{qRgb(0, 0, 0), qRgb(255, 255, 255)}));
// More white towards the light end.
int left = 0, right = 0;
for (int y = 0; y < 16; ++y) {
for (int x = 0; x < 16; ++x) {
left += qRed(out.pixel(x, y)) == 255;
right += qRed(out.pixel(63 - x, y)) == 255;
}
}
QVERIFY2(left < 40 && right > 216, qPrintable(QStringLiteral("%1 %2").arg(left).arg(right)));
}
// No diffusion: a flat mid gray rounds whole.
DitherSettings flat = style(DitherStyle::atkinson);
flat.diffusion = 0;
QCOMPARE(colours(flat.apply(filled(8, 8, QColor(140, 140, 140)))), (std::set<QRgb>{qRgb(255, 255, 255)}));
}
void DitherTests::twoColorsAndTheOriginalOnes()
{
DitherSettings two = style(DitherStyle::bayer8);
two.colors = DitherColors::twoColors;
two.dark = AdjustmentColor(0.2, 0, 0.4);
two.light = AdjustmentColor(1, 0.8, 0.6);
QCOMPARE(colours(two.apply(ramp(32, 8))), (std::set<QRgb>{qRgb(51, 0, 102), qRgb(255, 204, 153)}));
// Original: red stays red, dithered on its own channels.
DitherSettings original = style(DitherStyle::bayer8);
original.colors = DitherColors::original;
for (const QRgb each : colours(original.apply(filled(8, 8, QColor(255, 0, 0)))))
QCOMPARE(each, qRgb(255, 0, 0));
}
void DitherTests::alphaIsKeptAndClearPixelsLeftAlone()
{
QImage image = ramp(16, 4);
image.setPixelColor(0, 0, Qt::transparent);
image.setPixelColor(5, 1, QColor::fromRgbF(1, 1, 1, 0.5f));
const QImage out = style(DitherStyle::floydSteinberg).apply(image);
QCOMPARE(out.pixelColor(0, 0).alpha(), 0);
QCOMPARE(out.pixelColor(5, 1).alpha(), 128);
for (int x = 1; x < 16; ++x)
QCOMPARE(out.pixelColor(x, 3).alpha(), 255);
}
void DitherTests::chunkyPixelsFillTheirBlocks()
{
const QImage out = style(DitherStyle::bayer8, 4).apply(ramp(18, 10));
QCOMPARE(out.size(), QSize(18, 10));
// One colour a 4 × 4 block; edge blocks cut.
for (int y = 0; y < 10; ++y)
for (int x = 0; x < 18; ++x)
QCOMPARE(out.pixel(x, y), out.pixel(x / 4 * 4, y / 4 * 4));
QCOMPARE(colours(out.copy(0, 0, 16, 8)), (std::set<QRgb>{qRgb(0, 0, 0), qRgb(255, 255, 255)}));
// A cut block averages in the clear beyond the edge.
QCOMPARE(out.pixelColor(17, 0).alpha(), 128);
QCOMPARE(out.pixelColor(0, 9).alpha(), 128);
QCOMPARE(out.pixelColor(17, 9).alpha(), 64);
// Diffused small: each block's exact average, then its pixel.
const QImage source = ramp(18, 10);
QImage averaged = BrushRaster::context(5, 3, false);
for (int y = 0; y < 3; ++y) {
for (int x = 0; x < 5; ++x) {
std::array<int, 4> sum{};
for (int sy = y * 4; sy < std::min(10, y * 4 + 4); ++sy)
for (int sx = x * 4; sx < std::min(18, x * 4 + 4); ++sx)
for (int channel = 0; channel < 4; ++channel)
sum[size_t(channel)] += source.constScanLine(sy)[sx * 4 + channel];
for (int channel = 0; channel < 4; ++channel)
averaged.scanLine(y)[x * 4 + channel] = uchar((sum[size_t(channel)] + 8) / 16);
}
}
const QImage small = style(DitherStyle::floydSteinberg).apply(averaged);
const QImage chunky = style(DitherStyle::floydSteinberg, 4).apply(source);
for (int y = 0; y < 10; ++y)
for (int x = 0; x < 18; ++x)
QCOMPARE(chunky.pixel(x, y), small.pixel(x / 4, y / 4));
// A block's average: half black, half white reads as gray.
QImage halves = BrushRaster::context(8, 8, false);
for (int y = 0; y < 8; ++y)
for (int x = 0; x < 8; ++x)
halves.setPixelColor(x, y, x % 2 ? Qt::white : Qt::black);
DitherSettings levels = style(DitherStyle::bayer2, 8);
levels.levels = 3;
QCOMPARE(colours(levels.apply(halves)), (std::set<QRgb>{qRgb(128, 128, 128)}));
}
void DitherTests::dotsLeaveTheirCornersToTheDarkColour()
{
DitherSettings dots = style(DitherStyle::bayer2, 8);
dots.pixelShape = DitherPixelShape::dot;
const QImage out = dots.apply(filled(16, 16, Qt::white));
// White dots on black, each centred in its block.
QCOMPARE(out.pixel(0, 0), qRgb(0, 0, 0));
QCOMPARE(out.pixel(4, 4), qRgb(255, 255, 255));
QCOMPARE(out.pixel(8, 15), qRgb(0, 0, 0));
QCOMPARE(out.pixel(12, 12), qRgb(255, 255, 255));
// Two Colors: the gaps are the dark one.
dots.colors = DitherColors::twoColors;
dots.dark = AdjustmentColor(0, 0, 1);
QCOMPARE(dots.apply(filled(16, 16, Qt::white)).pixel(0, 0), qRgb(0, 0, 255));
// Square pixels have no gaps.
dots.pixelShape = DitherPixelShape::square;
QCOMPARE(dots.apply(filled(16, 16, Qt::white)).pixel(0, 0), qRgb(255, 255, 255));
}
void DitherTests::marksDrawLightOnDarkOrDarkOnLight()
{
for (const DitherStyle each : {DitherStyle::dots, DitherStyle::lines, DitherStyle::diamonds, DitherStyle::patterns, DitherStyle::ascii}) {
DitherSettings marks = style(each);
const QImage glowing = marks.apply(ramp(64, 64));
// Hard marks, but for the characters' smoothed ink.
if (each == DitherStyle::ascii) {
for (const QRgb colour : colours(glowing))
QVERIFY(qRed(colour) == qGreen(colour) && qGreen(colour) == qBlue(colour));
} else {
QCOMPARE(colours(glowing), (std::set<QRgb>{qRgb(0, 0, 0), qRgb(255, 255, 255)}));
}
marks.lightOnDark = false;
const QImage inked = marks.apply(ramp(64, 64));
QVERIFY2(inked != glowing, qPrintable(rawValue(each)));
// Black stays black, white white, either way.
QCOMPARE(qRed(glowing.pixel(0, 32)), 0);
QCOMPARE(qRed(inked.pixel(63, 32)), 255);
}
}
void DitherTests::glyphsAreSortedByTheirInk()
{
const DitherSettings::Glyphs glyphs = DitherSettings::glyphs(QStringLiteral("@. .#"), 8);
// Four distinct: space, dot, hash, at; 8 × 8 maps.
QCOMPARE(glyphs.coverage.size(), size_t(4));
QCOMPARE(glyphs.maps.size(), size_t(4 * 64));
QCOMPARE(glyphs.coverage[0], 0.0f);
QVERIFY(glyphs.coverage[1] > 0 && glyphs.coverage[1] < glyphs.coverage[2] && glyphs.coverage[2] <= glyphs.coverage[3]);
QVERIFY(*std::max_element(glyphs.maps.begin() + 192, glyphs.maps.end()) > 200);
QCOMPARE(DitherSettings::glyphs(DitherSettings::defaultCharacters(), 12).coverage.size(), size_t(10));
// A 20-pixel cell: M at 23 pixels, 15–19 tall.
const std::vector<uint8_t> m = DitherSettings::glyphs(QStringLiteral("M"), 20).maps;
int top = 20, bottom = -1;
bool smooth = false;
for (int index = 0; index < 400; ++index) {
if (m[size_t(index)] > 128) {
top = std::min(top, index / 20);
bottom = std::max(bottom, index / 20);
}
smooth = smooth || (m[size_t(index)] > 0 && m[size_t(index)] < 255);
}
QVERIFY2(bottom - top + 1 >= 15 && bottom - top + 1 <= 19, qPrintable(QString::number(bottom - top + 1)));
QVERIFY(smooth);
// Centred on its ink both ways: a dot mid cell.
const std::vector<uint8_t> dot = DitherSettings::glyphs(QStringLiteral("."), 20).maps;
double sum = 0, sumX = 0, sumY = 0;
for (int index = 0; index < 400; ++index) {
sum += dot[size_t(index)];
sumX += dot[size_t(index)] * (index % 20 + 0.5);
sumY += dot[size_t(index)] * (index / 20 + 0.5);
}
QVERIFY2(std::abs(sumX / sum - 10) < 0.6 && std::abs(sumY / sum - 10) < 0.6, qPrintable(QStringLiteral("%1 %2").arg(sumX / sum).arg(sumY / sum)));
// Canonically equal graphemes are one, as Swift's Characters.
QCOMPARE(DitherSettings::glyphs(QStringLiteral("\u00E9e\u0301"), 20).coverage.size(), size_t(1));
}
void DitherTests::densityAndContrastMoveTheThreshold()
{
// Bayer 8 × 8 on flat gray: whites follow tone.
const auto whites = [](int gray, double density, double contrast) {
DitherSettings settings = style(DitherStyle::bayer8);
settings.density = density;
settings.contrast = contrast;
const QImage out = settings.apply(filled(8, 8, QColor(gray, gray, gray)));
int count = 0;
for (int y = 0; y < 8; ++y)
for (int x = 0; x < 8; ++x)
count += qRed(out.pixel(x, y)) == 255;
return count;
};
// Density: gamma 2^(1.5 d), more ink as it rises.
QCOMPARE(whites(128, 0, 0), 32);
QCOMPARE(whites(128, 50, 0), 20);
QCOMPARE(whites(128, -50, 0), 42);
// Contrast pivots on mid gray, steeper as it rises.
QCOMPARE(whites(153, 0, 0), 38);
QCOMPARE(whites(153, 0, 50), 44);
QCOMPARE(whites(153, 0, -50), 35);
}
void DitherTests::theScreenTurnsWithItsAngle()
{
// Halftone lines at 0°: rows alike; at 90°: columns alike.
for (const double angle : {0.0, 90.0}) {
DitherSettings lines = style(DitherStyle::lines);
lines.angle = angle;
lines.cellSize = 8;
const QImage out = lines.apply(filled(32, 32, QColor(100, 100, 100)));
bool alike = true, varied = false;
for (int a = 0; a < 32; ++a) {
for (int b = 0; b < 32; ++b) {
const QRgb here = angle == 0 ? out.pixel(b, a) : out.pixel(a, b);
alike = alike && here == (angle == 0 ? out.pixel(0, a) : out.pixel(a, 0));
varied = varied || here != out.pixel(0, 0);
}
}
QVERIFY2(alike && varied, qPrintable(QString::number(angle)));
}
}
void DitherTests::asciiDrawsWithItsOwnCharacters()
{
DitherSettings ascii = style(DitherStyle::ascii);
ascii.cellSize = 12;
const QImage source = ramp(48, 24);
// A blank alphabet marks nothing: all the dark paper.
ascii.characters = QStringLiteral(" ");
QCOMPARE(colours(ascii.apply(source)), (std::set<QRgb>{qRgb(0, 0, 0)}));
// None at all: Swift's default alphabet.
ascii.characters = QString();
const QImage fallback = ascii.apply(source);
ascii.characters = DitherSettings::defaultCharacters();
QCOMPARE(fallback, ascii.apply(source));
// Another alphabet draws otherwise.
ascii.characters = QStringLiteral(" #");
QVERIFY(ascii.apply(source) != fallback);
}
QTEST_MAIN(DitherTests)
#include "DitherTests.moc"