#include "CameraRawFixtures.h" #include "Document/CameraRawTables.h" #include // The measured tables as Swift reads them, checked against Python. using namespace CameraRawFixtures; class CameraRawTablesTests : public QObject { Q_OBJECT private slots: void theTablesDecodeAsWritten(); void aStageBlendsTheTablesAroundItsValue(); void eachSliderPicksItsOwnTables(); void theAdaptiveSlidersBlendAcrossBrightness(); void theColourGroupsPickTheirTables(); void neutralizeFindsTheGridsGrayest(); void identitySlidersComposeNothing(); }; namespace { const uint8_t *entry(int table, int cell) { constexpr size_t entries = size_t(CameraRawTables::size) * CameraRawTables::size * CameraRawTables::size * 3; return CameraRawTables::tables().data() + table * entries + size_t(cell) * 3; } int indexOf(const uint8_t *table) { constexpr size_t entries = size_t(CameraRawTables::size) * CameraRawTables::size * CameraRawTables::size * 3; return table ? int((table - CameraRawTables::tables().data()) / qsizetype(entries)) : -1; } } void CameraRawTablesTests::theTablesDecodeAsWritten() { const std::vector &tables = CameraRawTables::tables(); QCOMPARE(tables.size(), size_t(763) * 17 * 17 * 17 * 3); quint64 hash = 0xcbf29ce484222325ULL; for (const uint8_t byte : tables) hash = (hash ^ byte) * 0x100000001b3ULL; QCOMPARE(hash, quint64(0x4967372b0e6d3d38ULL)); QCOMPARE(std::vector(entry(40, 2456), entry(40, 2456) + 3), (std::vector{128, 128, 128})); QCOMPARE(std::vector(entry(81, 100), entry(81, 100) + 3), (std::vector{0, 5, 32})); QCOMPARE(std::vector(entry(146, 4912), entry(146, 4912) + 3), (std::vector{255, 255, 255})); QCOMPARE(std::vector(entry(200, 2456), entry(200, 2456) + 3), (std::vector{173, 173, 173})); QCOMPARE(std::vector(entry(284, 100), entry(284, 100) + 3), (std::vector{69, 107, 255})); QCOMPARE(std::vector(entry(500, 1000), entry(500, 1000) + 3), (std::vector{63, 112, 211})); QCOMPARE(std::vector(entry(762, 4000), entry(762, 4000) + 3), (std::vector{228, 235, 110})); } void CameraRawTablesTests::aStageBlendsTheTablesAroundItsValue() { const CameraRawStage balance = CameraRawTables::whiteBalance(30, -60); QCOMPARE((std::vector{indexOf(balance.table[0]), indexOf(balance.table[1]), indexOf(balance.table[2]), indexOf(balance.table[3])}), (std::vector{46, 47, 55, 56})); QCOMPARE((std::vector{balance.weight[0], balance.weight[1], balance.weight[2], balance.weight[3]}), (std::vector{0.32f, 0.48f, 0.08f, 0.12f})); // At the far corner the last pair takes it all. const CameraRawStage corner = CameraRawTables::whiteBalance(100, 100); QVERIFY(indexOf(corner.table[0]) == 70 && indexOf(corner.table[3]) == 80 && corner.weight[3] == 1 && corner.weight[0] == 0); // Past the range it holds at the end, never beyond. const CameraRawStage past = CameraRawTables::whiteBalance(150, 175); QVERIFY(indexOf(past.table[3]) == 80 && past.weight[3] == 1 && past.weight[0] == 0); const CameraRawStage low = CameraRawTables::whiteBalance(-100, -100); QVERIFY(indexOf(low.table[0]) == 0 && low.weight[0] == 1 && low.weight[1] == 0); } void CameraRawTablesTests::eachSliderPicksItsOwnTables() { CameraRawSettings settings; settings.exposure = 1.25; settings.temperature = 30; settings.whites = 100; settings.blacks = 12.5; settings.saturation = -62.5; settings.vibrance = 80; const std::vector stages = CameraRawTables::stages(settings, {}); QCOMPARE(stages.size(), size_t(6)); const auto pair = [](const CameraRawStage &stage) { return std::vector{double(indexOf(stage.table[0])), double(indexOf(stage.table[1])), stage.weight[0], stage.weight[1]}; }; QCOMPARE(pair(stages[0]), (std::vector{93, 94, 0.5, 0.5})); QCOMPARE(indexOf(stages[1].table[0]), 5 * 9 + 4); QCOMPARE(pair(stages[2]), (std::vector{109, 110, 0, 1})); QCOMPARE(pair(stages[3]), (std::vector{115, 116, 0.5, 0.5})); QCOMPARE(pair(stages[4]), (std::vector{121, 122, 0.5, 0.5})); QVERIFY(indexOf(stages[5].table[0]) == 136 && std::abs(stages[5].weight[1] - 0.2f) < 1e-6); // Tint alone still makes the white balance stage. CameraRawSettings tint; tint.tint = -25; const std::vector tinted = CameraRawTables::stages(tint, {}); QVERIFY(tinted.size() == 1 && indexOf(tinted[0].table[0]) == 4 * 9 + 3); } // Seven brightnesses down, seven values across, each read alone. void CameraRawTablesTests::theAdaptiveSlidersBlendAcrossBrightness() { const auto four = [](const CameraRawStage &stage) { return std::vector{double(indexOf(stage.table[0])), double(indexOf(stage.table[1])), double(indexOf(stage.table[2])), double(indexOf(stage.table[3])), stage.weight[0], stage.weight[1], stage.weight[2], stage.weight[3]}; }; CameraRawSettings settings; settings.contrast = 10; settings.highlights = -100; settings.shadows = 100; settings.saturation = 25; const std::vector stages = CameraRawTables::stages(settings, {120, 250, 30}); QCOMPARE(stages.size(), size_t(4)); QCOMPARE(four(stages[0]), (std::vector{155, 156, 162, 163, 0.23076923191547394, 0.1538461595773697, 0.3692307770252228, 0.2461538463830948})); QCOMPARE(four(stages[1]), (std::vector{187, 188, 194, 195, 1, 0, 0, 0})); QCOMPARE(four(stages[2]), (std::vector{276, 277, 283, 284, 0, 0, 0, 1})); QCOMPARE(indexOf(stages[3].table[0]), 125); // Contrast reads the brightest channel, Highlights the log-average. settings = CameraRawSettings(); settings.contrast = -37.5; settings.highlights = 50; const std::vector low = CameraRawTables::stages(settings, {53, 0, 224}); QCOMPARE(four(low[0]), (std::vector{139, 140, 146, 147, 0.5, 0.5, 0, 0})); QCOMPARE(four(low[1]), (std::vector{226, 227, 233, 234, 0, 0, 0, 1})); // On a measured point the lower pair takes it whole. settings = CameraRawSettings(); settings.shadows = 25; const std::vector on = CameraRawTables::stages(settings, {0, 104, 0}); QCOMPARE(four(on[0]), (std::vector{246, 247, 253, 254, 0, 0, 0, 1})); // Two colours: Python's own reading of each measure. QImage two = BrushRaster::context(2, 1, false); two.setPixelColor(0, 0, QColor(200, 40, 20)); two.setPixelColor(1, 0, QColor(20, 100, 180)); const CameraRawTables::Brightness colours = CameraRawTables::brightness(two.constBits(), 2, 1, two.bytesPerLine()); QVERIFY(std::abs(colours.brightest - 190.342675743) < 1e-6 && std::abs(colours.luminance - 101.694057272) < 1e-6); QVERIFY(std::abs(colours.logBrightest - 189.755128630) < 1e-6); // A mid-gray picture reads 128 by every measure. const QImage mid = gray(8, 8); const CameraRawTables::Brightness read = CameraRawTables::brightness(mid.constBits(), 8, 8, mid.bytesPerLine()); QVERIFY(std::abs(read.brightest - 128) < 0.01 && std::abs(read.luminance - 128) < 0.01 && std::abs(read.logBrightest - 128) < 0.01); } namespace { // Each slot: index and weight, a null table reading −1. std::vector listed(const CameraRawStage &stage, int filled) { std::vector out; for (int slot = 0; slot < filled; ++slot) { out.push_back(indexOf(stage.table[slot])); out.push_back(stage.weight[slot]); } return out; } } // Mixer, Calibration, the parametric curve and Grading, against Python. void CameraRawTablesTests::theColourGroupsPickTheirTables() { CameraRawGradingSettings grading{{210, 40, -20}, {100, 25, 10}, {30, 55, 15}, {300, 10, -5}, 70, -30}; const std::vector graded = CameraRawTables::gradingStages(grading); QCOMPARE(graded.size(), size_t(8)); QCOMPARE(listed(graded[0], 2), (std::vector{744, 0.4f, 745, 0.6f})); QCOMPARE(listed(graded[3], 2), (std::vector{759, 0.1f, 760, 0.9f})); QCOMPARE(listed(graded[4], 4), (std::vector{-1, 0.6f, 665, 0.4f, -1, 0, 668, 0})); QCOMPARE(listed(graded[5], 4), (std::vector{-1, 0, 608, 0.6666666865348816, -1, 0, 611, 0.3333333432674408})); QCOMPARE(listed(graded[6], 8), (std::vector{566, 0.4343999922275543, 567, 0.1656000018119812, 569, 0, 570, 0, 710, 0.2896000146865845, 711, 0.1103999987244606, 713, 0, 714, 0})); QCOMPARE(listed(graded[7], 8), (std::vector{549, 0.5472000241279602, 550, 0.052799999713897705, 552, 0, 553, 0, 693, 0.36480000615119934, 694, 0.03519999980926514, 696, 0, 697, 0})); // Past 330 a wheel wraps round to red's tables. CameraRawGradingSettings wrapped; wrapped.global = {345, 50, 0}; QCOMPARE(listed(CameraRawTables::gradingStages(wrapped).at(0), 4), (std::vector{668, 0, 669, 0.5, 635, 0, 636, 0.5})); // Below Blending 50: the Blending 0 tables, then 50. CameraRawGradingSettings unblended; unblended.highlights = {180, 100, 0}; unblended.blending = 0; QCOMPARE(listed(CameraRawTables::gradingStages(unblended).at(0), 8), (std::vector{510, 0, 511, 1, 513, 0, 514, 0, 582, 0, 583, 0, 585, 0, 586, 0})); // Balance +50 doubles the highlight wheel's share. CameraRawGradingSettings lifted; lifted.highlights = {30, 20, 0}; lifted.balance = 50; QCOMPARE(listed(CameraRawTables::gradingStages(lifted).at(0), 8), (std::vector{494, 0, 495, 0, 497, 0, 498, 0, 566, 0.4f, 567, 0.6f, 569, 0, 570, 0})); // Midtones' and highlights' luminance keep their own tables. CameraRawGradingSettings toned; toned.midtones.luminance = 60; toned.highlights.luminance = -40; const std::vector lumas = CameraRawTables::gradingStages(toned); QVERIFY(listed(lumas.at(0), 2) == (std::vector{751, 0.8f, 752, 0.2f}) && listed(lumas.at(1), 2) == (std::vector{754, 0.8f, 755, 0.2f})); // Balance ±50 weighs the shadow and highlight shares apart. CameraRawGradingSettings shaded; shaded.shadows = {0, 100, 0}; shaded.balance = 50; QCOMPARE(listed(CameraRawTables::gradingStages(shaded).at(0), 8), (std::vector{455, 0, 456, 0, 458, 0, 459, 0, 527, 0.8f, 528, 0.2f, 530, 0, 531, 0})); shaded.shadows = {0, 40, 0}; shaded.highlights = {0, 100, 0}; shaded.balance = -50; const std::vector weighed = CameraRawTables::gradingStages(shaded); QCOMPARE(listed(weighed.at(0), 8), (std::vector{491, 0, 492, 0, 494, 0, 495, 0, 563, 0.8f, 564, 0.2f, 566, 0, 567, 0})); QCOMPARE(listed(weighed.at(1), 8), (std::vector{456, 0, 457, 0, 459, 0, 460, 0, 528, 0.72f, 529, 0.28f, 531, 0, 532, 0})); // Balance +100 leaves the shadow wheel no share at all. CameraRawGradingSettings balanced; balanced.shadows = {200, 40, 0}; balanced.highlights = {30, 20, 0}; balanced.balance = 100; QCOMPARE(CameraRawTables::gradingStages(balanced).size(), size_t(1)); CameraRawMixerSettings mixer; for (size_t index = 0; index < 8; ++index) { mixer.hue[index] = 5 + double(index); mixer.saturation[index] = -30 + 7 * double(index); mixer.luminance[index] = 20 - 4 * double(index); } const std::vector mixed = CameraRawTables::mixerStages(mixer); QCOMPARE(mixed.size(), size_t(23)); QCOMPARE(listed(mixed[0], 2), (std::vector{287, 0.6f, 288, 0.4f})); QCOMPARE(listed(mixed[5], 2), (std::vector{316, 0.08f, 317, 0.92f})); QCOMPARE(listed(mixed[22], 2), (std::vector{402, 0.76f, 403, 0.24f})); CameraRawSettings settings; settings.calibration = {CameraRawProcessVersion::version6, 15, 80, -40, 30, 0, -70, 50}; settings.curve.shadows = -60; settings.curve.darks = 10; settings.curve.highlights = 75; const std::vector stages = CameraRawTables::stages(settings, {}); QCOMPARE(stages.size(), size_t(8)); QCOMPARE(listed(stages[0], 2), (std::vector{408, 0.4f, 409, 0.6f})); QCOMPARE(listed(stages[1], 2), (std::vector{411, 0.8f, 412, 0.2f})); QCOMPARE(listed(stages[2], 2), (std::vector{417, 0.4f, 418, 0.6f})); QCOMPARE(listed(stages[3], 2), (std::vector{425, 0.4f, 426, 0.6f})); QCOMPARE(listed(stages[4], 2), (std::vector{433, 1, 434, 0})); QCOMPARE(listed(stages[5], 2), (std::vector{435, 0.2f, 436, 0.8f})); QCOMPARE(listed(stages[7], 2), (std::vector{453, 0.5f, 454, 0.5f})); // Calibration first, Light and Color, then the measured curve. CameraRawSettings ordered; ordered.calibration.redHue = 60; ordered.exposure = 1; ordered.curve.darks = -60; const std::vector run = CameraRawTables::stages(ordered, {}); QCOMPARE(run.size(), size_t(3)); QVERIFY(listed(run[0], 2) == (std::vector{408, 0.8f, 409, 0.2f}) && listed(run[1], 2) == (std::vector{93, 1, 94, 0})); QCOMPARE(listed(run[2], 2), (std::vector{440, 0.2f, 441, 0.8f})); // Moved dividers leave the curve to the formula. settings.curve.lightSplit = 70; QCOMPARE(CameraRawTables::stages(settings, {}).size(), size_t(5)); QCOMPARE(indexOf(CameraRawTables::exposureTables()), 81); } void CameraRawTablesTests::neutralizeFindsTheGridsGrayest() { // Python's own search over the same tables found these. const CameraRawSettings::Balance warm = CameraRawTables::neutralize(160 / 255.0, 140 / 255.0, 120 / 255.0).value(); QVERIFY(warm.temperature == -19 && warm.tint == -6); const CameraRawSettings::Balance blue = CameraRawTables::neutralize(0.2, 0.45, 0.8).value(); QVERIFY(blue.temperature == 100 && blue.tint == 26); const CameraRawSettings::Balance green = CameraRawTables::neutralize(0.3, 0.5, 0.25).value(); QVERIFY(green.temperature == 5 && green.tint == 91); // White stays white anywhere: the first of the ties wins. const CameraRawSettings::Balance white = CameraRawTables::neutralize(1, 1, 1).value(); QVERIFY(white.temperature == 0 && white.tint == 0); // A refinement past −100 keeps to the range. const CameraRawSettings::Balance edge = CameraRawTables::neutralize(84 / 255.0, 1 / 255.0, 97 / 255.0).value(); QVERIFY(edge.temperature == -16 && edge.tint == -100); const CameraRawSettings::Balance hot = CameraRawTables::neutralize(240 / 255.0, 80 / 255.0, 40 / 255.0).value(); QVERIFY(hot.temperature == -100 && hot.tint == -13.5); // Ties among searched points: tint rising within each temperature. const CameraRawSettings::Balance tie = CameraRawTables::neutralize(144 / 255.0, 216 / 255.0, 47 / 255.0).value(); QVERIFY(tie.temperature == -100 && tie.tint == 82); // Any channel missing leaves nothing to balance from. QVERIFY(!CameraRawTables::neutralize(0.5, 0.0001, 0.5)); QVERIFY(!CameraRawTables::neutralize(0, 128 / 255.0, 128 / 255.0)); QVERIFY(!CameraRawTables::neutralize(128 / 255.0, 128 / 255.0, 0)); QVERIFY(CameraRawTables::neutralize(0.5, 0.00011, 0.5)); } void CameraRawTablesTests::identitySlidersComposeNothing() { const std::vector none = CameraRawTables::stages(CameraRawSettings(), {}); QVERIFY(none.empty() && CameraRawTables::compose(none).empty()); CameraRawSettings exposure; exposure.exposure = 0.5; const std::vector composed = CameraRawTables::compose(CameraRawTables::stages(exposure, {})); QCOMPARE(composed.size(), size_t(33) * 33 * 33 * 3); // The corners are its table's own black and white. QVERIFY(composed[0] == entry(92, 0)[0] / 255.0f && composed.back() == entry(92, 4912)[2] / 255.0f); // Three stages in their order, against Python's own run. CameraRawSettings three; three.exposure = 1; three.temperature = 40; three.contrast = 50; const std::vector run = CameraRawTables::compose(CameraRawTables::stages(three, {})); const auto at = [&](int r, int g, int b) { const size_t index = ((size_t(r) * 33 + g) * 33 + b) * 3; return std::array{run[index], run[index + 1], run[index + 2]}; }; const auto near = [](std::array got, std::array expected) { return std::abs(got[0] - expected[0]) < 1e-6f && std::abs(got[1] - expected[1]) < 1e-6f && std::abs(got[2] - expected[2]) < 1e-6f; }; QVERIFY(near(at(16, 16, 16), {0.94676805f, 0.86324614f, 0.75338721f})); QVERIFY(near(at(16, 4, 28), {0.87189686f, 0.55294615f, 0.98683822f})); } QTEST_GUILESS_MAIN(CameraRawTablesTests) #include "CameraRawTablesTests.moc"