Record that the file-size work passed independent review on round three
Round 1 found a real defect: moving code between files dropped three multi-line docstrings, and what dropped was contract — the rule that every search filter is one `? IS NULL OR` predicate in a literal statement, the as_holder sharing rule, the five arms of the ablation. Round 2 found the line numbers had been read off a tree pi-lens reflowed.
This commit is contained in:
1 parent
9682657da7
commit
be08e7bf9c
1 file changed
+1
@@ -334,6 +334,7 @@
|
||||
- 口径:`tokenize` 找连续 `#` 行块。全仓 **39 块 / 86 行 → 0 块**,每块压成一行,压的时候留承重那句,实测数字与错误原文不删(`Unable to allocate 582. MiB for an array with shape (5632, 9024, 3)`、`288,266 rows for 165,973 atoms`、`[^[^\W\s]` 在 3.14 会吃掉 CJK)
|
||||
- docstring 不动(全仓多行 docstring 114 条,与父提交同数):docstring 是模块与函数的契约,不是注释;p1-4 review 用的口径也是「新增多行 docstring 数不得增加」。第一轮 review 抓到搬家途中塌了 3 条——`store_search.py` 的 `search_atoms`(那条「每个过滤条件都是同一条字面 SQL 里的 `? IS NULL OR` 谓词」规则和 `as_holder` 的共享规则)和 `FtsPage`、`bench/run.py` 的模块 docstring——已按原文补回,行数仍全部在 500 以内
|
||||
- 门禁:`pytest -q` **269 passed**;`ruff check backend/src/ely_eye backend/tests bench` All checks passed;mypy 冷缓存 **24 errors / 9 files**(基线 24/6,training.py 那 6 条随拆分落到 4 个新文件,净新增 0);`pyright` 查 46 个改动文件 → **4 errors**,与 HEAD 单个 `training.py` 在包副本里量到的 4 条同源(qwen_vl_utils 元组返回、两处 `save_pretrained(Path)`、`bitsandbytes` 未解析);go build/vet/test + gofmt 干净;`npm run build` + eslint 干净
|
||||
- herdr review(同一个 `p1review` pi,`strata/qwen3.8-flash-next-abliterated-iq3_s:high`)三轮:**round 1 FAIL 4** → **round 2 FAIL 1** → **round 3 PASS**。round 1 它自己跑出门禁、行数、搬体同一性、死代码、注释压缩、v1/v2/v3 全部承重,报的 4 条里 1 条是真产品缺陷:拆文件时掉了一些多行 docstring(全仓 114→111),掉的是契约不是装饰——`search_atoms` 的「每个过滤条件都是同一条字面 SQL 里的 `? IS NULL OR` 谓词」规则和 `as_holder` 共享规则、`FtsPage` 的游标理由、`bench/run.py` 的五臂说明(commit `28959c5` 按原文补回,114 条同父提交);其余 3 条是我写错的数:`store_search.py`/`bench/run.py`/`query_set.py` 行数、`cli.py` 调用点数(实为 11 个调用点亗 7 个方法)。round 2 剩 1 条:`migrations.py` 行号引成了 248/250,在 commit 里那是 PRAGMA 和空行——**根因是我在工作区量的,而 pi-lens 会在本轮之外重排文件把行号推下 9 行**;从此行号一律 `git show <sha>:path | grep -n` 从 commit 量(commit `9682657`)。round 3 它逐条重验:迁移阶梯 181/186/239/241/243 全中(并指出 `:243` 本身不带版本 token,`grep "v1\|v2"` 拓不到),CHECKLIST 那一行其余引用全部重验(`checks_cartridge.py:128`、`cartridge_assets.py:100/127/158`、`contradictions.py:114/135`、`config.py:20/27`、`cache_fabric.py:21`、`benchmarks.py:85`、`bench/build_screenspot.py:1/28`),`git diff --stat 28959c5..9682657` 只动一行,门禁重跑 269 passed / ruff / filesize_check 全绿
|
||||
|
||||
---
|
||||
|
||||
|
||||
Reference in new issue
Block a user