A review of 5289cb4 found the ASR report was not honest arithmetic:
- "audio s" was the last segment's end, not the media length. The real
container durations are 88.93 / 109.18 / 60.07 s, so the report understated
the audio by 48 s and every speed cell was wrong.
- Decoding was unpinned, so a rerun was a new draw: WER moved 0.242 to 0.262
and one video moved 0.278 to 0.583. Greedy single-temperature decoding with
no carry-over now answers the same way twice, and the harness runs the pass
twice to show it.
- The report claimed its WER was an upper bound. It is not a bound in either
direction: a caption that drops words also hides words the model dropped.
The denominators (201 / 296 / 36 reference words) are printed instead.
- "66 speech atoms" was bench-side arithmetic. The store now says 80 audio
atoms carrying 563 word timestamps, read back after a real ingest.
Same silent-skip bug in a second place: a text file over max_text_file_bytes
returned an empty batch with no reason. It raises FileTooLarge with its size,
and a walk records that refusal like any other.
Also fixed from the same review: the Go search tool never published the audio
modality, cli_senses carried a second json_dump, the no-audio-track branch had
a test that fed it markdown, _seconds was an empty wrapper, and the docstring
quoted a speed no report measured.
Gate root cause: bench/tests imports the bench package by name with no root
conftest, so bare pytest could not collect it at all. pythonpath in pyproject
fixes both launch styles; 212 tests pass either way.
Verification: 212 passed (bare pytest and python -m pytest), ruff clean,
mypy clean on the six touched files with a cold cache, repo-wide mypy 24/6
unchanged from HEAD, pyright 0 errors on the touched files, go build/vet/test
and gofmt clean.
bench — the measurement harness
Everything here measures the product as it is. No arm may read a benchmark gold label.
run order
python -m bench.fetch_corpus # 19 GB of third-party material -> bench/corpus + ~/ely_eye_bench_data
python -m bench.build_sets # freeze the 6 query sets -> bench/sets/
python -m bench.validate_sets # schema + gold + scope + modality checks (b-2 gate)
python -m bench.fetch_models # dense + rerank models used by the ablation arms
python -m bench.ingest_baseline # the unmodified product ingesting the whole corpus (16 -> 8 workers)
python -m bench.run # five-arm ablation + latency/scale -> bench/reports/BASELINE.md
python -m pytest bench/tests -q # metric definitions, hand-computed
bench/runs/ and bench/corpus/ are gitignored; bench/corpus/manifest.jsonl is tracked so the
corpus is reproducible from the manifest alone.
the arms (b-3)
| arm | what it is |
|---|---|
bm25_only |
the product's sparse signal alone |
dense_only |
the product's dense signal alone (product flag is off today) |
graph_only |
the product's graph signal alone — atom.relations is never populated, so it is a constant |
no_rerank |
the product's exact 0.55 / 0.35 / 0.10 fusion |
fusion_rerank |
the same fusion plus a cross-encoder rerank, the upper bound of the current design |
python -m bench.run also drives the unmodified RetrievalService.search over the merged
database and reports its latency plus how far its top-10 differs from the fast BM25 path.
known environment artifact
pi-lens' pyright reports Import "bench.sets_common" could not be resolved (and the same for
bench.metrics, bench.systems, ely_eye.*, cv2, onnxruntime, pypdf.errors) even though
every one of those imports works. It is not a repo defect:
effective_configon any bench file returns0 config file(s)withresolvedCwdat the repo root, so neitherpyproject.toml [tool.pyright]norpyrightconfig.json(both of which carryextraPaths: [".", "backend/src"]) is being read by that runner.- Runtime proof, run from the repo root with
.venvactive:
.venv/bin/python -c "import bench.sets_common, bench.metrics, bench.systems, bench.run, bench.ingest_baseline, \
bench.build_mmlongbench, ely_eye.config, ely_eye.db, cv2, onnxruntime, pypdf.errors; print('runtime proof OK')"
Treat that command as the check of record for import health; treat pyright's type findings
(it has caught real defects here: an AtomRunner typo, missing strict=True on zip,
dict[str, object] over-narrowing) as separate and worth fixing.
The pi-lens mypy cascade also replays stale findings after a fix: it attributes another
file's lines to whichever file was edited last (e.g. bench/fetch_models.py:107: "object" has no attribute "encode", where line 107 of that file is a Path call and the quoted text is
from bench/systems.py). The check of record is a fresh-cache run, which has passed on every
current file:
rm -rf /tmp/mypycache && .venv/bin/python -m mypy --cache-dir /tmp/mypycache bench/ # Success: no issues found
.venv/bin/python -m ruff check bench/ # All checks passed
.venv/bin/python -m pytest bench/tests -q # all green
corpus facts that constrain the numbers
- 50,789 sources / 5,308 queries (2,928 answerable, 2,380 unanswerable), all third-party.
- Video-MME ships mp4s for 129 of 900 videos; the set uses those 129 (387 questions).
- Video-MME has no temporal gold, so its gold region is the whole video — recorded in the set manifest.
- ScreenSpot-v2 boxes are
[x, y, w, h], verified against 755 image headers (xywh in bounds 1271/1272). - CodeSearchNet docstrings appear verbatim inside the code, so the query text is stripped before ingest or BM25 gets a free exact match.
- The product keys a source by
{stem[:48]}_{sha256[:16]}, so identical bytes in two sets collapse to one product source;ingest_report.jsonreportsshared_source_ids.