From fd12ace8bc094a3595aee5b34df43caaff31b7bb Mon Sep 17 00:00:00 2001 From: Ryan Hughes Date: Sat, 23 May 2026 05:29:53 -0400 Subject: [PATCH] installer: tolerate missing duration on finish --- bin/test-installer-ui-flow | 21 +++++++++++++++++++ .../usr/local/bin/omarchy-install-dashboard | 5 +++-- 2 files changed, 24 insertions(+), 2 deletions(-) diff --git a/bin/test-installer-ui-flow b/bin/test-installer-ui-flow index f35d07f..b4b337e 100755 --- a/bin/test-installer-ui-flow +++ b/bin/test-installer-ui-flow @@ -75,6 +75,19 @@ LOG EOF chmod +x "$success_worker" +no_duration_worker="$tmp/no-duration-worker" +cat >"$no_duration_worker" <"$fail_worker" </dev/null +assert_contains "$no_duration_capture" "Finished installing" + fail_state="$tmp/fail-state.json" fail_log="$tmp/fail.log" fail_capture="$tmp/fail.capture" diff --git a/configs/airootfs/usr/local/bin/omarchy-install-dashboard b/configs/airootfs/usr/local/bin/omarchy-install-dashboard index 48e6bd8..f21bca4 100755 --- a/configs/airootfs/usr/local/bin/omarchy-install-dashboard +++ b/configs/airootfs/usr/local/bin/omarchy-install-dashboard @@ -267,9 +267,10 @@ install_duration() { [[ -n $line ]] || continue duration="${line#*:}" duration="${duration#${duration%%[![:space:]]*}}" - [[ -n $duration ]] && { printf '%s' "$duration"; return; } + [[ -n $duration ]] && { printf '%s' "$duration"; return 0; } done done + return 0 } render_finish() { @@ -281,7 +282,7 @@ render_finish() { else render_logo >"$TTY_PATH" fi - duration="$(install_duration)" + duration="$(install_duration || true)" message="Finished installing" [[ -n $duration ]] && message="Installed in $duration" {