diff --git a/test/shell.d/security-bash-startup-test.sh b/test/shell.d/security-bash-startup-test.sh index 8ca8a324..f9c9d924 100755 --- a/test/shell.d/security-bash-startup-test.sh +++ b/test/shell.d/security-bash-startup-test.sh @@ -7,24 +7,24 @@ source "$(cd -- "$(dirname -- "${BASH_SOURCE[0]}")" && pwd)/base-test.sh" test_tmp=$(mktemp -d) trap 'rm -rf "$test_tmp"' EXIT -cat >"$test_tmp/entrypoint" <"$test_tmp/entrypoint" +# Privileged mode turned on after startup: the mode is set, the proof is not. +printf 'set -p\nsource "%s"\n%s\n' "$ROOT/bin/omarchy-security-functions" "$check" >"$test_tmp/late" chmod +x "$test_tmp/entrypoint" -"$test_tmp/entrypoint" || fail "a script started as bash -p passes the startup check" -( "$test_tmp/entrypoint" ) || fail "the startup check passes from a subshell" -pass "a script started as bash -p passes the startup check" +"$test_tmp/entrypoint" || fail "a script started as bash -p passes the startup check, from a subshell too" +pass "a script started as bash -p passes the startup check, from a subshell too" -if /usr/bin/bash -c "set -p; source '$ROOT/bin/omarchy-security-functions'; omarchy_security_require_privileged_bash_startup"; then - fail "bash that only turned -p on later is rejected" -fi +for arguments in "" "-p"; do + if /usr/bin/bash "$test_tmp/late" $arguments; then + fail "bash that only turned -p on later is rejected" "arguments: $arguments" + fi +done if /usr/bin/bash "$test_tmp/entrypoint"; then fail "a script not started with -p is rejected" fi -pass "bash not started with -p is rejected" +pass "bash not started with -p is rejected, whatever its other arguments" # arch-chroot runs the installer in a new PID namespace under the outer /proc, # so the caller's own PID is not the number /proc knows it by. @@ -32,8 +32,8 @@ in_new_pid_namespace=(unshare --user --map-root-user --fork --pid) if "${in_new_pid_namespace[@]}" /usr/bin/true 2>/dev/null; then "${in_new_pid_namespace[@]}" /usr/bin/bash -c "for i in {1..50}; do /usr/bin/true; done; '$test_tmp/entrypoint'; exit"