From 146fe5d368966560affe3a7e79f64c9c3c366d14 Mon Sep 17 00:00:00 2001 From: Omarchybot <317366263+omarchybot@users.noreply.github.com> Date: Thu, 1 Oct 2026 04:49:25 +0200 Subject: [PATCH] Say only what is true in the __sourceDir comment Bar widget instances are not handed sourceDir (ModuleSlot.injectProps sets only bar, moduleName and settings), and a plugin could reach its directory through Qt.resolvedUrl, so the comment's rationale was wrong on both counts. Two lines carry what the code cannot say. Co-Authored-By: Claude Opus 5.5 --- shell/shell.qml | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/shell/shell.qml b/shell/shell.qml index 8b4b82dc..e2ab310e 100644 --- a/shell/shell.qml +++ b/shell/shell.qml @@ -317,13 +317,8 @@ ShellRoot { if (!manifest) return null if (manifest.__isFirstParty) return manifest var copy = JSON.parse(JSON.stringify(manifest)) - // __sourceDir is the plugin's own install directory, not a privilege - // signal: a third-party service/panel plugin needs it to locate its - // bundled scripts and assets (barWidgets already receive it via - // meta.sourceDir, but service/panel instances get only this manifest). - // Stripping it left those plugins with no way to find their own files, - // silently breaking every plugin that shells out to a bundled script. - // Only the true privilege markers below are withheld from third parties. + // Keep __sourceDir: third-party plugins find their bundled scripts through it. + // Only the host trust markers are withheld. delete copy.__isFirstParty delete copy.__hostCapabilities return copy