Probe Hermes readiness by the flags omarchy-agent passes
Hermes v0.20 removed chat's --oneshot flag, which hermes_prompt_ready used as its capability marker. A fully bootstrapped Hermes Desktop install then read as not ready: --check failed forever, the default agent flow looped back into the installer, and --now dead-ended with "Launch Hermes Desktop once to finish installing it" on a machine where it already had. Probe for --tui and --query instead: the flags omarchy-agent actually passes to seed an interactive session, rather than one that merely shipped alongside them.
This commit is contained in:
2 files changed
+22
-5
No files matched your search
@@ -88,13 +88,16 @@ hermes_runs() {
|
|||||||
timeout 15 "$HOME/.local/bin/hermes" --version >/dev/null 2>&1
|
timeout 15 "$HOME/.local/bin/hermes" --version >/dev/null 2>&1
|
||||||
}
|
}
|
||||||
|
|
||||||
# The chat subcommand's --oneshot opt-out arrived with native interactive -q,
|
# Probed for the flags omarchy-agent actually passes -- --query to seed the
|
||||||
# so its presence is a stable capability check without relying on a version.
|
# session and --tui to keep it interactive -- rather than a flag that merely
|
||||||
|
# shipped alongside them: the previous marker, --oneshot, was dropped in Hermes
|
||||||
|
# v0.20 and left working installs stranded as "not ready".
|
||||||
hermes_prompt_ready() {
|
hermes_prompt_ready() {
|
||||||
local help
|
local help
|
||||||
hermes_runs &&
|
hermes_runs &&
|
||||||
help=$(timeout 15 "$HOME/.local/bin/hermes" chat --help 2>/dev/null) &&
|
help=$(timeout 15 "$HOME/.local/bin/hermes" chat --help 2>/dev/null) &&
|
||||||
grep -qF -- '--oneshot' <<<"$help"
|
grep -qF -- '--tui' <<<"$help" &&
|
||||||
|
grep -qF -- '--query' <<<"$help"
|
||||||
}
|
}
|
||||||
|
|
||||||
# --owns answers whether the wrapper on PATH is the one this command wrote, so
|
# --owns answers whether the wrapper on PATH is the one this command wrote, so
|
||||||
|
|||||||
@@ -98,7 +98,7 @@ mkdir -p "$test_home/.hermes/hermes-agent/venv/bin"
|
|||||||
cat >"$test_home/.hermes/hermes-agent/venv/bin/hermes" <<'SH'
|
cat >"$test_home/.hermes/hermes-agent/venv/bin/hermes" <<'SH'
|
||||||
#!/bin/bash
|
#!/bin/bash
|
||||||
if [[ ${1:-} == "chat" && ${2:-} == "--help" ]]; then
|
if [[ ${1:-} == "chat" && ${2:-} == "--help" ]]; then
|
||||||
[[ ${OMARCHY_TEST_HERMES_CAPABLE:-1} == 1 ]] && echo "--oneshot"
|
[[ ${OMARCHY_TEST_HERMES_CAPABLE:-1} == 1 ]] && echo "[-q QUERY, --query QUERY] [--tui]"
|
||||||
else
|
else
|
||||||
echo "hermes-agent 0.0.0-test"
|
echo "hermes-agent 0.0.0-test"
|
||||||
fi
|
fi
|
||||||
@@ -388,7 +388,7 @@ run_ready_check && fail "--check rejects the app's wrapper when its runtime is g
|
|||||||
cat >"$ready_home/.hermes/hermes-agent/venv/bin/hermes" <<'SH'
|
cat >"$ready_home/.hermes/hermes-agent/venv/bin/hermes" <<'SH'
|
||||||
#!/bin/bash
|
#!/bin/bash
|
||||||
if [[ ${1:-} == "chat" && ${2:-} == "--help" ]]; then
|
if [[ ${1:-} == "chat" && ${2:-} == "--help" ]]; then
|
||||||
echo "--oneshot"
|
echo "[-q QUERY, --query QUERY] [--tui]"
|
||||||
else
|
else
|
||||||
echo "hermes-agent 0.0.0-test"
|
echo "hermes-agent 0.0.0-test"
|
||||||
fi
|
fi
|
||||||
@@ -396,3 +396,17 @@ SH
|
|||||||
chmod +x "$ready_home/.hermes/hermes-agent/venv/bin/hermes"
|
chmod +x "$ready_home/.hermes/hermes-agent/venv/bin/hermes"
|
||||||
run_ready_check || fail "--check accepts the app's wrapper once it runs"
|
run_ready_check || fail "--check accepts the app's wrapper once it runs"
|
||||||
pass "readiness runs the app's command rather than trusting its marker"
|
pass "readiness runs the app's command rather than trusting its marker"
|
||||||
|
|
||||||
|
# A release whose help lists only the retired --oneshot marker cannot run the
|
||||||
|
# seeded --tui --query session omarchy-agent starts, so it is not ready.
|
||||||
|
cat >"$ready_home/.hermes/hermes-agent/venv/bin/hermes" <<'SH'
|
||||||
|
#!/bin/bash
|
||||||
|
if [[ ${1:-} == "chat" && ${2:-} == "--help" ]]; then
|
||||||
|
echo "--oneshot"
|
||||||
|
else
|
||||||
|
echo "hermes-agent 0.0.0-test"
|
||||||
|
fi
|
||||||
|
SH
|
||||||
|
chmod +x "$ready_home/.hermes/hermes-agent/venv/bin/hermes"
|
||||||
|
run_ready_check && fail "--check accepts a release without the flags omarchy-agent passes"
|
||||||
|
pass "a release listing only --oneshot is not prompt-ready"
|
||||||
Reference in new issue
Block a user