Translate finished messages by template and the world clock, Dropbox and scoped titles at display

test/shell.d/agents-panel-test.sh

@@ -31,7 +31,7 @@ assert(!/opacity: stale \?/.test(panelSource) && /I18n\.tr\("Last updated %1 ago
 assert(/onPickingChanged: resetKeys\(\)/.test(panelSource), 'the cursor starts over when the agent list comes or goes')
 assert(!/t === "a" \|\| t === "A"/.test(panelSource), 'adding an account has no hotkey; the + is the way in')
 assert(/if \(!accounts\[a\]\.active\) \{/.test(panelSource) && /if \(row\.length > 0\) rows\.push\(row\)/.test(panelSource), 'the active account with nothing to fix is not a keyboard stop')
-assert(/text: section\.provider \? I18n\.tr\(String\(section\.provider\.authHelpText \|\| section\.provider\.usageStatusText \|\| ""\)\) : ""/.test(panelSource), 'the trouble line falls back to the usage status when a record has no auth help')
+assert(/text: section\.provider \? I18n\.trMessage\(String\(section\.provider\.authHelpText \|\| section\.provider\.usageStatusText \|\| ""\)\) : ""/.test(panelSource), 'the trouble line falls back to the usage status when a record has no auth help')
 const mainSource = fs.readFileSync(root + '/shell/plugins/agents/Main.qml', 'utf8')
 assert(/var from = Math\.min\(0\.8, \(threshold - 15\) \/ 100\)/.test(mainSource), 'faster checks start 15 points below the switch threshold')
 assert(/rows\.push\(\[\{ kind: "provider", index: p \}\]\)/.test(panelSource), "every agent's header is a keyboard stop")

test/shell.d/notifications-test.sh

@@ -137,7 +137,7 @@ assertEqual(
 // belongs in the logic module, where the strip runs after it.
 const cardQml = fs.readFileSync(path.join(root, 'shell/plugins/notifications/components/NotificationCard.qml'), 'utf8')
 assert(
-  /readonly property string styledBody: NotificationLogic\.styledBody\(I18n\.tr\(body\), app, appIcon\)/.test(cardQml),
+  /readonly property string styledBody: NotificationLogic\.styledBody\(I18n\.trMessage\(body\), app, appIcon\)/.test(cardQml),
   'the notification card renders the body that was stripped after the newline rewrite'
 )
 assert(

test/shell.d/shell-i18n-test.sh

@@ -10,7 +10,7 @@ const vm = require('vm')
 
 const source = fs.readFileSync(path.join(root, 'shell/Commons/I18nZh.js'), 'utf8').replace('.pragma library', '')
 const context = {}
-vm.runInNewContext(source + '\nthis.table = table', context)
+vm.runInNewContext(source + '\nthis.table = table; this.templates = templates', context)
 const table = context.table
 
 const files = []
@@ -27,6 +27,12 @@ const missing = []
 let calls = 0
 for (const file of files) {
   const text = fs.readFileSync(file, 'utf8')
+  for (const list of text.matchAll(/I18n\.trMatch\([^\[]*\[([^\]]*)\]/g)) {
+    for (const item of list[1].matchAll(/"((?:[^"\\]|\\.)*)"/g)) {
+      const key = JSON.parse('"' + item[1] + '"')
+      if (!(key in table)) missing.push(`${path.relative(root, file)}: ${key}`)
+    }
+  }
   for (const match of text.matchAll(/I18n\.tr\(\s*"((?:[^"\\]|\\.)*)"/g)) {
     calls++
     const key = JSON.parse('"' + match[1] + '"')
@@ -34,6 +40,8 @@ for (const file of files) {
   }
 }
 assert(calls > 300, 'the shell routes its text through I18n.tr', `found ${calls} calls`)
+const missingTemplates = Array.from(context.templates).filter(t => !(t in table))
+assert(missingTemplates.length === 0, 'every message template has a Chinese entry', missingTemplates.join('\n'))
 assert(missing.length === 0, 'every I18n.tr text has a Chinese entry', missing.join('\n'))
 
 const placeholders = s => (s.match(/%\d/g) || []).sort().join(',')