David Heinemeier HanssonandClaude Opus 5.5
97a9fce54f
* Hand browser and web app launches to the running browser directly With a Chromium-based browser already running, each launch started a second browser process only to pass its command line over the profile's singleton socket and exit, ~165ms before the running browser even heard of it. omarchy-cmd-browser-handoff sends that message itself with socat and waits for the ACK, so a web app opens in ~210ms instead of ~430ms. It hands off only what it can do exactly as the browser would: the packaged browser binary rather than a wrapper, a flags file holding nothing beyond the process flags Omarchy ships, no other data directory, and a socket we own. Anything else, or no answer, launches the browser as before. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Hand Brave Origin launches to the running browser too /usr/bin/brave-origin is the package's own launcher, reading brave-origin-flags.conf, with the profile in BraveSoftware/Brave-Origin. A web app now opens in ~158ms instead of ~345ms. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
98 lines
3.8 KiB
Bash
98 lines
3.8 KiB
Bash
#!/bin/bash
|
|
|
|
set -euo pipefail
|
|
|
|
source "$(cd -- "$(dirname -- "${BASH_SOURCE[0]}")" && pwd)/base-test.sh"
|
|
|
|
test_tmp=$(mktemp -d)
|
|
trap 'rm -rf "$test_tmp"' EXIT
|
|
|
|
mock_bin="$test_tmp/bin"
|
|
test_home="$test_tmp/home"
|
|
mkdir -p "$mock_bin" "$test_home/.local/share/applications"
|
|
# Keep the launcher away from the running browser's singleton socket, which it
|
|
# would otherwise hand these test URLs to.
|
|
export XDG_CONFIG_HOME="$test_home/.config" XDG_DATA_HOME="$test_home/.local/share"
|
|
|
|
cat >"$test_home/.local/share/applications/chromium.desktop" <<'EOF'
|
|
[Desktop Entry]
|
|
Exec=chromium %U
|
|
EOF
|
|
|
|
cat >"$mock_bin/xdg-settings" <<'SH'
|
|
#!/bin/bash
|
|
[[ -z ${BROWSER:-} ]] || printf '%s\n' "$BROWSER" >"$OMARCHY_TEST_XDG_SETTINGS_BROWSER"
|
|
[[ ${OMARCHY_TEST_XDG_SETTINGS_EMPTY:-0} == "1" ]] || echo chromium.desktop
|
|
SH
|
|
cat >"$mock_bin/xdg-mime" <<'SH'
|
|
#!/bin/bash
|
|
if [[ $* == "query default x-scheme-handler/https" ]]; then
|
|
echo chromium.desktop
|
|
fi
|
|
SH
|
|
cat >"$mock_bin/chromium" <<'SH'
|
|
#!/bin/bash
|
|
exit 0
|
|
SH
|
|
cat >"$mock_bin/systemd-run" <<'SH'
|
|
#!/bin/bash
|
|
printf '%s\n' "$*" >"$OMARCHY_TEST_BROWSER_LAUNCH"
|
|
SH
|
|
cat >"$mock_bin/omarchy-hyprland-focus-app" <<'SH'
|
|
#!/bin/bash
|
|
printf '%s\n' "$1" >"$OMARCHY_TEST_BROWSER_FOCUS"
|
|
SH
|
|
chmod +x "$mock_bin"/*
|
|
|
|
launch_log="$test_tmp/launch"
|
|
focus_log="$test_tmp/focus"
|
|
xdg_settings_browser="$test_tmp/xdg-settings-browser"
|
|
HOME="$test_home" PATH="$mock_bin:$PATH" HYPRLAND_INSTANCE_SIGNATURE=test \
|
|
OMARCHY_TEST_BROWSER_LAUNCH="$launch_log" OMARCHY_TEST_BROWSER_FOCUS="$focus_log" \
|
|
bash "$ROOT/bin/omarchy-launch-browser"
|
|
|
|
[[ ! -e $focus_log ]] || fail "browser launcher leaves a new window on the current workspace"
|
|
|
|
HOME="$test_home" PATH="$mock_bin:$PATH" HYPRLAND_INSTANCE_SIGNATURE=test \
|
|
OMARCHY_TEST_BROWSER_LAUNCH="$launch_log" OMARCHY_TEST_BROWSER_FOCUS="$focus_log" \
|
|
bash "$ROOT/bin/omarchy-launch-browser" --private
|
|
|
|
[[ ! -e $focus_log ]] || fail "private browser launcher leaves a new window on the current workspace"
|
|
|
|
HOME="$test_home" PATH="$mock_bin:$PATH" HYPRLAND_INSTANCE_SIGNATURE=test \
|
|
OMARCHY_TEST_BROWSER_LAUNCH="$launch_log" OMARCHY_TEST_BROWSER_FOCUS="$focus_log" \
|
|
bash "$ROOT/bin/omarchy-launch-browser" "https://example.test/authorize"
|
|
|
|
grep -F 'https://example.test/authorize' "$launch_log" >/dev/null || fail "browser launcher passes through the URL"
|
|
grep -Fx '^chromium.*$' "$focus_log" >/dev/null || fail "browser launcher focuses the default browser window"
|
|
|
|
rm -f "$focus_log" "$xdg_settings_browser"
|
|
|
|
HOME="$test_home" PATH="$mock_bin:$PATH" HYPRLAND_INSTANCE_SIGNATURE=test \
|
|
BROWSER=omarchy-launch-browser OMARCHY_TEST_XDG_SETTINGS_EMPTY=1 \
|
|
OMARCHY_TEST_BROWSER_LAUNCH="$launch_log" OMARCHY_TEST_BROWSER_FOCUS="$focus_log" \
|
|
OMARCHY_TEST_XDG_SETTINGS_BROWSER="$xdg_settings_browser" \
|
|
bash "$ROOT/bin/omarchy-launch-browser" "https://example.test/fallback"
|
|
|
|
grep -F 'https://example.test/fallback' "$launch_log" >/dev/null ||
|
|
fail "browser launcher falls back to the HTTPS handler when xdg-settings is empty"
|
|
[[ ! -e $xdg_settings_browser ]] ||
|
|
fail "browser launcher unsets BROWSER before reading xdg-settings"
|
|
grep -Fx '^chromium.*$' "$focus_log" >/dev/null ||
|
|
fail "browser launcher focuses the browser resolved from the HTTPS handler"
|
|
|
|
pass "browser launcher follows opened links to the browser workspace"
|
|
|
|
rm -f "$launch_log"
|
|
cat >"$mock_bin/omarchy-cmd-browser-handoff" <<'SH'
|
|
#!/bin/bash
|
|
[[ $1 == "chromium" && $2 == "https://example.test/running" ]]
|
|
SH
|
|
chmod +x "$mock_bin/omarchy-cmd-browser-handoff"
|
|
|
|
HOME="$test_home" PATH="$mock_bin:$PATH" OMARCHY_TEST_BROWSER_LAUNCH="$launch_log" \
|
|
OMARCHY_TEST_BROWSER_FOCUS="$focus_log" bash "$ROOT/bin/omarchy-launch-browser" "https://example.test/running"
|
|
|
|
[[ ! -e $launch_log ]] || fail "browser launcher starts no browser when the running one takes the URL"
|
|
pass "browser launcher hands a URL to the running browser"
|