Gate first-run setup as one lifecycle

2026-07-17 07:59:16 -07:00
parent 39756d485d
commit 09aac40eae
6 changed files with 78 additions and 65 deletions
@@ -0,0 +1,35 @@
+#!/bin/bash
+
+source "$(dirname "$0")/base-test.sh"
+
+test_tmp=$(mktemp -d)
+trap 'rm -rf "$test_tmp"' EXIT
+
+mock_bin="$test_tmp/bin"
+mkdir -p "$mock_bin" "$test_tmp/home"
+
+cat >"$mock_bin/omarchy-done" <<'SH'
+#!/bin/bash
+[[ $1 == "check" && $2 == "first-run-user" ]]
+SH
+cat >"$mock_bin/omarchy-finalize-user" <<'SH'
+#!/bin/bash
+touch "$OMARCHY_TEST_FINALIZE_CALLED"
+SH
+chmod +x "$mock_bin/omarchy-done" "$mock_bin/omarchy-finalize-user"
+
+finalize_called="$test_tmp/finalize-called"
+HOME="$test_tmp/home" PATH="$mock_bin:$PATH" OMARCHY_TEST_FINALIZE_CALLED="$finalize_called" \
+  bash "$ROOT/bin/omarchy-first-run" >"$test_tmp/output"
+
+[[ ! -e $finalize_called ]] || fail "completed first-run exits before any setup step"
+grep -F 'First-run already complete' "$test_tmp/output" >/dev/null || fail "completed first-run reports its lifecycle gate"
+
+if grep -F 'user-migration-notify-watch-enabled' "$ROOT/bin/omarchy-first-run" >/dev/null; then
+  fail "first-run does not track the migration watcher separately"
+fi
+if grep -F 'skip-first-run-update-notification' "$ROOT/install/user/first-run/wifi.sh" >/dev/null; then
+  fail "first-run does not track update notifications separately"
+fi
+
+pass "first-run uses one lifecycle completion marker"