Constrain the tzupdate sudoers rule to a single timezone argument (#8194)

The wildcard granted passwordless root for timedatectl set-timezone plus any trailing arguments, so -H/--host and -M/--machine reached the SSH and machine transports as root. Systemd 261 guards argv injection into ssh, but -H still drives root's SSH client at an attacker-chosen host, and the transport resolves its helper through PATH; only Defaults secure_path stands between that and a planted ssh running as root. Match the argument with an anchored POSIX ERE that admits exactly one timezone token (no whitespace, no leading-dash segment, no traversal component), so no second argument and no option can ever match. The sole caller, omarchy-menu-timezone, passes one list-timezones value and is unaffected.

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
Co-authored-by: Codex XHigh <noreply@openai.com>

This commit is contained in:

Omarchybot

2026-08-25 22:30:09 +02:00

committed by

GitHub

co-authored by

Claude Opus 4.8

Codex XHigh

parent 77305ed3b9

commit 0ae1694830

2 changed files with 5 additions and 2 deletions

etc/sudoers.d/omarchy-tzupdate

+1 -1

View File

@@ -1 +1 @@
 %wheel ALL=(root) NOPASSWD: /usr/bin/timedatectl set-timezone *
 %wheel ALL=(root) NOPASSWD: /usr/bin/timedatectl ^set-timezone [A-Za-z0-9_+][A-Za-z0-9_+.-]*(/[A-Za-z0-9_+][A-Za-z0-9_+.-]*)*$