From 12c350e404acaa8149bd5cb4c783ba7f52cb78ef Mon Sep 17 00:00:00 2001 From: David Heinemeier Hansson Date: Tue, 25 Aug 2026 08:45:50 +0200 Subject: [PATCH] Match the Windows VM title regardless of the launcher's shell quoting The new assertion pinned /title:"Windows VM - Omarchy" with the quote sitting immediately after the colon. That quote is incidental shell syntax, not the title the Hyprland rule matches on. Open PR #7902 moves the RDP arguments into an array, where the same flag reads "/title:Windows VM - Omarchy", so the assertion would fail for whichever of the two pull requests merged second. Allow an optional quote after the colon. The assertion still fails if the title itself drifts, in either direction, which is the coupling it exists to protect. Co-Authored-By: Claude Opus 5 (1M context) --- test/shell.d/windows-vm-test.sh | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/test/shell.d/windows-vm-test.sh b/test/shell.d/windows-vm-test.sh index 181a0b02..e2a04dae 100644 --- a/test/shell.d/windows-vm-test.sh +++ b/test/shell.d/windows-vm-test.sh @@ -16,7 +16,9 @@ if rg -q '^ restart: unless-stopped$' "$windows_vm_command"; then fi pass "Windows VM does not restart automatically at boot" -rg -q '/title:"Windows VM - Omarchy"' "$windows_vm_command" || +# Tolerate either shell quoting of the argument -- what must not drift is the +# title itself, since the Hyprland rule below matches on it. +rg -q 'title:"?Windows VM - Omarchy"' "$windows_vm_command" || fail "Windows VM launches FreeRDP with its expected title" rg -q 'class = "\^xfreerdp\$", title = "\^Windows VM - Omarchy\$"' "$windows_vm_rules" || fail "Windows VM opacity rule targets its FreeRDP window"