Lift setting / vertical / barSize onto BarWidget

Six widgets (clock, daytime, keyboardLayout, lockKeys, activeWindow,
media) shipped identical copies of `function setting(name, fallback)`.
Eight widgets reimplemented `readonly property bool vertical`, and
three reimplemented `readonly property int barSize`. Move all three
onto the BarWidget base so widgets read the same wiring everyone else
gets for free.

While in here, drop the dead `setting()` declaration on media.qml — it
was defined but never called.
This commit is contained in:
David Heinemeier Hansson
2026-05-20 19:50:10 +02:00
parent 4d58dfa27a
commit 16604c67b3
12 changed files with 23 additions and 51 deletions
+1 -6
View File
@@ -9,11 +9,6 @@ BarWidget {
moduleName: "media"
function setting(name, fallback) {
var value = settings ? settings[name] : undefined
return value === undefined || value === null ? fallback : value
}
readonly property var players: Mpris.players ? Mpris.players.values : []
readonly property var activePlayer: {
var playing = null
@@ -38,7 +33,7 @@ BarWidget {
visible: hasMedia
implicitWidth: hasMedia ? row.implicitWidth + Style.space(14) : 0
implicitHeight: bar ? bar.barSize : 26
implicitHeight: barSize
Row {
id: row