From 48dacca6eaa57cdac6726457a8ffcaf7ae3cc3e3 Mon Sep 17 00:00:00 2001 From: David Heinemeier Hansson Date: Tue, 19 May 2026 12:00:15 +0200 Subject: [PATCH] Not needed --- AGENTS.md | 3 ++- shell/plugins/notifications/Service.qml | 20 -------------------- 2 files changed, 2 insertions(+), 21 deletions(-) diff --git a/AGENTS.md b/AGENTS.md index 4f514fe2..014ed3a5 100644 --- a/AGENTS.md +++ b/AGENTS.md @@ -60,7 +60,8 @@ Example: # Runtime Environment -- Commands in `bin/` should rely on `$OMARCHY_PATH` from the uwsm environment; do not set or default `OMARCHY_PATH` manually there. +- `$OMARCHY_PATH` is set at the top level by the uwsm session environment and is always available to Omarchy runtime code. +- Commands in `bin/` and Quickshell QML should rely on `$OMARCHY_PATH` / `Quickshell.env("OMARCHY_PATH")`; do not derive fallback paths from `HOME`, `Quickshell.shellDir`, or re-export/default `OMARCHY_PATH` manually. # Install Scripts diff --git a/shell/plugins/notifications/Service.qml b/shell/plugins/notifications/Service.qml index 3eff0eea..9ae3bb65 100644 --- a/shell/plugins/notifications/Service.qml +++ b/shell/plugins/notifications/Service.qml @@ -383,25 +383,6 @@ Item { Process { id: focusAppProc; running: false } - // Open the popup's large image in the user's default image viewer. - // image:// URIs come from the upstream raw-bytes provider and have no - // on-disk path to hand to xdg-open, so we just dismiss in that case. - function openPopupImage(index) { - if (index < 0 || index >= popupModel.count) return - var entry = popupModel.get(index) - if (!entry) return - var image = String(entry.image || "") - if (image.indexOf("file://") === 0) { - var lower = image.toLowerCase() - if (lower.endsWith(".png") || lower.endsWith(".jpg") || - lower.endsWith(".jpeg") || lower.endsWith(".webp")) { - var path = decodeURIComponent(image.substring(7)) - Quickshell.execDetached(["xdg-open", path]) - } - } - dismissPopup(index) - } - // ---------------------------------------------------- image cache // // Notifications coming from screenshot helpers ship an `image-path` hint @@ -879,7 +860,6 @@ Item { onCloseRequested: service.dismissPopup(cardSlot.index) onCardClicked: service.invokePopupDefault(cardSlot.index) - onImageClicked: service.openPopupImage(cardSlot.index) } } }