Fail the sudoers cleanup when it cannot elevate to look

Running the migration on a real machine with no cached sudo credentials
printed sudo's "a terminal is required to read the password" and still
exited 0. bin/omarchy-migrate writes the completion marker on a zero exit,
so the cleanup would have been recorded as done on every install that runs
migrations without a terminal, and never tried again.

Probe for elevation before the combined existence check and exit non-zero
when it fails, so the marker stays unwritten and the next run retries. The
probe is skipped when the directory is readable as-is, which is the case
when migrations run as root.
This commit is contained in:
acrogenesis
2026-08-29 19:23:02 -06:00
parent 394c1371c9
commit 80e7c25b37
2 changed files with 52 additions and 2 deletions
+12 -2
View File
@@ -239,11 +239,21 @@ plymouth_unit_runs_from_home() {
# logged-in user, so an unelevated [[ -f ]] on a file in there is false whether or
# not the file exists and an unelevated read returns nothing. Both tests and both
# reads have to be elevated or this migration reports success having done nothing.
# One combined probe first, so the common case of neither file being present costs
# a single sudo call rather than one per file.
first_run_sudoers="$sudoers_dir/first-run"
tsui_sudoers="$sudoers_dir/tsui"
# Sudo cannot prompt without a terminal, and omarchy-migrate runs from places that
# have none. Failing the elevation probe there is indistinguishable from finding
# no files, and since bin/omarchy-migrate writes the completion marker on a zero
# exit, a silent skip would mark this migration done forever. Exit non-zero
# instead so the marker stays unwritten and the next run tries again.
if [[ ! -r $sudoers_dir ]] && ! as_root true 2>/dev/null; then
echo "Cannot inspect $sudoers_dir without elevation; leaving it for the next run." >&2
exit 1
fi
# One combined probe, so the common case of neither file being present costs a
# single elevated call rather than one per file.
if as_root test -e "$first_run_sudoers" -o -e "$tsui_sudoers"; then
if as_root test -f "$first_run_sudoers" &&
as_root cat "$first_run_sudoers" | first_run_sudoers_is_generated; then