ZacharyZhang-NY/omarchycn
2
2
Fork 0
Code Issues Pull Requests 2 Actions 1 Packages Projects Releases 3 Wiki Activity

Fix notification focus for agent terminals (#6801)

Browse Source 
* Fix notification focus for agent terminals

* Restrict notification title fallback to agents

* Simplify the focus fallback to a lazy two-tier query

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

---------

Co-authored-by: David Heinemeier Hansson <david@hey.com>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
Aleksandar Tomašević
2026-08-13 20:28:43 +02:00
committed by GitHub
co-authored by Claude Fable 5 David Heinemeier Hansson
parent 14dc3a31d1
commit 82ae514609
2 changed files with 41 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/shell.d/hyprland-focus-app-test.sh
+32 -3
View File
@@ -13,7 +13,7 @@ mkdir -p "$mock_bin"
cat >"$mock_bin/hyprctl" <<'SH'
#!/bin/bash
if [[ $1 == "clients" ]]; then
printf '[{"address":"0xabc","class":"chromium"}]\n'
printf '%s\n' "$OMARCHY_TEST_CLIENTS_JSON"
elif [[ $1 == "dispatch" ]]; then
printf '%s\n' "$2" >"$OMARCHY_TEST_FOCUS_DISPATCH"
fi
@@ -21,10 +21,39 @@ SH
chmod +x "$mock_bin/hyprctl"
dispatch_log="$test_tmp/dispatch"
PATH="$mock_bin:$PATH" OMARCHY_TEST_FOCUS_DISPATCH="$dispatch_log" \
bash "$ROOT/bin/omarchy-hyprland-focus-app" chromium
clients_json='[{"address":"0xabc","class":"chromium"}]'
PATH="$mock_bin:$PATH" OMARCHY_TEST_CLIENTS_JSON="$clients_json" \
OMARCHY_TEST_FOCUS_DISPATCH="$dispatch_log" \
bash "$ROOT/bin/omarchy-hyprland-focus-app" '^chromium$'
grep -F 'hl.dsp.focus({ window = "address:0xabc" })' "$dispatch_log" >/dev/null || \
fail "app focus uses the workspace-aware Hyprland dispatcher"
pass "app focus follows windows across workspaces"
clients_json='[
{"address":"0xviber","class":"com.viber.Viber","initialClass":"com.viber.Viber","initialTitle":"Viber"},
{"address":"0xagent","class":"org.omarchy.agent","initialClass":"org.omarchy.agent","initialTitle":"kitty"}
]'
PATH="$mock_bin:$PATH" OMARCHY_TEST_CLIENTS_JSON="$clients_json" \
OMARCHY_TEST_FOCUS_DISPATCH="$dispatch_log" \
bash "$ROOT/bin/omarchy-hyprland-focus-app" kitty
grep -F 'hl.dsp.focus({ window = "address:0xagent" })' "$dispatch_log" >/dev/null || \
fail "app focus falls back to the initial window title"
pass "app focus finds terminals launched under a shared agent class"
clients_json='[
{"address":"0xbrowser","class":"chromium","initialClass":"chromium","initialTitle":"Mail settings"}
]'
rm -f "$dispatch_log"
if PATH="$mock_bin:$PATH" OMARCHY_TEST_CLIENTS_JSON="$clients_json" \
OMARCHY_TEST_FOCUS_DISPATCH="$dispatch_log" \
bash "$ROOT/bin/omarchy-hyprland-focus-app" Mail; then
fail "app focus rejects title matches from non-agent windows"
fi
[[ ! -e $dispatch_log ]] || fail "app focus leaves focus unchanged for unrelated title matches"
pass "app focus restricts title matching to agent terminals"