Support external monitor brightness in Quattro (#6490)
* Support external monitor brightness Route brightness through the focused Hyprland monitor so internal panels keep using the kernel backlight while compatible external displays use DDC/CI. Preserve the Apple Display backend and leave brightness unavailable when the focused display cannot be controlled. Add cached DDC bus and VCP range handling, install ddcutil for new and existing systems, and cover backend selection and brightness conversion with shell tests. * Harden external brightness caching --------- Co-authored-by: David Heinemeier Hansson <david@hey.com>
This commit is contained in:
ssupt
co-authored by
David Heinemeier Hansson
David Heinemeier Hansson
parent
fa3d28ca61
commit
c0d4037237
Executable
+146
@@ -0,0 +1,146 @@
|
||||
#!/bin/bash
|
||||
|
||||
set -euo pipefail
|
||||
|
||||
source "$(cd -- "$(dirname -- "${BASH_SOURCE[0]}")" && pwd)/base-test.sh"
|
||||
|
||||
test_tmp=$(mktemp -d)
|
||||
trap 'rm -rf "$test_tmp"' EXIT
|
||||
|
||||
mock_bin="$test_tmp/bin"
|
||||
call_log="$test_tmp/calls"
|
||||
runtime_dir="$test_tmp/runtime"
|
||||
mkdir -p "$mock_bin" "$runtime_dir"
|
||||
|
||||
cat >"$mock_bin/omarchy-hyprland-monitor-focused-apple" <<'SH'
|
||||
#!/bin/bash
|
||||
exit 1
|
||||
SH
|
||||
|
||||
cat >"$mock_bin/omarchy-hyprland-monitor-focused" <<'SH'
|
||||
#!/bin/bash
|
||||
printf '%s\n' "${FOCUSED_MONITOR:-eDP-1}"
|
||||
SH
|
||||
|
||||
cat >"$mock_bin/omarchy-hw-display" <<'SH'
|
||||
#!/bin/bash
|
||||
printf 'mock_backlight\n'
|
||||
SH
|
||||
|
||||
cat >"$mock_bin/brightnessctl" <<'SH'
|
||||
#!/bin/bash
|
||||
printf 'brightnessctl %s\n' "$*" >>"$CALL_LOG"
|
||||
if [[ $* == *" -m"* ]]; then
|
||||
printf 'mock_backlight,backlight,40,40%%\n'
|
||||
fi
|
||||
SH
|
||||
|
||||
cat >"$mock_bin/ddcutil" <<'SH'
|
||||
#!/bin/bash
|
||||
printf 'ddcutil %s\n' "$*" >>"$CALL_LOG"
|
||||
|
||||
if [[ $* == *" detect --brief"* ]]; then
|
||||
cat <<EOF
|
||||
Display 1
|
||||
I2C bus: /dev/i2c-${DDC_BUS:-7}
|
||||
DRM connector: card1-${DDC_CONNECTOR:-DP-1}
|
||||
EOF
|
||||
elif [[ $* == *" getvcp 10 "* ]]; then
|
||||
[[ ${DDC_READ_FAIL:-0} == "1" ]] && exit 1
|
||||
printf 'VCP 10 C %s %s\n' "${DDC_CURRENT:-40}" "${DDC_MAXIMUM:-80}"
|
||||
fi
|
||||
SH
|
||||
|
||||
chmod +x "$mock_bin"/*
|
||||
|
||||
run_brightness() {
|
||||
CALL_LOG="$call_log" XDG_RUNTIME_DIR="$runtime_dir" PATH="$mock_bin:$ROOT/bin:$PATH" \
|
||||
"$ROOT/bin/omarchy-brightness-display" "$@"
|
||||
}
|
||||
|
||||
brightness=$(run_brightness --monitor DP-1)
|
||||
[[ $brightness == "50" ]] || fail "external brightness is converted to a percentage" "actual: $brightness"
|
||||
pass "external brightness is converted to a percentage"
|
||||
|
||||
(( $(grep -c '^ddcutil --skip-ddc-checks detect --brief$' "$call_log") == 1 )) || fail "DDC bus is detected once"
|
||||
run_brightness --monitor DP-1 >/dev/null
|
||||
(( $(grep -c '^ddcutil --skip-ddc-checks detect --brief$' "$call_log") == 1 )) || fail "DDC bus mapping is cached"
|
||||
pass "DDC bus mapping is cached"
|
||||
|
||||
run_brightness --no-osd --monitor DP-1 25%
|
||||
grep -F 'ddcutil --bus 7 --skip-ddc-checks --noverify setvcp 10 20' "$call_log" >/dev/null || \
|
||||
fail "external percentage is converted to the monitor VCP range"
|
||||
pass "external percentage is converted to the monitor VCP range"
|
||||
|
||||
get_count=$(grep -c ' getvcp 10 ' "$call_log")
|
||||
run_brightness --no-osd --monitor DP-1 30%
|
||||
(( $(grep -c ' getvcp 10 ' "$call_log") == get_count )) || \
|
||||
fail "absolute external brightness reuses the cached VCP range"
|
||||
grep -F 'ddcutil --bus 7 --skip-ddc-checks --noverify setvcp 10 24' "$call_log" >/dev/null || \
|
||||
fail "absolute external brightness skips write verification"
|
||||
pass "absolute external brightness reuses the cached VCP range"
|
||||
|
||||
brightness=$(run_brightness --monitor eDP-1)
|
||||
[[ $brightness == "40" ]] || fail "internal monitor uses the kernel backlight" "actual: $brightness"
|
||||
grep -F 'brightnessctl -d mock_backlight -m' "$call_log" >/dev/null || \
|
||||
fail "internal monitor queries brightnessctl"
|
||||
pass "internal monitor uses the kernel backlight"
|
||||
|
||||
brightness=$(FOCUSED_MONITOR=DP-1 run_brightness)
|
||||
[[ $brightness == "50" ]] || fail "brightness follows the focused external monitor" "actual: $brightness"
|
||||
pass "brightness follows the focused external monitor"
|
||||
|
||||
detect_count=$(grep -c ' detect --brief' "$call_log")
|
||||
if DDC_CONNECTOR=DP-1 run_brightness --monitor DP-2 >/dev/null 2>&1; then
|
||||
fail "unsupported external monitor has no brightness backend"
|
||||
fi
|
||||
if DDC_CONNECTOR=DP-1 run_brightness --monitor DP-2 >/dev/null 2>&1; then
|
||||
fail "cached unsupported external monitor has no brightness backend"
|
||||
fi
|
||||
(( $(grep -c ' detect --brief' "$call_log") == detect_count + 1 )) || \
|
||||
fail "unsupported external monitor detection is temporarily cached"
|
||||
pass "unsupported external monitor has no brightness backend"
|
||||
|
||||
rm -f "$runtime_dir/omarchy-brightness-display-ddc/DP-1.bus"
|
||||
detect_count=$(grep -c ' detect --brief' "$call_log")
|
||||
if DDC_READ_FAIL=1 run_brightness --monitor DP-1 >/dev/null 2>&1; then
|
||||
fail "transient DDC read failure is reported"
|
||||
fi
|
||||
(( $(grep -c ' detect --brief' "$call_log") == detect_count + 1 )) || \
|
||||
fail "transient DDC read failure is not retried immediately"
|
||||
brightness=$(run_brightness --monitor DP-1)
|
||||
[[ $brightness == "50" ]] || fail "transient DDC read failure is retried on the next invocation" "actual: $brightness"
|
||||
(( $(grep -c ' detect --brief' "$call_log") == detect_count + 2 )) || \
|
||||
fail "transient DDC read failure does not create a negative cache entry"
|
||||
pass "transient DDC read failure is retried on the next invocation"
|
||||
|
||||
printf '7 80 0\n' >"$runtime_dir/omarchy-brightness-display-ddc/DP-1.bus"
|
||||
get_count=$(grep -c ' getvcp 10 ' "$call_log")
|
||||
DDC_MAXIMUM=100 run_brightness --no-osd --monitor DP-1 50%
|
||||
(( $(grep -c ' getvcp 10 ' "$call_log") == get_count + 1 )) || \
|
||||
fail "expired external brightness range is refreshed"
|
||||
grep -F 'ddcutil --bus 7 --skip-ddc-checks --noverify setvcp 10 50' "$call_log" >/dev/null || \
|
||||
fail "expired external brightness range uses the refreshed maximum"
|
||||
pass "expired external brightness range is refreshed"
|
||||
|
||||
rm -f "$runtime_dir/omarchy-brightness-display-ddc/DP-1.bus"
|
||||
DDC_CURRENT=4 DDC_MAXIMUM=100 run_brightness --no-osd --monitor DP-1 +5%
|
||||
grep -F 'ddcutil --bus 7 --skip-ddc-checks --noverify setvcp 10 5' "$call_log" >/dev/null || \
|
||||
fail "external low brightness writes the one-percent target"
|
||||
pass "external low brightness uses a one-percent step"
|
||||
|
||||
cat >"$mock_bin/hyprctl" <<'SH'
|
||||
#!/bin/bash
|
||||
printf '%s\n' '[
|
||||
{"name":"DP-1","focused":true,"make":"HPN","model":"OMEN X 25f"},
|
||||
{"name":"DP-2","focused":false,"make":"Apple Computer Inc","model":"StudioDisplay"}
|
||||
]'
|
||||
SH
|
||||
chmod +x "$mock_bin/hyprctl"
|
||||
|
||||
PATH="$mock_bin:$PATH" "$ROOT/bin/omarchy-hyprland-monitor-focused-apple" DP-2 || \
|
||||
fail "named Apple display is detected independently of focus"
|
||||
if PATH="$mock_bin:$PATH" "$ROOT/bin/omarchy-hyprland-monitor-focused-apple"; then
|
||||
fail "focused non-Apple display is not detected as Apple"
|
||||
fi
|
||||
pass "named Apple display is detected independently of focus"
|
||||
Reference in New Issue
Block a user