ZacharyZhang-NY/omarchycn
2
2
Fork 0
Code Issues Pull Requests 2 Actions Packages Projects Releases 3 Wiki Activity

Align MAX_SNAPSHOT_ENTRIES with Snapper retention (off-by-one) (#6175)

Browse Source 
* Align MAX_SNAPSHOT_ENTRIES with Snapper retention

Snapper is configured with NUMBER_LIMIT="5", but limine-snapper-sync
also counts the freshly-created / currently-booted snapshot, so five
retained snapshots are reported as six entries and it warns on every
snapshot and update:

  Snapshot limit mismatch: 6 Snapper snapshots exceed configured
  MAX_SNAPSHOT_ENTRIES=5

Raise MAX_SNAPSHOT_ENTRIES to 6 (NUMBER_LIMIT + 1) so the boot-menu cap
and Snapper's retention agree and the off-by-one warning stops. (An
alternative is MAX_SNAPSHOT_ENTRIES=auto, which derives the cap from
Snapper directly; kept an explicit value here to preserve the existing
boot-menu limit.)

Co-Authored-By: Claude <noreply@anthropic.com>

* Clarify Limine snapshot limit

---------

Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: David Heinemeier Hansson <david@hey.com>
This commit is contained in:
Mateus Pegorim
2026-07-18 18:40:11 -07:00
committed by GitHub
co-authored by Claude David Heinemeier Hansson
parent 58e13cd079
commit cb989615f0
2 changed files with 9 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
etc/limine-entry-tool.d/omarchy-defaults.conf
+6 -1
View File
@@ -10,6 +10,11 @@ FIND_BOOTLOADERS=yes
BOOT_ORDER="*, *fallback, Snapshots" BOOT_ORDER="*, *fallback, Snapshots"
MAX_SNAPSHOT_ENTRIES=5 # Snapper is configured with NUMBER_LIMIT="5" (see default/snapper/root), but
# limine-snapper-sync can see the newly created sixth snapshot before cleanup
# restores the retained snapshot count to 5. Allow for that creation window:
# Snapshot limit mismatch: 6 Snapper snapshots exceed configured
# MAX_SNAPSHOT_ENTRIES=5
MAX_SNAPSHOT_ENTRIES=6
SNAPSHOT_FORMAT_CHOICE=5 SNAPSHOT_FORMAT_CHOICE=5
test/shell.d/snapper-test.sh
+3 -1
View File
@@ -5,13 +5,15 @@ set -euo pipefail
source "$(cd -- "$(dirname -- "${BASH_SOURCE[0]}")" && pwd)/base-test.sh" source "$(cd -- "$(dirname -- "${BASH_SOURCE[0]}")" && pwd)/base-test.sh"
template="$ROOT/default/snapper/root" template="$ROOT/default/snapper/root"
limine_defaults="$ROOT/etc/limine-entry-tool.d/omarchy-defaults.conf"
limine_notify_autostart="$ROOT/config/autostart/limine-snapper-notify.desktop" limine_notify_autostart="$ROOT/config/autostart/limine-snapper-notify.desktop"
grep -Fx 'NUMBER_CLEANUP="yes"' "$template" >/dev/null grep -Fx 'NUMBER_CLEANUP="yes"' "$template" >/dev/null
grep -Fx 'NUMBER_LIMIT="5"' "$template" >/dev/null grep -Fx 'NUMBER_LIMIT="5"' "$template" >/dev/null
grep -Fx 'TIMELINE_CREATE="no"' "$template" >/dev/null grep -Fx 'TIMELINE_CREATE="no"' "$template" >/dev/null
! grep -Eq '^TIMELINE_(CLEANUP|LIMIT_)' "$template" || fail "Snapper template keeps timeline cleanup details out of the default config" ! grep -Eq '^TIMELINE_(CLEANUP|LIMIT_)' "$template" || fail "Snapper template keeps timeline cleanup details out of the default config"
pass "Snapper template keeps update snapshots and disables timeline snapshots" grep -Fx 'MAX_SNAPSHOT_ENTRIES=6' "$limine_defaults" >/dev/null || fail "Limine allows for a snapshot created before Snapper cleanup"
pass "Snapper and Limine retain update snapshots without a transient limit mismatch"
grep -Fx '[Desktop Entry]' "$limine_notify_autostart" >/dev/null grep -Fx '[Desktop Entry]' "$limine_notify_autostart" >/dev/null
grep -Fx 'Hidden=true' "$limine_notify_autostart" >/dev/null grep -Fx 'Hidden=true' "$limine_notify_autostart" >/dev/null