install: split and harden hardware config scripts

install/config/hardware/apple/fix-spi-keyboard.sh

@@ -4,9 +4,12 @@ if [[ $product_name =~ MacBook[89],1|MacBook1[02],1|MacBookPro13,[123]|MacBookPr
   echo "Detected MacBook with SPI keyboard"
 
   omarchy-pkg-add macbook12-spi-driver-dkms
+  mkdir -p /etc/mkinitcpio.conf.d
   if [[ $product_name == "MacBook8,1" ]]; then
-    echo "MODULES=(applespi spi_pxa2xx_platform spi_pxa2xx_pci)" | sudo tee /etc/mkinitcpio.conf.d/macbook_spi_modules.conf >/dev/null
+    echo "MODULES=(applespi spi_pxa2xx_platform spi_pxa2xx_pci)" > \
+      /etc/mkinitcpio.conf.d/macbook_spi_modules.conf
   else
-    echo "MODULES=(applespi intel_lpss_pci spi_pxa2xx_platform)" | sudo tee /etc/mkinitcpio.conf.d/macbook_spi_modules.conf >/dev/null
+    echo "MODULES=(applespi intel_lpss_pci spi_pxa2xx_platform)" > \
+      /etc/mkinitcpio.conf.d/macbook_spi_modules.conf
   fi
 fi

install/config/hardware/apple/fix-suspend-nvme.sh

@@ -10,7 +10,8 @@ if [[ $MACBOOK_MODEL =~ MacBook(8,1|9,1|10,1)|MacBookPro13,[123]|MacBookPro14,[1
   if [[ -f $NVME_DEVICE ]]; then
     echo "Applying NVMe suspend fix..."
 
-    cat <<EOF | sudo tee /etc/systemd/system/omarchy-nvme-suspend-fix.service >/dev/null
+    mkdir -p /etc/systemd/system
+    cat > /etc/systemd/system/omarchy-nvme-suspend-fix.service <<'EOF'
 [Unit]
 Description=Omarchy NVMe Suspend Fix for MacBook
 
@@ -21,8 +22,7 @@ ExecStart=/bin/bash -c 'echo 0 > /sys/bus/pci/devices/0000\:01\:00.0/d3cold_allo
 WantedBy=multi-user.target
 EOF
 
-    chrootable_systemctl_enable omarchy-nvme-suspend-fix.service
-    sudo systemctl daemon-reload
+    systemctl enable omarchy-nvme-suspend-fix.service
   else
     echo "Warning: NVMe device not found at expected PCI address (0000:01:00.0)"
     echo "This fix may not be needed for this MacBook model"

install/config/hardware/apple/fix-t2.sh

@@ -12,29 +12,35 @@ if lspci -nn | grep -q "106b:180[12]"; then
     tiny-dfr
 
   # Add user to video group (required for tiny-dfr to access /dev/dri devices)
-  sudo usermod -aG video ${USER}
+  usermod -aG video "${OMARCHY_INSTALL_USER:-${USER:-}}"
 
   # Enable T2 services
-  sudo systemctl enable t2fanrd.service
-  sudo systemctl enable tiny-dfr.service
+  systemctl enable t2fanrd.service
+  systemctl enable tiny-dfr.service
 
-  echo "apple-bce" | sudo tee /etc/modules-load.d/t2.conf >/dev/null
-  echo "hci_bcm4377" | sudo tee -a /etc/modules-load.d/t2.conf >/dev/null
+  mkdir -p /etc/modules-load.d
+  {
+    echo "apple-bce"
+    echo "hci_bcm4377"
+  } > /etc/modules-load.d/t2.conf
 
-  echo "MODULES+=(apple-bce usbhid hid_apple hid_generic xhci_pci xhci_hcd)" | sudo tee /etc/mkinitcpio.conf.d/apple-t2.conf >/dev/null
+  mkdir -p /etc/mkinitcpio.conf.d
+  echo "MODULES+=(apple-bce usbhid hid_apple hid_generic xhci_pci xhci_hcd)" > \
+    /etc/mkinitcpio.conf.d/apple-t2.conf
 
-  cat <<EOF | sudo tee /etc/modprobe.d/brcmfmac.conf >/dev/null
+  mkdir -p /etc/modprobe.d
+  cat > /etc/modprobe.d/brcmfmac.conf <<'EOF'
 # Fix for T2 MacBook WiFi connectivity issues
 options brcmfmac feature_disable=0x82000
 EOF
 
-  sudo mkdir -p /etc/limine-entry-tool.d
-  cat <<EOF | sudo tee /etc/limine-entry-tool.d/t2-mac.conf >/dev/null
+  mkdir -p /etc/limine-entry-tool.d
+  cat > /etc/limine-entry-tool.d/t2-mac.conf <<'EOF'
 # Generated by Omarchy installer for T2 Mac support
 KERNEL_CMDLINE[default]+=" intel_iommu=on iommu=pt pcie_ports=compat"
 EOF
 
-  cat <<EOF | sudo tee /etc/t2fand.conf >/dev/null
+  cat > /etc/t2fand.conf <<'EOF'
 [Fan1]
 low_temp=55
 high_temp=75