Run argv click actions through a login shell as positional params

Quickshell.execDetached(argv) ran the click target with only the shell
process's stripped environment, so GUI actions like the screenshot editor
(tensaku-edit) — resolved on the login-shell PATH the old `bash -lc` string
exec provided — stopped launching on click.

Run the argv through `bash -lc 'exec "$@"'` instead: the script text is a
constant and the arguments are passed as positional parameters, which bash
expands without re-tokenizing or re-evaluating, so injection safety is intact
while PATH and session env match the old behavior exactly.
This commit is contained in:
Ryan Hughes
2026-08-23 12:25:48 -04:00
parent 07443f3970
commit d2fd2e11c6
4 changed files with 27 additions and 16 deletions
+10 -5
View File
@@ -54,12 +54,17 @@ QtObject {
Quickshell.execDetached(["bash", "-lc", command])
}
// Run an argv vector directly, without a shell. Nothing in the array is
// reparsed, so an argument carrying attacker-controlled data (a filename, a
// title) can never turn into a command. Prefer this over execDetached for any
// command assembled from untrusted input.
// Run an argv vector safely: the script text is the constant `exec "$@"`, so
// the arguments only ever land in bash's positional parameters, which it
// expands without re-tokenizing or re-evaluating — a value carrying
// attacker-controlled data ($(id), a filename, a title) stays one literal
// argument and can never turn into a command. The login shell (-l) is what
// makes this a drop-in for execDetached: click actions launch GUI apps
// (tensaku, mpv, xdg-open) that need the same PATH and session environment the
// login shell set up. Prefer this over execDetached for any command assembled
// from untrusted input.
function execArgv(argv) {
Quickshell.execDetached(argv)
Quickshell.execDetached(["bash", "-lc", 'exec "$@"', "bash"].concat(argv))
}
function isPlainObject(value) {