Fix large clipboard history pastes
Clipboard history selections passed the full selected text as a process argument to omarchy-clipboard-paste-text. Large entries can exceed Linux's per-argument exec limit, so the helper never starts reliably for big copied blocks. Pass the original history index instead and have the helper read that entry from clipboard-history.json before wl-copy and Shift+Insert. Also focus the first row when opening the manager, keep filtered rows mapped to their original history indexes, and drop whitespace-only text entries.
This commit is contained in:
@@ -29,6 +29,8 @@ assertDeepEqual(
|
||||
'clipboard history parser drops invalid entries'
|
||||
)
|
||||
|
||||
assertDeepEqual(clipboard.parseHistory(JSON.stringify([' ', '\n', { type: 'text', text: '\t' }])), [], 'clipboard history parser drops whitespace-only text')
|
||||
|
||||
const history = [
|
||||
{ type: 'text', text: 'old' },
|
||||
{ type: 'text', text: 'new' },
|
||||
@@ -51,6 +53,12 @@ assertDeepEqual(
|
||||
'clipboard display rows search image metadata'
|
||||
)
|
||||
|
||||
assertDeepEqual(
|
||||
clipboard.displayRows(history, 'image', 50).map(row => row.index),
|
||||
[2],
|
||||
'clipboard display rows preserve original history indexes'
|
||||
)
|
||||
|
||||
assertDeepEqual(
|
||||
clipboard.displayRows([{ type: 'text', text: 'line one\nline two' }], '', 50)[0].previewText,
|
||||
'line one line two',
|
||||
@@ -60,3 +68,31 @@ assertDeepEqual(
|
||||
assertDeepEqual(clipboard.displayRows(history, '', 0), [], 'clipboard display rows supports zero result limit')
|
||||
assertDeepEqual(clipboard.addEntry(history, 'next', 0), [], 'clipboard addEntry supports zero history limit')
|
||||
JS
|
||||
|
||||
TMPDIR=$(mktemp -d)
|
||||
trap 'rm -rf "$TMPDIR"' EXIT
|
||||
|
||||
mkdir -p "$TMPDIR/bin" "$TMPDIR/home/.local/state/omarchy"
|
||||
|
||||
cat >"$TMPDIR/bin/wl-copy" <<'SH'
|
||||
#!/bin/bash
|
||||
cat >"$WL_COPY_OUT"
|
||||
SH
|
||||
|
||||
cat >"$TMPDIR/bin/wtype" <<'SH'
|
||||
#!/bin/bash
|
||||
printf '%s\n' "$*" >"$WTYPE_OUT"
|
||||
SH
|
||||
|
||||
chmod +x "$TMPDIR/bin/wl-copy" "$TMPDIR/bin/wtype"
|
||||
|
||||
jq -n --arg text "$(printf 'large block line 1\nlarge block line 2\n')" '[{type:"text", text:"ignored"}, {type:"text", text:$text}]' >"$TMPDIR/home/.local/state/omarchy/clipboard-history.json"
|
||||
|
||||
WL_COPY_OUT="$TMPDIR/copied" WTYPE_OUT="$TMPDIR/wtype" HOME="$TMPDIR/home" PATH="$TMPDIR/bin:$PATH" \
|
||||
"$ROOT/bin/omarchy-clipboard-paste-text" --shift-insert --history-index 1
|
||||
|
||||
[[ $(<"$TMPDIR/copied") == "$(printf 'large block line 1\nlarge block line 2')" ]] || fail "clipboard paste helper copies history entry text"
|
||||
pass "clipboard paste helper copies history entry text"
|
||||
|
||||
[[ $(<"$TMPDIR/wtype") == "-M shift -k Insert -m shift" ]] || fail "clipboard paste helper pastes history entries with shift insert"
|
||||
pass "clipboard paste helper pastes history entries with shift insert"
|
||||
|
||||
Reference in New Issue
Block a user