ZacharyZhang-NY/omarchycn
2
3
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases 5 Wiki Activity

Tighten compact status icon spacing

Browse Source
This commit is contained in:
David Heinemeier Hansson
2026-07-17 16:17:49 -07:00
parent 8211b86ac6
commit f8fec7cccf
7 changed files with 14 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/shell.d/bar-icon-geometry-test.sh
+7
View File
@@ -90,6 +90,11 @@ ShellRoot {
fail("indicator groups do not retain compact internal spacing")
return
}
if (compactStatusIcon.implicitWidth !== Style.bar.statusSlot
|| compactVerticalStatusIcon.implicitHeight !== Style.bar.statusSlot) {
fail("compact status icons do not use the shared status slot")
return
}
console.log("RESULT pass")
Qt.quit()
})
@@ -133,6 +138,8 @@ ShellRoot {
iconComponent: Component { Rectangle { width: 12; height: 12 } }
}
BarIconButton { id: verticalIcon; bar: verticalBar; text: "\uf021" }
BarIconButton { id: compactStatusIcon; bar: testBar; text: "\uf021"; slotSize: Style.bar.statusSlot }
BarIconButton { id: compactVerticalStatusIcon; bar: verticalBar; text: "\uf021"; slotSize: Style.bar.statusSlot }
Row {
id: horizontalIndicatorPair
BarIndicator { id: horizontalIndicator; bar: testBar; active: true; activeText: "󰅶" }
test/shell.d/fixtures/bar-widget-contract/shell.qml
+1 -1
View File
@@ -180,7 +180,7 @@ ShellRoot {
if (verticalId === "omarchy.clock")
root.assertEqual(verticalItem.implicitHeight, Style.bar.iconSlot * 3, verticalId + " uses one slot per line")
else if (verticalId === "omarchy.weather" || verticalId === "omarchy.system-update")
root.assertEqual(verticalItem.implicitHeight, Style.bar.iconSlot, verticalId + " uses one vertical slot")
root.assertEqual(verticalItem.implicitHeight, Style.bar.statusSlot, verticalId + " uses one compact status slot")
if (verticalItem && typeof verticalItem.destroy === "function") verticalItem.destroy()
}
root.assertTrue(root.createdIds.length === entries.length, "all bar widgets instantiate")