From ff4e92e63bdd7c6666e9b94e6ec67d27e368b7e9 Mon Sep 17 00:00:00 2001 From: David Heinemeier Hansson Date: Sat, 15 Aug 2026 17:04:04 +0200 Subject: [PATCH] Fix Clone Plugin failing with "unknown clone option" (#6942) omarchy-plugin-clone only takes the source id as the first argument, but the menu passed --edit ahead of it, so the id fell through to the unknown-option branch and every clone from Setup > Plugins failed. Closes #6913 Co-authored-by: Claude Opus 5 --- bin/omarchy-menu-plugin | 2 +- test/shell.d/menu-plugin-test.sh | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/bin/omarchy-menu-plugin b/bin/omarchy-menu-plugin index 9a876674..35ce5a36 100755 --- a/bin/omarchy-menu-plugin +++ b/bin/omarchy-menu-plugin @@ -38,7 +38,7 @@ id=$(cut -f2 <<<"$selection") if [[ $1 == "clone" ]]; then omarchy-launch-floating-terminal-with-presentation \ - "omarchy-plugin-clone --edit $(printf '%q' "$id")" + "omarchy-plugin-clone $(printf '%q' "$id") --edit" elif [[ $1 == "remove" ]]; then omarchy-launch-floating-terminal-with-presentation "omarchy-plugin-remove $(printf '%q' "$id")" else diff --git a/test/shell.d/menu-plugin-test.sh b/test/shell.d/menu-plugin-test.sh index ee8e491a..d29403cb 100755 --- a/test/shell.d/menu-plugin-test.sh +++ b/test/shell.d/menu-plugin-test.sh @@ -111,7 +111,7 @@ pick clone "$(printf 'Clock\tomarchy.clock')" [[ $ROWS == *"Clock"* && $ROWS != *"Weather"* ]] || fail "clone picker offers only built-in plugins" "$ROWS" pass "clone picker offers built-in plugins" -[[ $CALLS == *"terminal: omarchy-plugin-clone --edit omarchy.clock"* ]] || +[[ $CALLS == *"terminal: omarchy-plugin-clone omarchy.clock --edit"* ]] || fail "clone picker delegates cloning and editing to the clone command" "$CALLS" pass "clone picker clones and opens the personal plugin"