7633d8dee4
* Keep the bar mapped while hidden so revealing it is instant Hiding the bar set the panel invisible, which unmaps the layer surface and releases the scene graph with it. Every reveal then had to rebuild all of it: a new layer surface, a configure roundtrip, re-shaped glyphs and re-uploaded textures, and a first frame before anything appeared. Measured on a 2560x1440 screen, showing took 155-175ms against 20ms to hide, and 400-595ms on the first reveal after a cold start. Splitting the cost showed the exclusive-zone reflow was not to blame: show latency was the same on an empty workspace as on a tiled one, and windows finished moving ~15ms after the bar was already on screen. Park the bar one bar-width past its anchored edge instead, and drop its exclusion zone while hidden. The surface stays alive, so showing is only a margin change: 10-14ms in both directions, at every bar position. Since a hidden bar is now mapped, layer_present no longer proves the bar is visible; the session acceptance test asserts on-screen geometry. * Fix layer visibility checks on offset monitors * Handle rotated outputs in layer visibility checks * Cover hidden bar behavior in acceptance tests --------- Co-authored-by: David Heinemeier Hansson <david@hey.com>
78 lines
2.6 KiB
Bash
78 lines
2.6 KiB
Bash
#!/bin/bash
|
|
|
|
set -euo pipefail
|
|
|
|
source "$(cd -- "$(dirname -- "${BASH_SOURCE[0]}")" && pwd)/base-test.sh"
|
|
|
|
# The compositor reports at least one monitor
|
|
monitors=$(hyprctl -j monitors | jq 'length')
|
|
(( monitors >= 1 )) || fail "compositor reports a monitor"
|
|
pass "compositor reports a monitor"
|
|
|
|
# The Omarchy shell is running and responsive
|
|
wait_until "omarchy-shell responds to ping" 60 omarchy-shell shell ping
|
|
|
|
# Core shell plugins are loaded
|
|
plugins=$(omarchy-shell shell listPlugins)
|
|
for plugin in \
|
|
omarchy.audio omarchy.background omarchy.bar omarchy.bluetooth \
|
|
omarchy.clipboard omarchy.emojis omarchy.menu \
|
|
omarchy.monitor omarchy.network omarchy.notifications omarchy.power \
|
|
omarchy.reminders omarchy.weather; do
|
|
[[ $plugins == *"$plugin"* ]] || fail "shell plugin is loaded: $plugin" "loaded plugins: $plugins"
|
|
pass "shell plugin is loaded: $plugin"
|
|
done
|
|
|
|
# The bar and background are actually on screen
|
|
wait_until "bar layer is on screen" 30 layer_on_screen "omarchy-bar"
|
|
wait_until "background layer is on screen" 30 layer_on_screen "omarchy-background"
|
|
|
|
# Hiding parks the bar off-screen without unmapping its layer surface, and
|
|
# revealing brings that same surface back on-screen.
|
|
restore_bar_visibility() {
|
|
omarchy-toggle-bar off >/dev/null 2>&1 || true
|
|
}
|
|
trap restore_bar_visibility EXIT
|
|
|
|
omarchy-toggle-bar on
|
|
wait_until "hidden bar layer stays mapped" 15 layer_present "omarchy-bar"
|
|
wait_until "hidden bar layer parks off screen" 15 layer_off_screen "omarchy-bar"
|
|
screenshot "success-bar-hidden"
|
|
|
|
omarchy-toggle-bar off
|
|
wait_until "revealed bar layer returns on screen" 15 layer_on_screen "omarchy-bar"
|
|
screenshot "success-bar-revealed"
|
|
trap - EXIT
|
|
|
|
# Audio stack is up
|
|
wait_until "pipewire is running" 30 wpctl status
|
|
|
|
# Root filesystem is btrfs as installed
|
|
[[ $(findmnt -no FSTYPE /) == "btrfs" ]] || fail "root filesystem is btrfs"
|
|
pass "root filesystem is btrfs"
|
|
|
|
# Omarchy reports its version
|
|
omarchy-version >/dev/null || fail "omarchy-version works"
|
|
pass "omarchy-version works"
|
|
|
|
# No failed units, system or user. OMARCHY_ACCEPTANCE_IGNORE_UNITS can hold a
|
|
# regex of units to overlook (useful on dev machines; a fresh VM should be clean).
|
|
failed_units() {
|
|
systemctl "$@" --failed --no-legend --plain | awk '{print $1}' |
|
|
grep -Ev "${OMARCHY_ACCEPTANCE_IGNORE_UNITS:-^$}" || true
|
|
}
|
|
|
|
failed_system=$(failed_units --system)
|
|
if [[ -n $failed_system ]]; then
|
|
fail "no failed system units" "failed units: $failed_system"
|
|
fi
|
|
pass "no failed system units"
|
|
|
|
failed_user=$(failed_units --user)
|
|
if [[ -n $failed_user ]]; then
|
|
fail "no failed user units" "failed units: $failed_user"
|
|
fi
|
|
pass "no failed user units"
|
|
|
|
screenshot "success-desktop"
|