a79d1dc8da
* Add Wi-Fi QR sharing to network panel * Refine Wi-Fi QR sharing * Use QR glyph for Wi-Fi sharing * Add click-to-reveal password to the Wi-Fi share card Scanning the QR is the fast path, but the person typing on a laptop needs the actual password. A dimmed "Show password" hint under the QR toggles the secret in place. The password stays out of the shell until asked for: a click runs the new omarchy-network-password helper (a private pipe, never an argument), and closing the card drops it again. Open and enterprise networks never show the control. The card loses its Close button -- Escape and clicking outside already cover it -- and now sizes itself to its content. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * Keep a dismissed Wi-Fi share card closed and make Escape reliable Closing the card mid-generation killed the helper, but its buffered stdout still arrived and repopulated the matrix, reopening the card the user just closed. Both collectors now honor qrExpectedStop, and the flag survives onExited because exit and stream-finished have no guaranteed order. The password fetch gets the same treatment so a reveal in flight during dismissal can't stash the secret into a closed card's state. The content's focus was claimed while the window was still unmapped, so Escape could land nowhere. Re-acquire it after mapping, the way KeyboardPanel does. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * Share WEP networks correctly and restore the QR quiet zone NetworkManager models WEP as key-mgmt "none" plus a wep-key, so the QR helper encoded WEP networks as open -- a QR that scans fine and then silently fails to join. Encode them as T:WEP and let the password helper print the key. Also widen qrencode's margin from 2 to the spec's 4-module quiet zone; the card surround is dark, so that white border is all a scanner gets. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Co-authored-by: David Heinemeier Hansson <david@hey.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
56 lines
1.8 KiB
Bash
56 lines
1.8 KiB
Bash
#!/bin/bash
|
|
|
|
set -euo pipefail
|
|
|
|
source "$(cd -- "$(dirname -- "${BASH_SOURCE[0]}")" && pwd)/base-test.sh"
|
|
|
|
tmp=$(mktemp -d)
|
|
trap 'rm -rf "$tmp"' EXIT
|
|
mkdir -p "$tmp/bin"
|
|
|
|
cat >"$tmp/bin/nmcli" <<'EOF'
|
|
#!/bin/bash
|
|
if [[ $* == *GENERAL.CON-UUID* ]]; then
|
|
echo test-uuid
|
|
else
|
|
printf '%s' "$PW_NMCLI_FIELDS"
|
|
fi
|
|
EOF
|
|
chmod +x "$tmp/bin/nmcli"
|
|
|
|
run_failure_case() {
|
|
local description=$1 fields=$2 expected_error=$3
|
|
local error
|
|
|
|
export PW_NMCLI_FIELDS=$fields
|
|
if PATH="$tmp/bin:$PATH" "$ROOT/bin/omarchy-network-password" wlan0 >"$tmp/output" 2>"$tmp/error"; then
|
|
fail "$description" "helper unexpectedly succeeded"
|
|
fi
|
|
error=$(<"$tmp/error")
|
|
[[ $error == "$expected_error" ]] || fail "$description" "expected: $expected_error\nactual: $error"
|
|
pass "$description"
|
|
}
|
|
|
|
# The password comes back raw -- no QR escaping -- because it is shown to a
|
|
# human, not embedded in a WIFI: payload.
|
|
export PW_NMCLI_FIELDS=$'wpa-psk\np,a:ss;word\\42\n'
|
|
output=$(PATH="$tmp/bin:$PATH" "$ROOT/bin/omarchy-network-password" wlan0)
|
|
[[ $output == 'p,a:ss;word\42' ]] || fail "network password helper prints the raw password" "expected: p,a:ss;word\\42\nactual: $output"
|
|
pass "network password helper prints the raw password"
|
|
|
|
run_failure_case \
|
|
"network password helper refuses open networks" \
|
|
$'none\n\n' \
|
|
"This network has no password"
|
|
|
|
# WEP looks like an open network (key-mgmt "none") but carries a wep-key.
|
|
export PW_NMCLI_FIELDS=$'none\n\nwep-secret\n'
|
|
output=$(PATH="$tmp/bin:$PATH" "$ROOT/bin/omarchy-network-password" wlan0)
|
|
[[ $output == "wep-secret" ]] || fail "network password helper prints WEP keys" "expected: wep-secret\nactual: $output"
|
|
pass "network password helper prints WEP keys"
|
|
|
|
run_failure_case \
|
|
"network password helper refuses enterprise networks" \
|
|
$'wpa-eap\nsecret\n' \
|
|
"Enterprise Wi-Fi has no shareable password"
|