Audit keyboard, focus, veils, motion and clocks across all 500

A cross-cutting pass, each fix with a test that failed first.

Veils: MyGo still hands a key to a base that turned off this frame,
so every element key now goes through pixel.Shortcut, which an
archtest enforces. Input handlers record and the build applies them
only while enabled; the editor turns away a veil-frame letter or
copy; value bases get a copy and keep only enabled turns. Popups
give a held focus back to their opener when the veil lifts.

Motion: S5 is enforced at the clock. Every Tick, Since, Step,
Toward and Shot runs at 4-15 fps; blinks keep 1 Hz on 4 fps steps,
fast animations step at 15, and drawn time is quantized to frames.

Clocks stepping back: Since holds at zero without overflow, and
k.Elapsed moves a stored start to now, so nothing goes negative,
runs backward or indexes out of range.

Also: logs count typed text instead of holding it, gallery names
use glyphs the font has, removable rows are keyed, components take
their own Options (archtest), and sweeps over all 508 demos check
veiled keys, clicks, wheels, the clock stepping back and names.
This commit is contained in:
ZacharyZhang-NY committed 2026-10-12 16:03:04 -04:00
1 parent 81003b21ee
commit b4b4d67b92
198 files changed
+2708 -422

No files matched your search

+44
View File
@@ -0,0 +1,44 @@
package media_test
import (
"fmt"
"strings"
"testing"
"time"
"github.com/egoist/mygo/ui"
"git.zacharyzhang.com/ZacharyZhang-NY/8bitMyGoUI/media"
)
func TestMediaClocksHoldWhenTheClockStepsBack(t *testing.T) {
wd := newWorld()
var r media.StepSequencerResult
tt := view(400, 300, wd, func(c *ui.Context) {
r = media.StepSequencer(c, "Sequence", []string{"Kick"}, [][16]bool{{}}, media.StepSequencerOptions{Playing: true})
})
wd.clk.t = wd.clk.t.Add(-200 * time.Millisecond)
tt.Frame()
if r.Step < 0 {
t.Errorf("the playhead sits at step %d", r.Step)
}
rec := true
tt = view(400, 300, wd, func(c *ui.Context) { media.RecordButton(c, "Record", &rec, media.RecordButtonOptions{}) })
wd.clk.t = wd.clk.t.Add(-1200 * time.Millisecond)
tt.Frame()
if strings.Contains(strings.Join(tt.Texts(), " "), "-") {
t.Errorf("a negative take: %q", tt.Texts())
}
}
func TestStepSequencerTempoStaysUnderS5(t *testing.T) {
defer func() {
if r := fmt.Sprint(recover()); !strings.HasPrefix(r, "media: StepSequencer Tempo") {
t.Fatalf("Tempo 300 gave %q", r)
}
}()
// 225 BPM is fifteen steps a second; 300 is twenty.
view(400, 300, newWorld(), func(c *ui.Context) {
media.StepSequencer(c, "Seq", []string{"Kick"}, [][16]bool{{}}, media.StepSequencerOptions{Tempo: 300})
})
}
+2 -1
View File
@@ -80,7 +80,8 @@ func turned(c *ui.Context, k pixel.Kit, e *ui.Element, playing bool, fps int) in
on := playing && !k.Reduce()
if on {
n := k.Tick(c, fps)
if !s.playing {
// A clock stepping back rebases, so the count never falls.
if !s.playing || n-s.from < s.held {
s.from = n - s.held
}
s.held = n - s.from
+3 -1
View File
@@ -4,6 +4,8 @@ import (
"fmt"
"github.com/egoist/mygo/ui"
"git.zacharyzhang.com/ZacharyZhang-NY/8bitMyGoUI/pixel"
)
// keyboard plays C4–C5: A–K white, WETYU black.
@@ -26,7 +28,7 @@ func note(semi int) string {
func played(e *ui.Element) []int {
var out []int
for semi, kb := range keyboard {
if e.Shortcut(0, kb.key) {
if pixel.Shortcut(e, 0, kb.key) {
out = append(out, semi)
}
}
+3 -3
View File
@@ -59,13 +59,13 @@ func RecordButton(c *ui.Context, text string, rec *bool, o RecordButtonOptions)
case *rec && tk.since.IsZero():
tk.since, tk.took = now, 0
case !*rec && !tk.since.IsZero():
tk.since, tk.took = time.Time{}, now.Sub(tk.since)
tk.since, tk.took = time.Time{}, k.Elapsed(&tk.since)
}
took, dot := tk.took, recDot
if *rec {
took = now.Sub(tk.since)
took = k.Elapsed(&tk.since)
k.At(c, tk.since.Add(took.Truncate(time.Second)+time.Second))
if !k.Reduce() && k.Tick(c, 2)%2 == 1 {
if !k.Reduce() && k.Tick(c, 4)%4 >= 2 {
dot = recOff
}
}
+6 -2
View File
@@ -11,7 +11,7 @@ import (
)
type StepSequencerOptions struct {
// Tempo is BPM, four steps a beat; zero means 120.
// Tempo is 1–225 BPM, four steps a beat; zero: 120.
Tempo int
Playing bool
Disabled bool
@@ -42,6 +42,10 @@ func StepSequencer(c *ui.Context, text string, tracks []string, steps [][16]bool
panic(fmt.Sprintf("media: StepSequencer has %d tracks and %d rows", len(tracks), len(steps)))
}
tempo := pixel.Or("StepSequencer Tempo", o.Tempo, 120)
// S5 caps the playhead at fifteen steps a second.
if tempo > 225 {
panic(fmt.Sprintf("media: StepSequencer Tempo %d over 225", tempo))
}
res := StepSequencerResult{Step: -1}
labels := 0
for _, t := range tracks {
@@ -59,7 +63,7 @@ func StepSequencer(c *ui.Context, text string, tracks []string, steps [][16]bool
// The playhead is the music; Reduce Motion keeps it.
if o.Playing {
per := time.Minute / time.Duration(4*tempo)
n := int(k.Now().Sub(sq.since) / per)
n := int(k.Elapsed(&sq.since) / per)
res.Step = n % 16
k.At(c, sq.since.Add(time.Duration(n+1)*per))
}
+1 -1
View File
@@ -49,7 +49,7 @@ func Tracker(c *ui.Context, text string, rows []Row, cur *int, o TrackerOptions)
slog.Debug("8bit: tracker", "label", text, "row", *cur, "note", rows[*cur].Note)
*cur = min(len(rows)-1, *cur+1)
}
if base.Shortcut(0, ui.KeyDelete) || base.Shortcut(0, ui.KeyBackspace) {
if pixel.Shortcut(base, 0, ui.KeyDelete) || pixel.Shortcut(base, 0, ui.KeyBackspace) {
rows[*cur], res.Changed = Row{}, true
slog.Debug("8bit: tracker", "label", text, "row", *cur, "note", "")
}