chore(meetings): log skipped invalid action items; use requireParam for meetingId (P2-42, P3-48)

This commit is contained in:
ZacharyZhang-NY committed 2026-04-16 23:08:06 -04:00
1 parent c7fbec8194
commit 1adfea55b0
1 file changed
+6 -7
+6 -7
View File
@@ -1,6 +1,7 @@
import log from "electron-log/main.js";
import { z } from "zod";
import { validateTaskCreation } from "../task-quality-gates";
import type { AgentApiServer } from "./server-core";
import { requireParam, type AgentApiServer } from "./server-core";
export function registerMeetingRoutes(server: AgentApiServer) {
const db = server.db;
@@ -66,11 +67,7 @@ export function registerMeetingRoutes(server: AgentApiServer) {
});
server.addRoute("PATCH", "/api/meetings/:meetingId", (_req, res, params, token, body) => {
const meetingId = params.meetingId;
if (!meetingId) {
server.json(res, 400, { error: "Missing meetingId" });
return;
}
const meetingId = requireParam(params, "meetingId");
const existing = db.getMeeting(meetingId, token.companyId);
if (!existing) {
server.json(res, 404, { error: "Meeting not found" });
@@ -130,7 +127,9 @@ export function registerMeetingRoutes(server: AgentApiServer) {
false,
);
if (!meetingTaskValidation.valid) {
// Log but skip invalid meeting action items rather than failing the whole request
log.warn(
`[meetings] Skipped invalid action item from meeting ${existing.id}: ${meetingTaskValidation.errors.join("; ")}`,
);
continue;
}
db.saveTask({