Q154: decision notes belong to one request and reset on close or switch
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
1 parent
af831abd53
commit
ec183ec60e
2 files changed
+7
No files matched your search
@@ -141,7 +141,9 @@ export function ApprovalsPage({ snapshot, actions, navigate, focus }: PageProps)
|
||||
</>
|
||||
)}
|
||||
|
||||
{/* Keyed by request, so notes typed for one never carry to another or survive closing. */}
|
||||
<ApprovalDetailDialog
|
||||
key={editing?.id ?? "none"}
|
||||
approval={editing}
|
||||
requester={editing ? resolveRequester(editing, employees, agents) : ""}
|
||||
onClose={() => setEditingId(null)}
|
||||
|
||||
@@ -112,6 +112,11 @@ test("the pinned CEO conversation is the Messages front door", async () => {
|
||||
await page.getByRole("button", { name: "Review" }).first().click();
|
||||
const review = page.getByRole("dialog", { name: "Raise the ads budget" });
|
||||
await expect(review.getByRole("textbox", { name: "Decision notes" })).toBeVisible();
|
||||
// Notes belong to one request: closing or switching never carries them to the next.
|
||||
await review.getByRole("textbox", { name: "Decision notes" }).fill("Only for the ads budget.");
|
||||
await review.getByRole("button", { name: "Close" }).click();
|
||||
await page.getByRole("button", { name: "Review" }).first().click();
|
||||
await expect(review.getByRole("textbox", { name: "Decision notes" })).toHaveValue("");
|
||||
await review.getByRole("button", { name: "Close" }).click();
|
||||
await page.getByRole("button", { name: "Work" }).click();
|
||||
await page.getByRole("button", { name: /Operationalize goal: Ship the FlowPilot MVP\./ }).first().click();
|
||||
|
||||
Reference in new issue
Block a user