ZacharyZhang-NY
e74dafcd36
Three independently ugly bugs that all fed the same log flood:
* Electron's `WebFrameMain.send` writes every "Render frame was disposed"
to stderr via `console.error`. When the worker fans a second
agent-event past a reloading renderer, we produced thousands of
identical lines and stalled the main loop on stderr I/O. Added a
`mainFrame.detached` guard so the send is short-circuited before
Electron's own catch block fires, and installed a targeted filter in
`suppress-warnings.ts` (now actually imported from the entry point)
so the specific `console.error("Error sending from webFrameMain:"…)`
noise never reaches the terminal. Any other payload still surfaces.
* `dispatchAgentMessage` accepted the human-reader sentinel as a wake
target when an agent replied to `__board__` — `wakeAgentIfPossible`
then called `db.getAgent("__board__")`, threw, and the dispatcher
kept repeating on every send. Strip `HUMAN_SENDER_ID` at
`resolveMessageWakeTargets`, and keep a defense-in-depth guard in the
heartbeat so a stray caller (future automation fan-out) cannot
reintroduce the crash.
* Pi's skills loader rejects any SKILL.md whose frontmatter `name`
diverges from its parent directory. The four bundled `my-writing-style`
copies declared `name: writing-style-skill`, so every install emitted
a warning and dropped the skill. They also lived as orphan gitlinks
(mode 160000 without .gitmodules), and the global `*.md` gitignore
hid every other SKILL.md from version control. Fixed the frontmatter
to match the dir, converted the dangling submodules to plain trees,
and allowlisted `builtin-skills/**/*.md` so a fresh clone carries the
catalogue instead of silently losing it.
64 lines
1.9 KiB
Markdown
64 lines
1.9 KiB
Markdown
---
|
|
title: Use DTOs for Data Transfer
|
|
impact: MEDIUM
|
|
impactDescription: prevents sensitive data exposure at boundaries
|
|
tags: obj, dto, transfer, boundary
|
|
---
|
|
|
|
## Use DTOs for Data Transfer
|
|
|
|
Data Transfer Objects (DTOs) are pure data structures for transferring data between layers or systems. They should have no behavior beyond accessors. Use them at system boundaries.
|
|
|
|
**Incorrect (domain object used for transfer):**
|
|
|
|
```java
|
|
// Domain object with behavior used for API response
|
|
public class User {
|
|
private String name;
|
|
private String hashedPassword;
|
|
private CreditCard creditCard;
|
|
|
|
public void authenticate(String password) { /* ... */ }
|
|
public void chargeCard(Money amount) { /* ... */ }
|
|
|
|
// Serialized directly - exposes sensitive data and internal structure
|
|
}
|
|
```
|
|
|
|
**Correct (separate DTO for transfer):**
|
|
|
|
```java
|
|
// Domain object with behavior (internal)
|
|
public class User {
|
|
private String name;
|
|
private HashedPassword password;
|
|
private CreditCard creditCard;
|
|
|
|
public void authenticate(String password) { /* ... */ }
|
|
public void chargeCard(Money amount) { /* ... */ }
|
|
|
|
public UserDTO toDTO() {
|
|
return new UserDTO(name, creditCard.getMaskedNumber());
|
|
}
|
|
}
|
|
|
|
// DTO for API response (external)
|
|
public record UserDTO(String name, String maskedCardNumber) {}
|
|
|
|
// Active Record variant - DTO with persistence methods only
|
|
public class UserRecord {
|
|
public String name;
|
|
public String email;
|
|
|
|
public void save() { /* SQL insert/update */ }
|
|
public static UserRecord findById(Long id) { /* SQL select */ }
|
|
}
|
|
```
|
|
|
|
**Use DTOs when:**
|
|
- Transferring data across system boundaries (API, database, message queue)
|
|
- Hiding internal structure from external consumers
|
|
- Transforming data format between layers
|
|
|
|
Reference: [Clean Code, Chapter 6: Objects and Data Structures](https://www.oreilly.com/library/view/clean-code-a/9780136083238/)
|