A DM addressed to one agent that @-mentions another was silently dropping the second agent out of the conversation: * `dispatchAgentMessage` added the mentioned agent to the wake set, so CEO's heartbeat fired — but * `listAgentInboxUnread` only surfaced messages where the current agent was `to_agent_id` or sat in a matching channel/project/ department. Mentions were invisible, so CEO's next turn saw nothing new and returned silently. From the operator's chair this looked exactly like "CEO ignored me; 张工程师 answered instead". * `findMentionedAgentIds` had a latent bug on top: its unique-alias filter used `ids.length === 1`, but a single agent whose name matched its role registered itself twice, tripped the filter, and every `@CEO` in a scaffold with role === name was a no-op. Once inbox visibility was fixed the bug became load-bearing. Root-cause fixes: * New migration v48 adds `agent_message_mentions(message_id, agent_id, company_id, created_at)` so mention fan-out is a first-class join. * `sendAgentMessage` now takes the resolved mention set and writes the row + mentions in a single transaction — a crash between the two writes can no longer leave a message visible to the recipient but invisible to the mentioned agent. * `dispatchAgentMessage` computes the mention set exactly once via `resolveMentionedAgentIds` and hands the same list to both the DB write and `resolveMessageWakeTargets`, so persistence and wake stay in lockstep. * `listAgentInboxUnread` and `listAgentMessages` gain an `id IN (select message_id from agent_message_mentions …)` clause so the mentioned agent's inbox actually contains the message that woke it. * `findMentionedAgentIds` now stores per-alias agent IDs in a `Set` and filters on `ids.size === 1`, dropping the self-duplication bug while preserving the "refuse ambiguous aliases" semantics. * Company teardown drops `agent_message_mentions` alongside the existing `agent_message_reads` cleanup so deletes stay clean. Tests pin the new behaviour: a DM with a `@CEO` mention reaches CEO's inbox and both agents get woken, while a DM whose recipient is `__board__` never attempts to wake the human sentinel.
317 lines
9.2 KiB
TypeScript
317 lines
9.2 KiB
TypeScript
import { mkdtemp, rm } from "node:fs/promises";
|
|
import { join } from "node:path";
|
|
import { tmpdir } from "node:os";
|
|
import { afterEach, describe, expect, it, vi } from "vitest";
|
|
import { AppDatabase } from "../../src/main/database";
|
|
import { createThreadIntegration } from "../../src/main/thread-integration";
|
|
import { dispatchAgentMessage, HUMAN_SENDER_ID } from "../../src/main/message-dispatch";
|
|
|
|
const tempDirs: string[] = [];
|
|
|
|
async function createTempDir(prefix: string) {
|
|
const dir = await mkdtemp(join(tmpdir(), prefix));
|
|
tempDirs.push(dir);
|
|
return dir;
|
|
}
|
|
|
|
afterEach(async () => {
|
|
await Promise.all(tempDirs.splice(0).map((dir) => rm(dir, { recursive: true, force: true })));
|
|
});
|
|
|
|
function createScaffold(db: AppDatabase) {
|
|
db.updateConnectorHealth({
|
|
id: "openai-codex",
|
|
status: "ready",
|
|
authState: "authenticated",
|
|
version: "test",
|
|
lastError: null,
|
|
});
|
|
|
|
const companyId = db.saveCompany({
|
|
name: "Message Dispatch Co",
|
|
description: "Tests board wake and wait-state resolution",
|
|
status: "active",
|
|
executionMode: "ai_cofounder",
|
|
});
|
|
const workspaceId = db.saveWorkspace({
|
|
companyId,
|
|
name: "Primary",
|
|
localPath: "/tmp/message-dispatch",
|
|
repoUrl: "",
|
|
repoRef: "",
|
|
isPrimary: true,
|
|
});
|
|
const ceoId = db.saveAgent({
|
|
companyId,
|
|
name: "CEO",
|
|
role: "CEO",
|
|
title: "Chief Executive Officer",
|
|
status: "idle",
|
|
reportsTo: null,
|
|
connectorId: "openai-codex",
|
|
workspaceId,
|
|
model: null,
|
|
capabilities: "Lead the company",
|
|
budgetMonthlyUsd: 250,
|
|
});
|
|
const ctoId = db.saveAgent({
|
|
companyId,
|
|
name: "CTO",
|
|
role: "CTO",
|
|
title: "Chief Technology Officer",
|
|
status: "idle",
|
|
reportsTo: ceoId,
|
|
connectorId: "openai-codex",
|
|
workspaceId,
|
|
model: null,
|
|
capabilities: "Lead engineering",
|
|
budgetMonthlyUsd: 200,
|
|
department: "engineering",
|
|
});
|
|
const cmoId = db.saveAgent({
|
|
companyId,
|
|
name: "CMO",
|
|
role: "CMO",
|
|
title: "Chief Marketing Officer",
|
|
status: "idle",
|
|
reportsTo: ceoId,
|
|
connectorId: "openai-codex",
|
|
workspaceId,
|
|
model: null,
|
|
capabilities: "Lead marketing",
|
|
budgetMonthlyUsd: 200,
|
|
department: "marketing",
|
|
});
|
|
const pendingId = db.saveAgent({
|
|
companyId,
|
|
name: "Pending Recruit",
|
|
role: "IC",
|
|
title: "Pending Hire",
|
|
status: "pending_approval",
|
|
reportsTo: ctoId,
|
|
connectorId: "openai-codex",
|
|
workspaceId,
|
|
model: null,
|
|
capabilities: "Pending",
|
|
budgetMonthlyUsd: 100,
|
|
department: "engineering",
|
|
});
|
|
const terminatedId = db.saveAgent({
|
|
companyId,
|
|
name: "Former COO",
|
|
role: "COO",
|
|
title: "Former COO",
|
|
status: "terminated",
|
|
reportsTo: ceoId,
|
|
connectorId: "openai-codex",
|
|
workspaceId,
|
|
model: null,
|
|
capabilities: "No longer active",
|
|
budgetMonthlyUsd: 100,
|
|
department: "operations",
|
|
});
|
|
|
|
const taskId = db.saveTask({
|
|
companyId,
|
|
title: "Review architecture plan",
|
|
description: "Need board feedback in the thread.",
|
|
assigneeAgentId: ctoId,
|
|
workspaceId,
|
|
priority: "high",
|
|
status: "todo",
|
|
});
|
|
|
|
return { companyId, workspaceId, ceoId, ctoId, cmoId, pendingId, terminatedId, taskId };
|
|
}
|
|
|
|
describe("message dispatch", () => {
|
|
it("wakes every active agent for company channel broadcasts (Slack-style all-hands)", async () => {
|
|
const profileDir = await createTempDir("agentcompany-message-dispatch-");
|
|
const db = new AppDatabase(profileDir);
|
|
db.init();
|
|
|
|
const { companyId, ceoId, ctoId, cmoId } = createScaffold(db);
|
|
const wakeAgentIfPossible = vi.fn().mockReturnValue(null);
|
|
|
|
const companyResult = dispatchAgentMessage({
|
|
db,
|
|
wakeAgentIfPossible,
|
|
}, {
|
|
companyId,
|
|
fromAgentId: HUMAN_SENDER_ID,
|
|
fromHumanUser: true,
|
|
channel: "company",
|
|
body: "All-hands broadcast",
|
|
});
|
|
|
|
expect(companyResult.ok).toBe(true);
|
|
if (!companyResult.ok) throw new Error("Expected company message dispatch to succeed.");
|
|
expect(new Set(companyResult.data.wakeTargets)).toEqual(new Set([ceoId, ctoId, cmoId]));
|
|
|
|
const incidentResult = dispatchAgentMessage({
|
|
db,
|
|
wakeAgentIfPossible,
|
|
}, {
|
|
companyId,
|
|
fromAgentId: HUMAN_SENDER_ID,
|
|
fromHumanUser: true,
|
|
channel: "incident",
|
|
body: "Urgent issue",
|
|
});
|
|
|
|
expect(incidentResult.ok).toBe(true);
|
|
if (!incidentResult.ok) throw new Error("Expected incident message dispatch to succeed.");
|
|
expect(new Set(incidentResult.data.wakeTargets)).toEqual(new Set([ceoId, ctoId, cmoId]));
|
|
|
|
db.close();
|
|
});
|
|
|
|
it("routes a DM addressed to one agent into the @mentioned agent's inbox (group-chat @mention visibility)", async () => {
|
|
const profileDir = await createTempDir("agentcompany-message-mention-");
|
|
const db = new AppDatabase(profileDir);
|
|
db.init();
|
|
|
|
const { companyId, ceoId, ctoId } = createScaffold(db);
|
|
const wakeAgentIfPossible = vi.fn().mockReturnValue(null);
|
|
|
|
const result = dispatchAgentMessage({
|
|
db,
|
|
wakeAgentIfPossible,
|
|
}, {
|
|
companyId,
|
|
fromAgentId: HUMAN_SENDER_ID,
|
|
fromHumanUser: true,
|
|
channel: "direct",
|
|
toAgentId: ctoId,
|
|
subject: "status",
|
|
body: "Hi @CEO, please share a progress update, @CTO is on infra.",
|
|
});
|
|
|
|
expect(result.ok).toBe(true);
|
|
if (!result.ok) throw new Error("Expected dispatch to succeed.");
|
|
expect(new Set(result.data.wakeTargets)).toEqual(new Set([ceoId, ctoId]));
|
|
|
|
const ceoInbox = db.listAgentInboxUnread(companyId, ceoId);
|
|
expect(ceoInbox.map((entry) => entry.id)).toContain(result.data.id);
|
|
const ctoInbox = db.listAgentInboxUnread(companyId, ctoId);
|
|
expect(ctoInbox.map((entry) => entry.id)).toContain(result.data.id);
|
|
|
|
db.close();
|
|
});
|
|
|
|
it("keeps __board__ out of wake targets even when the recipient is the human reader", async () => {
|
|
const profileDir = await createTempDir("agentcompany-message-board-wake-");
|
|
const db = new AppDatabase(profileDir);
|
|
db.init();
|
|
|
|
const { companyId, ceoId } = createScaffold(db);
|
|
const wakeAgentIfPossible = vi.fn().mockReturnValue(null);
|
|
|
|
const result = dispatchAgentMessage({
|
|
db,
|
|
wakeAgentIfPossible,
|
|
}, {
|
|
companyId,
|
|
fromAgentId: ceoId,
|
|
channel: "direct",
|
|
toAgentId: HUMAN_SENDER_ID,
|
|
subject: "report",
|
|
body: "Update ready for review.",
|
|
});
|
|
|
|
expect(result.ok).toBe(true);
|
|
if (!result.ok) throw new Error("Expected dispatch to succeed.");
|
|
expect(result.data.wakeTargets).not.toContain(HUMAN_SENDER_ID);
|
|
expect(wakeAgentIfPossible).not.toHaveBeenCalledWith(
|
|
HUMAN_SENDER_ID,
|
|
expect.anything(),
|
|
expect.anything(),
|
|
);
|
|
|
|
db.close();
|
|
});
|
|
|
|
it("resolves only user_reply wait states for company-wide human messages, but scoped replies resolve thread wait states", async () => {
|
|
const profileDir = await createTempDir("agentcompany-message-wait-");
|
|
const db = new AppDatabase(profileDir);
|
|
db.init();
|
|
|
|
const { companyId, ctoId, taskId } = createScaffold(db);
|
|
const threadIntegration = createThreadIntegration({
|
|
db,
|
|
logger: { info: () => {}, warn: () => {}, error: () => {} },
|
|
});
|
|
|
|
threadIntegration.onTaskCreated(taskId, companyId);
|
|
const thread = db.listThreads({
|
|
companyId,
|
|
type: "task",
|
|
relatedEntityType: "task",
|
|
relatedEntityId: taskId,
|
|
limit: 1,
|
|
})[0];
|
|
|
|
if (!thread) {
|
|
throw new Error("Expected task thread to exist.");
|
|
}
|
|
|
|
const replyWait = db.setThreadWaitState({
|
|
threadId: thread.id,
|
|
companyId,
|
|
waitingFor: "user_reply",
|
|
relatedApprovalId: null,
|
|
reason: "Reply needed",
|
|
});
|
|
const reviewWait = db.setThreadWaitState({
|
|
threadId: thread.id,
|
|
companyId,
|
|
waitingFor: "user_review",
|
|
relatedApprovalId: null,
|
|
reason: "Review needed",
|
|
});
|
|
const approvalWait = db.setThreadWaitState({
|
|
threadId: thread.id,
|
|
companyId,
|
|
waitingFor: "user_approval",
|
|
relatedApprovalId: "approval-1",
|
|
reason: "Approval needed",
|
|
});
|
|
|
|
dispatchAgentMessage({
|
|
db,
|
|
onHumanMessage: (currentCompanyId, toAgentId, threadId, waitStateId) =>
|
|
threadIntegration.onHumanMessage(currentCompanyId, toAgentId, threadId, waitStateId),
|
|
}, {
|
|
companyId,
|
|
fromAgentId: HUMAN_SENDER_ID,
|
|
fromHumanUser: true,
|
|
channel: "company",
|
|
body: "Board-wide update",
|
|
});
|
|
|
|
let unresolved = db.listThreadWaitStates(companyId);
|
|
expect(unresolved.some((entry) => entry.id === replyWait.id)).toBe(false);
|
|
expect(unresolved.some((entry) => entry.id === reviewWait.id)).toBe(true);
|
|
|
|
dispatchAgentMessage({
|
|
db,
|
|
onHumanMessage: (currentCompanyId, toAgentId, threadId, waitStateId) =>
|
|
threadIntegration.onHumanMessage(currentCompanyId, toAgentId, threadId, waitStateId),
|
|
}, {
|
|
companyId,
|
|
fromAgentId: HUMAN_SENDER_ID,
|
|
fromHumanUser: true,
|
|
channel: "direct",
|
|
toAgentId: ctoId,
|
|
threadId: thread.id,
|
|
body: "Specific reply for the thread",
|
|
});
|
|
|
|
unresolved = db.listThreadWaitStates(companyId);
|
|
expect(unresolved.some((entry) => entry.id === reviewWait.id)).toBe(false);
|
|
expect(unresolved.some((entry) => entry.id === approvalWait.id)).toBe(true);
|
|
|
|
db.close();
|
|
});
|
|
});
|