ZacharyZhang-NY
e74dafcd36
Three independently ugly bugs that all fed the same log flood:
* Electron's `WebFrameMain.send` writes every "Render frame was disposed"
to stderr via `console.error`. When the worker fans a second
agent-event past a reloading renderer, we produced thousands of
identical lines and stalled the main loop on stderr I/O. Added a
`mainFrame.detached` guard so the send is short-circuited before
Electron's own catch block fires, and installed a targeted filter in
`suppress-warnings.ts` (now actually imported from the entry point)
so the specific `console.error("Error sending from webFrameMain:"…)`
noise never reaches the terminal. Any other payload still surfaces.
* `dispatchAgentMessage` accepted the human-reader sentinel as a wake
target when an agent replied to `__board__` — `wakeAgentIfPossible`
then called `db.getAgent("__board__")`, threw, and the dispatcher
kept repeating on every send. Strip `HUMAN_SENDER_ID` at
`resolveMessageWakeTargets`, and keep a defense-in-depth guard in the
heartbeat so a stray caller (future automation fan-out) cannot
reintroduce the crash.
* Pi's skills loader rejects any SKILL.md whose frontmatter `name`
diverges from its parent directory. The four bundled `my-writing-style`
copies declared `name: writing-style-skill`, so every install emitted
a warning and dropped the skill. They also lived as orphan gitlinks
(mode 160000 without .gitmodules), and the global `*.md` gitignore
hid every other SKILL.md from version control. Fixed the frontmatter
to match the dir, converted the dangling submodules to plain trees,
and allowlisted `builtin-skills/**/*.md` so a fresh clone carries the
catalogue instead of silently losing it.
75 lines
2.4 KiB
Markdown
75 lines
2.4 KiB
Markdown
---
|
|
title: Separate Construction from Use
|
|
impact: MEDIUM
|
|
impactDescription: enables testing and reduces coupling
|
|
tags: class, construction, factories, separation
|
|
---
|
|
|
|
## Separate Construction from Use
|
|
|
|
The startup process of object construction is a separate concern from runtime logic. Applications should separate the main function (which builds objects) from the rest of the system (which uses them).
|
|
|
|
**Incorrect (construction mixed with use):**
|
|
|
|
```java
|
|
public class OrderProcessor {
|
|
public void processOrder(Order order) {
|
|
// Construction buried in business logic
|
|
EmailService emailService = new SmtpEmailService(
|
|
"smtp.example.com", 587, "user", "password");
|
|
InventoryService inventory = new InventoryServiceImpl(
|
|
new PostgresConnection("localhost", 5432));
|
|
PaymentGateway gateway = new StripeGateway(API_KEY);
|
|
|
|
// Business logic
|
|
inventory.reserve(order.getItems());
|
|
gateway.charge(order.getPayment());
|
|
emailService.sendConfirmation(order);
|
|
}
|
|
}
|
|
```
|
|
|
|
**Correct (construction separated from use):**
|
|
|
|
```java
|
|
// Main builds the object graph
|
|
public class Application {
|
|
public static void main(String[] args) {
|
|
EmailService emailService = new SmtpEmailService(
|
|
Config.get("smtp.host"), Config.getInt("smtp.port"));
|
|
InventoryService inventory = new InventoryServiceImpl(
|
|
new PostgresConnection(Config.get("db.url")));
|
|
PaymentGateway gateway = new StripeGateway(Config.get("stripe.key"));
|
|
|
|
OrderProcessor processor = new OrderProcessor(
|
|
emailService, inventory, gateway);
|
|
|
|
processor.start();
|
|
}
|
|
}
|
|
|
|
// Business class receives dependencies
|
|
public class OrderProcessor {
|
|
private final EmailService emailService;
|
|
private final InventoryService inventory;
|
|
private final PaymentGateway gateway;
|
|
|
|
public OrderProcessor(EmailService email, InventoryService inv,
|
|
PaymentGateway pay) {
|
|
this.emailService = email;
|
|
this.inventory = inv;
|
|
this.gateway = pay;
|
|
}
|
|
|
|
public void processOrder(Order order) {
|
|
inventory.reserve(order.getItems());
|
|
gateway.charge(order.getPayment());
|
|
emailService.sendConfirmation(order);
|
|
}
|
|
}
|
|
```
|
|
|
|
**Alternative:** Use Dependency Injection frameworks (Spring, Guice) to manage construction.
|
|
|
|
Reference: [Clean Code, Chapter 11: Systems](https://www.oreilly.com/library/view/clean-code-a/9780136083238/)
|