ZacharyZhang-NY
5e9b7acbc6
Rewrite ~525 call sites from `db.<method>()` to `db.<module>.<method>()` for tasks and agents domains (including `getAgent`/`findAgent`/`getTask` which live on the `entityCrud` field). Delete the corresponding pass-through methods on AppDatabaseBase. Structural types that narrowed `db` to a bag of flat methods (CapabilityMatchDb, EscalationDeps, SweepStaleReviewsDeps) are reshaped to match the new namespace. Internal callback references inside database.ts/database-base.ts now invoke the owning module directly (e.g. `this.agents.saveAgent`) rather than the deleted pass-through. The codemod lives at scripts/codemod/remove-appdatabase-passthrough.mjs and filters by owning module + optional explicit method list. It is idempotent and does not re-rewrite already-namespaced calls.
66 lines
2.3 KiB
TypeScript
66 lines
2.3 KiB
TypeScript
/**
|
|
* Step 1: CEO role detection fix.
|
|
* Physically extracted from autonomous-chain.spec.ts without behavior changes.
|
|
*/
|
|
|
|
import { describe, expect, it } from "vitest";
|
|
import { buildSystemPrompt } from "../../../src/main/prompt-builder/index";
|
|
import { installSharedSetup } from "./shared-setup";
|
|
|
|
const shared = installSharedSetup();
|
|
const { createAgent, buildCtx } = shared;
|
|
|
|
describe("Step 1: CEO role detection", () => {
|
|
it("identifies CEO when chainOfCommand is empty, even with no direct reports", () => {
|
|
const ceoId = createAgent({ name: "CEO", role: "CEO" });
|
|
const ctx = buildCtx({
|
|
agentId: ceoId,
|
|
directReports: [], // no reports yet!
|
|
chainOfCommand: [], // top-level
|
|
});
|
|
|
|
const prompt = buildSystemPrompt(ctx);
|
|
|
|
// CEO should NOT get IC instructions
|
|
expect(prompt).not.toContain("Individual Contributor");
|
|
// CEO should get executive instructions (Phase 0: Team Building)
|
|
expect(prompt).toContain("CEO");
|
|
expect(prompt).toContain("Team Building");
|
|
});
|
|
|
|
it("identifies manager when has reports and has chain of command", () => {
|
|
const ceoId = createAgent({ name: "CEO", role: "CEO" });
|
|
const managerId = createAgent({ name: "CTO", role: "CTO", reportsTo: ceoId });
|
|
const ceo = shared.db.entityCrud.getAgent(ceoId);
|
|
const icId = createAgent({ name: "IC", role: "Engineer", reportsTo: managerId });
|
|
const ic = shared.db.entityCrud.getAgent(icId);
|
|
|
|
const ctx = buildCtx({
|
|
agentId: managerId,
|
|
directReports: [ic],
|
|
chainOfCommand: [ceo], // reports to CEO
|
|
});
|
|
|
|
const prompt = buildSystemPrompt(ctx);
|
|
expect(prompt).toContain("Operating Instructions (Manager)");
|
|
expect(prompt).not.toContain("Individual Contributor");
|
|
expect(prompt).not.toContain("Executive / CEO");
|
|
});
|
|
|
|
it("identifies IC when has chain of command and no direct reports", () => {
|
|
const ceoId = createAgent({ name: "CEO", role: "CEO" });
|
|
const ceo = shared.db.entityCrud.getAgent(ceoId);
|
|
const icId = createAgent({ name: "Dev", role: "Engineer", reportsTo: ceoId });
|
|
|
|
const ctx = buildCtx({
|
|
agentId: icId,
|
|
directReports: [],
|
|
chainOfCommand: [ceo],
|
|
});
|
|
|
|
const prompt = buildSystemPrompt(ctx);
|
|
expect(prompt).toContain("Individual Contributor");
|
|
expect(prompt).not.toContain("Operating Instructions (Manager)");
|
|
});
|
|
});
|