ZacharyZhang-NY
e74dafcd36
Three independently ugly bugs that all fed the same log flood:
* Electron's `WebFrameMain.send` writes every "Render frame was disposed"
to stderr via `console.error`. When the worker fans a second
agent-event past a reloading renderer, we produced thousands of
identical lines and stalled the main loop on stderr I/O. Added a
`mainFrame.detached` guard so the send is short-circuited before
Electron's own catch block fires, and installed a targeted filter in
`suppress-warnings.ts` (now actually imported from the entry point)
so the specific `console.error("Error sending from webFrameMain:"…)`
noise never reaches the terminal. Any other payload still surfaces.
* `dispatchAgentMessage` accepted the human-reader sentinel as a wake
target when an agent replied to `__board__` — `wakeAgentIfPossible`
then called `db.getAgent("__board__")`, threw, and the dispatcher
kept repeating on every send. Strip `HUMAN_SENDER_ID` at
`resolveMessageWakeTargets`, and keep a defense-in-depth guard in the
heartbeat so a stray caller (future automation fan-out) cannot
reintroduce the crash.
* Pi's skills loader rejects any SKILL.md whose frontmatter `name`
diverges from its parent directory. The four bundled `my-writing-style`
copies declared `name: writing-style-skill`, so every install emitted
a warning and dropped the skill. They also lived as orphan gitlinks
(mode 160000 without .gitmodules), and the global `*.md` gitignore
hid every other SKILL.md from version control. Fixed the frontmatter
to match the dir, converted the dangling submodules to plain trees,
and allowlisted `builtin-skills/**/*.md` so a fresh clone carries the
catalogue instead of silently losing it.
31 lines
773 B
Markdown
31 lines
773 B
Markdown
---
|
|
title: Rule Title Here
|
|
impact: MEDIUM
|
|
impactDescription: description of impact (e.g., "eliminates confusion")
|
|
tags: category-prefix, keyword1, keyword2
|
|
---
|
|
|
|
## Rule Title Here
|
|
|
|
Brief explanation of the rule and why it matters. Focus on the principle and its impact on code maintainability and readability.
|
|
|
|
**Incorrect (description of what's wrong):**
|
|
|
|
```java
|
|
// Bad code example here showing the anti-pattern
|
|
// Comment explaining the problem
|
|
```
|
|
|
|
**Correct (description of what's right):**
|
|
|
|
```java
|
|
// Good code example here showing the solution
|
|
// Comment explaining the benefit
|
|
```
|
|
|
|
**When NOT to use this pattern:**
|
|
- Exception case 1
|
|
- Exception case 2
|
|
|
|
Reference: [Clean Code, Chapter N: Topic](https://www.oreilly.com/library/view/clean-code-a/9780136083238/)
|