ZacharyZhang-NY
e74dafcd36
Three independently ugly bugs that all fed the same log flood:
* Electron's `WebFrameMain.send` writes every "Render frame was disposed"
to stderr via `console.error`. When the worker fans a second
agent-event past a reloading renderer, we produced thousands of
identical lines and stalled the main loop on stderr I/O. Added a
`mainFrame.detached` guard so the send is short-circuited before
Electron's own catch block fires, and installed a targeted filter in
`suppress-warnings.ts` (now actually imported from the entry point)
so the specific `console.error("Error sending from webFrameMain:"…)`
noise never reaches the terminal. Any other payload still surfaces.
* `dispatchAgentMessage` accepted the human-reader sentinel as a wake
target when an agent replied to `__board__` — `wakeAgentIfPossible`
then called `db.getAgent("__board__")`, threw, and the dispatcher
kept repeating on every send. Strip `HUMAN_SENDER_ID` at
`resolveMessageWakeTargets`, and keep a defense-in-depth guard in the
heartbeat so a stray caller (future automation fan-out) cannot
reintroduce the crash.
* Pi's skills loader rejects any SKILL.md whose frontmatter `name`
diverges from its parent directory. The four bundled `my-writing-style`
copies declared `name: writing-style-skill`, so every install emitted
a warning and dropped the skill. They also lived as orphan gitlinks
(mode 160000 without .gitmodules), and the global `*.md` gitignore
hid every other SKILL.md from version control. Fixed the frontmatter
to match the dir, converted the dangling submodules to plain trees,
and allowlisted `builtin-skills/**/*.md` so a fresh clone carries the
catalogue instead of silently losing it.
68 lines
1.8 KiB
Markdown
68 lines
1.8 KiB
Markdown
---
|
||
title: Define Exceptions by Caller Needs
|
||
impact: HIGH
|
||
impactDescription: reduces catch blocks by 3-5× per call site
|
||
tags: err, wrapper, classification, design
|
||
---
|
||
|
||
## Define Exceptions by Caller Needs
|
||
|
||
Define exception classes based on how they are caught, not on their source or type. Often a single exception class is sufficient for a particular area of code. Wrap third-party API exceptions.
|
||
|
||
**Incorrect (catching many exception types):**
|
||
|
||
```java
|
||
// Caller must handle many different exceptions
|
||
try {
|
||
port.open();
|
||
} catch (DeviceResponseException e) {
|
||
reportPortError(e);
|
||
logger.log("Device response problem", e);
|
||
} catch (ATM1212UnlockedException e) {
|
||
reportPortError(e);
|
||
logger.log("Unlock exception", e);
|
||
} catch (GMXError e) {
|
||
reportPortError(e);
|
||
logger.log("Device response exception", e);
|
||
} finally {
|
||
// ...
|
||
}
|
||
```
|
||
|
||
**Correct (unified exception handling):**
|
||
|
||
```java
|
||
// Wrapper class translates exceptions
|
||
public class LocalPort {
|
||
private ACMEPort innerPort;
|
||
|
||
public void open() throws PortDeviceFailure {
|
||
try {
|
||
innerPort.open();
|
||
} catch (DeviceResponseException e) {
|
||
throw new PortDeviceFailure(e);
|
||
} catch (ATM1212UnlockedException e) {
|
||
throw new PortDeviceFailure(e);
|
||
} catch (GMXError e) {
|
||
throw new PortDeviceFailure(e);
|
||
}
|
||
}
|
||
}
|
||
|
||
// Clean caller code
|
||
try {
|
||
port.open();
|
||
} catch (PortDeviceFailure e) {
|
||
reportPortError(e);
|
||
logger.log(e.getMessage(), e);
|
||
}
|
||
```
|
||
|
||
**Benefits of wrapping:**
|
||
- Minimizes dependencies on third-party APIs
|
||
- Easier to mock for testing
|
||
- Easier to switch implementations later
|
||
- Single exception type per area simplifies catching
|
||
|
||
Reference: [Clean Code, Chapter 7: Error Handling](https://www.oreilly.com/library/view/clean-code-a/9780136083238/)
|