ZacharyZhang-NY
e74dafcd36
Three independently ugly bugs that all fed the same log flood:
* Electron's `WebFrameMain.send` writes every "Render frame was disposed"
to stderr via `console.error`. When the worker fans a second
agent-event past a reloading renderer, we produced thousands of
identical lines and stalled the main loop on stderr I/O. Added a
`mainFrame.detached` guard so the send is short-circuited before
Electron's own catch block fires, and installed a targeted filter in
`suppress-warnings.ts` (now actually imported from the entry point)
so the specific `console.error("Error sending from webFrameMain:"…)`
noise never reaches the terminal. Any other payload still surfaces.
* `dispatchAgentMessage` accepted the human-reader sentinel as a wake
target when an agent replied to `__board__` — `wakeAgentIfPossible`
then called `db.getAgent("__board__")`, threw, and the dispatcher
kept repeating on every send. Strip `HUMAN_SENDER_ID` at
`resolveMessageWakeTargets`, and keep a defense-in-depth guard in the
heartbeat so a stray caller (future automation fan-out) cannot
reintroduce the crash.
* Pi's skills loader rejects any SKILL.md whose frontmatter `name`
diverges from its parent directory. The four bundled `my-writing-style`
copies declared `name: writing-style-skill`, so every install emitted
a warning and dropped the skill. They also lived as orphan gitlinks
(mode 160000 without .gitmodules), and the global `*.md` gitignore
hid every other SKILL.md from version control. Fixed the frontmatter
to match the dir, converted the dangling submodules to plain trees,
and allowlisted `builtin-skills/**/*.md` so a fresh clone carries the
catalogue instead of silently losing it.
63 lines
2.1 KiB
Markdown
63 lines
2.1 KiB
Markdown
---
|
|
title: Group Classes That Change Together
|
|
impact: HIGH
|
|
impactDescription: localizes change impact, reduces deployment risk
|
|
tags: comp, common-closure, cohesion, change
|
|
---
|
|
|
|
## Group Classes That Change Together
|
|
|
|
Classes that change for the same reasons and at the same times should be in the same component. This is the Common Closure Principle (CCP) - the Single Responsibility Principle for components.
|
|
|
|
**Incorrect (classes that change together are separated):**
|
|
|
|
```text
|
|
src/
|
|
├── entities/
|
|
│ └── Invoice.ts # Changes when billing rules change
|
|
├── repositories/
|
|
│ └── InvoiceRepository.ts # Changes when billing rules change
|
|
├── services/
|
|
│ └── InvoiceService.ts # Changes when billing rules change
|
|
├── validators/
|
|
│ └── InvoiceValidator.ts # Changes when billing rules change
|
|
└── mappers/
|
|
└── InvoiceMapper.ts # Changes when billing rules change
|
|
|
|
# A billing rule change touches 5 directories
|
|
# Risk of forgetting one, inconsistent changes
|
|
```
|
|
|
|
**Correct (classes that change together are grouped):**
|
|
|
|
```text
|
|
src/
|
|
├── billing/
|
|
│ ├── domain/
|
|
│ │ ├── Invoice.ts
|
|
│ │ ├── InvoiceLine.ts
|
|
│ │ ├── InvoiceRules.ts
|
|
│ │ └── InvoiceValidator.ts
|
|
│ ├── application/
|
|
│ │ ├── CreateInvoiceUseCase.ts
|
|
│ │ └── ports/
|
|
│ │ └── InvoiceRepository.ts
|
|
│ └── infrastructure/
|
|
│ ├── PostgresInvoiceRepository.ts
|
|
│ └── InvoiceMapper.ts
|
|
├── payments/
|
|
│ └── ... # Changes for different reasons
|
|
└── shipping/
|
|
└── ... # Changes for different reasons
|
|
|
|
# Billing rule change isolated to billing/
|
|
# Single PR, single review, single deployment
|
|
```
|
|
|
|
**How to identify change reasons:**
|
|
- "When X business rule changes, which classes change?"
|
|
- "When the Y team requests a feature, which code changes?"
|
|
- Group by actor/stakeholder, not by technical layer
|
|
|
|
Reference: [Clean Architecture - Common Closure Principle](https://www.oreilly.com/library/view/clean-architecture-a/9780134494272/ch13.xhtml)
|