ZacharyZhang-NY
e74dafcd36
Three independently ugly bugs that all fed the same log flood:
* Electron's `WebFrameMain.send` writes every "Render frame was disposed"
to stderr via `console.error`. When the worker fans a second
agent-event past a reloading renderer, we produced thousands of
identical lines and stalled the main loop on stderr I/O. Added a
`mainFrame.detached` guard so the send is short-circuited before
Electron's own catch block fires, and installed a targeted filter in
`suppress-warnings.ts` (now actually imported from the entry point)
so the specific `console.error("Error sending from webFrameMain:"…)`
noise never reaches the terminal. Any other payload still surfaces.
* `dispatchAgentMessage` accepted the human-reader sentinel as a wake
target when an agent replied to `__board__` — `wakeAgentIfPossible`
then called `db.getAgent("__board__")`, threw, and the dispatcher
kept repeating on every send. Strip `HUMAN_SENDER_ID` at
`resolveMessageWakeTargets`, and keep a defense-in-depth guard in the
heartbeat so a stray caller (future automation fan-out) cannot
reintroduce the crash.
* Pi's skills loader rejects any SKILL.md whose frontmatter `name`
diverges from its parent directory. The four bundled `my-writing-style`
copies declared `name: writing-style-skill`, so every install emitted
a warning and dropped the skill. They also lived as orphan gitlinks
(mode 160000 without .gitmodules), and the global `*.md` gitignore
hid every other SKILL.md from version control. Fixed the frontmatter
to match the dir, converted the dangling submodules to plain trees,
and allowlisted `builtin-skills/**/*.md` so a fresh clone carries the
catalogue instead of silently losing it.
62 lines
1.9 KiB
Markdown
62 lines
1.9 KiB
Markdown
---
|
|
title: Use Simple Data Structures Across Boundaries
|
|
impact: CRITICAL
|
|
impactDescription: prevents coupling between layers
|
|
tags: dep, boundaries, dto, data-transfer
|
|
---
|
|
|
|
## Use Simple Data Structures Across Boundaries
|
|
|
|
Data crossing architectural boundaries should be simple, isolated data structures. Never pass entities, database rows, or framework objects across boundaries.
|
|
|
|
**Incorrect (entity crosses boundary):**
|
|
|
|
```python
|
|
# domain/entities/user.py
|
|
class User:
|
|
def __init__(self, id, email, password_hash, created_at):
|
|
self.id = id
|
|
self.email = email
|
|
self.password_hash = password_hash # Sensitive data
|
|
self.created_at = created_at
|
|
|
|
# interface_adapters/controllers/user_controller.py
|
|
class UserController:
|
|
def get_user(self, user_id):
|
|
user = self.use_case.get_user(user_id)
|
|
return jsonify(user.__dict__) # Entity exposed to HTTP layer, leaks password_hash
|
|
```
|
|
|
|
**Correct (DTOs cross boundaries):**
|
|
|
|
```python
|
|
# application/dto/user_response.py
|
|
@dataclass
|
|
class UserResponse:
|
|
id: str
|
|
email: str
|
|
member_since: str # Formatted for presentation
|
|
|
|
# application/usecases/get_user.py
|
|
class GetUserUseCase:
|
|
def execute(self, user_id: str) -> UserResponse:
|
|
user = self.repository.find_by_id(user_id)
|
|
return UserResponse(
|
|
id=user.id,
|
|
email=user.email,
|
|
member_since=user.created_at.strftime("%B %Y")
|
|
)
|
|
|
|
# interface_adapters/controllers/user_controller.py
|
|
class UserController:
|
|
def get_user(self, user_id):
|
|
response = self.use_case.execute(user_id)
|
|
return jsonify(asdict(response)) # Only safe, formatted data
|
|
```
|
|
|
|
**When NOT to use this pattern:**
|
|
- Within the same architectural layer, entities can flow freely
|
|
- Performance-critical paths may need optimized data transfer
|
|
|
|
Reference: [Clean Architecture - Crossing Boundaries](https://blog.cleancoder.com/uncle-bob/2012/08/13/the-clean-architecture.html)
|