ZacharyZhang-NY
e74dafcd36
Three independently ugly bugs that all fed the same log flood:
* Electron's `WebFrameMain.send` writes every "Render frame was disposed"
to stderr via `console.error`. When the worker fans a second
agent-event past a reloading renderer, we produced thousands of
identical lines and stalled the main loop on stderr I/O. Added a
`mainFrame.detached` guard so the send is short-circuited before
Electron's own catch block fires, and installed a targeted filter in
`suppress-warnings.ts` (now actually imported from the entry point)
so the specific `console.error("Error sending from webFrameMain:"…)`
noise never reaches the terminal. Any other payload still surfaces.
* `dispatchAgentMessage` accepted the human-reader sentinel as a wake
target when an agent replied to `__board__` — `wakeAgentIfPossible`
then called `db.getAgent("__board__")`, threw, and the dispatcher
kept repeating on every send. Strip `HUMAN_SENDER_ID` at
`resolveMessageWakeTargets`, and keep a defense-in-depth guard in the
heartbeat so a stray caller (future automation fan-out) cannot
reintroduce the crash.
* Pi's skills loader rejects any SKILL.md whose frontmatter `name`
diverges from its parent directory. The four bundled `my-writing-style`
copies declared `name: writing-style-skill`, so every install emitted
a warning and dropped the skill. They also lived as orphan gitlinks
(mode 160000 without .gitmodules), and the global `*.md` gitignore
hid every other SKILL.md from version control. Fixed the frontmatter
to match the dir, converted the dangling submodules to plain trees,
and allowlisted `builtin-skills/**/*.md` so a fresh clone carries the
catalogue instead of silently losing it.
61 lines
1.9 KiB
Markdown
61 lines
1.9 KiB
Markdown
---
|
|
title: Interfaces Belong to Clients Not Implementers
|
|
impact: CRITICAL
|
|
impactDescription: enables true dependency inversion
|
|
tags: dep, interfaces, dependency-inversion, ownership
|
|
---
|
|
|
|
## Interfaces Belong to Clients Not Implementers
|
|
|
|
Interfaces should be defined in the layer that uses them, not the layer that implements them. The client owns the abstraction; the implementation adapts to it.
|
|
|
|
**Incorrect (interface defined next to implementation):**
|
|
|
|
```java
|
|
// infrastructure/persistence/UserRepository.java
|
|
public interface UserRepository {
|
|
User findById(String id);
|
|
void save(User user);
|
|
}
|
|
|
|
// infrastructure/persistence/PostgresUserRepository.java
|
|
public class PostgresUserRepository implements UserRepository {
|
|
// Implementation
|
|
}
|
|
|
|
// application/usecases/CreateUserUseCase.java
|
|
import infrastructure.persistence.UserRepository; // Use case imports from infrastructure!
|
|
|
|
public class CreateUserUseCase {
|
|
private final UserRepository repository;
|
|
}
|
|
```
|
|
|
|
**Correct (interface defined where it's used):**
|
|
|
|
```java
|
|
// application/ports/output/UserRepository.java
|
|
public interface UserRepository {
|
|
User findById(String id);
|
|
void save(User user);
|
|
}
|
|
|
|
// application/usecases/CreateUserUseCase.java
|
|
import application.ports.output.UserRepository; // Same layer import
|
|
|
|
public class CreateUserUseCase {
|
|
private final UserRepository repository; // No infrastructure dependency
|
|
}
|
|
|
|
// infrastructure/persistence/PostgresUserRepository.java
|
|
import application.ports.output.UserRepository; // Infrastructure depends on application
|
|
|
|
public class PostgresUserRepository implements UserRepository {
|
|
// Implementation adapts to the port
|
|
}
|
|
```
|
|
|
|
**Note:** This is the essence of the Dependency Inversion Principle. The high-level module defines what it needs; low-level modules conform to that contract.
|
|
|
|
Reference: [Clean Architecture - Chapter 11: DIP](https://www.oreilly.com/library/view/clean-architecture-a/9780134494272/ch11.xhtml)
|