ZacharyZhang-NY
e74dafcd36
Three independently ugly bugs that all fed the same log flood:
* Electron's `WebFrameMain.send` writes every "Render frame was disposed"
to stderr via `console.error`. When the worker fans a second
agent-event past a reloading renderer, we produced thousands of
identical lines and stalled the main loop on stderr I/O. Added a
`mainFrame.detached` guard so the send is short-circuited before
Electron's own catch block fires, and installed a targeted filter in
`suppress-warnings.ts` (now actually imported from the entry point)
so the specific `console.error("Error sending from webFrameMain:"…)`
noise never reaches the terminal. Any other payload still surfaces.
* `dispatchAgentMessage` accepted the human-reader sentinel as a wake
target when an agent replied to `__board__` — `wakeAgentIfPossible`
then called `db.getAgent("__board__")`, threw, and the dispatcher
kept repeating on every send. Strip `HUMAN_SENDER_ID` at
`resolveMessageWakeTargets`, and keep a defense-in-depth guard in the
heartbeat so a stray caller (future automation fan-out) cannot
reintroduce the crash.
* Pi's skills loader rejects any SKILL.md whose frontmatter `name`
diverges from its parent directory. The four bundled `my-writing-style`
copies declared `name: writing-style-skill`, so every install emitted
a warning and dropped the skill. They also lived as orphan gitlinks
(mode 160000 without .gitmodules), and the global `*.md` gitignore
hid every other SKILL.md from version control. Fixed the frontmatter
to match the dir, converted the dangling submodules to plain trees,
and allowlisted `builtin-skills/**/*.md` so a fresh clone carries the
catalogue instead of silently losing it.
77 lines
2.1 KiB
Markdown
77 lines
2.1 KiB
Markdown
---
|
||
title: Depend on Stable Abstractions Not Volatile Concretions
|
||
impact: CRITICAL
|
||
impactDescription: reduces change frequency by 5-10×
|
||
tags: dep, stability, abstractions, volatility
|
||
---
|
||
|
||
## Depend on Stable Abstractions Not Volatile Concretions
|
||
|
||
The most flexible systems depend on abstractions, not concretions. Volatile concrete classes are under active development and change frequently; depending on them propagates instability.
|
||
|
||
**Incorrect (depending on volatile concrete class):**
|
||
|
||
```go
|
||
// services/notification.go
|
||
package services
|
||
|
||
import (
|
||
"myapp/infrastructure/email/sendgrid"
|
||
"myapp/infrastructure/sms/twilio"
|
||
)
|
||
|
||
type NotificationService struct {
|
||
email *sendgrid.Client // Concrete SendGrid client
|
||
sms *twilio.Client // Concrete Twilio client
|
||
}
|
||
|
||
func (n *NotificationService) NotifyUser(userID string, message string) {
|
||
// When SendGrid API changes, this service must change
|
||
// When migrating to AWS SES, this service must change
|
||
n.email.SendWithTemplate("notify", message)
|
||
}
|
||
```
|
||
|
||
**Correct (depending on stable interface):**
|
||
|
||
```go
|
||
// domain/ports/notification.go
|
||
package ports
|
||
|
||
type EmailSender interface {
|
||
Send(to string, subject string, body string) error
|
||
}
|
||
|
||
type SMSSender interface {
|
||
Send(to string, message string) error
|
||
}
|
||
|
||
// services/notification.go
|
||
package services
|
||
|
||
import "myapp/domain/ports"
|
||
|
||
type NotificationService struct {
|
||
email ports.EmailSender // Stable abstraction
|
||
sms ports.SMSSender // Stable abstraction
|
||
}
|
||
|
||
func (n *NotificationService) NotifyUser(userID string, message string) {
|
||
// Service is immune to email provider changes
|
||
n.email.Send(userID, "Notification", message)
|
||
}
|
||
|
||
// infrastructure/sendgrid/client.go
|
||
package sendgrid
|
||
|
||
type Client struct { /* ... */ }
|
||
|
||
func (c *Client) Send(to, subject, body string) error {
|
||
// Concrete implementation can change freely
|
||
}
|
||
```
|
||
|
||
**Note:** Depending on stable concretions (like standard library classes) is acceptable. Focus inversion on volatile, actively-developed modules.
|
||
|
||
Reference: [Clean Architecture - Stable Abstractions Principle](https://www.oreilly.com/library/view/clean-architecture-a/9780134494272/ch11.xhtml)
|