ZacharyZhang-NY
e74dafcd36
Three independently ugly bugs that all fed the same log flood:
* Electron's `WebFrameMain.send` writes every "Render frame was disposed"
to stderr via `console.error`. When the worker fans a second
agent-event past a reloading renderer, we produced thousands of
identical lines and stalled the main loop on stderr I/O. Added a
`mainFrame.detached` guard so the send is short-circuited before
Electron's own catch block fires, and installed a targeted filter in
`suppress-warnings.ts` (now actually imported from the entry point)
so the specific `console.error("Error sending from webFrameMain:"…)`
noise never reaches the terminal. Any other payload still surfaces.
* `dispatchAgentMessage` accepted the human-reader sentinel as a wake
target when an agent replied to `__board__` — `wakeAgentIfPossible`
then called `db.getAgent("__board__")`, threw, and the dispatcher
kept repeating on every send. Strip `HUMAN_SENDER_ID` at
`resolveMessageWakeTargets`, and keep a defense-in-depth guard in the
heartbeat so a stray caller (future automation fan-out) cannot
reintroduce the crash.
* Pi's skills loader rejects any SKILL.md whose frontmatter `name`
diverges from its parent directory. The four bundled `my-writing-style`
copies declared `name: writing-style-skill`, so every install emitted
a warning and dropped the skill. They also lived as orphan gitlinks
(mode 160000 without .gitmodules), and the global `*.md` gitignore
hid every other SKILL.md from version control. Fixed the frontmatter
to match the dir, converted the dangling submodules to plain trees,
and allowlisted `builtin-skills/**/*.md` so a fresh clone carries the
catalogue instead of silently losing it.
107 lines
3.2 KiB
Markdown
107 lines
3.2 KiB
Markdown
---
|
|
title: Build Rich Domain Models Not Anemic Data Structures
|
|
impact: HIGH
|
|
impactDescription: centralizes business logic, prevents scattered rules
|
|
tags: entity, domain-model, anemic, behavior
|
|
---
|
|
|
|
## Build Rich Domain Models Not Anemic Data Structures
|
|
|
|
Entities should contain behavior, not just data. Anemic domain models push business logic into services, scattering rules and duplicating validation.
|
|
|
|
**Incorrect (anemic domain model):**
|
|
|
|
```java
|
|
// domain/entities/Subscription.java
|
|
public class Subscription {
|
|
private String id;
|
|
private String planId;
|
|
private LocalDate startDate;
|
|
private LocalDate endDate;
|
|
private String status;
|
|
|
|
// Only getters and setters - no behavior
|
|
public String getStatus() { return status; }
|
|
public void setStatus(String status) { this.status = status; }
|
|
public LocalDate getEndDate() { return endDate; }
|
|
public void setEndDate(LocalDate endDate) { this.endDate = endDate; }
|
|
}
|
|
|
|
// application/services/SubscriptionService.java
|
|
public class SubscriptionService {
|
|
public void cancel(Subscription sub) {
|
|
if (!sub.getStatus().equals("active")) {
|
|
throw new IllegalStateException("Cannot cancel");
|
|
}
|
|
sub.setStatus("cancelled");
|
|
sub.setEndDate(LocalDate.now());
|
|
}
|
|
|
|
public void renew(Subscription sub, int months) {
|
|
if (!sub.getStatus().equals("active")) {
|
|
throw new IllegalStateException("Cannot renew");
|
|
}
|
|
sub.setEndDate(sub.getEndDate().plusMonths(months));
|
|
}
|
|
// Logic scattered across many services
|
|
}
|
|
```
|
|
|
|
**Correct (rich domain model):**
|
|
|
|
```java
|
|
// domain/entities/Subscription.java
|
|
public class Subscription {
|
|
private final SubscriptionId id;
|
|
private final PlanId planId;
|
|
private final LocalDate startDate;
|
|
private LocalDate endDate;
|
|
private SubscriptionStatus status;
|
|
|
|
public void cancel() {
|
|
ensureActive();
|
|
this.status = SubscriptionStatus.CANCELLED;
|
|
this.endDate = LocalDate.now();
|
|
}
|
|
|
|
public void renew(Period extension) {
|
|
ensureActive();
|
|
if (extension.getMonths() < 1) {
|
|
throw new InvalidExtensionPeriodException(extension);
|
|
}
|
|
this.endDate = this.endDate.plus(extension);
|
|
}
|
|
|
|
public boolean isExpired() {
|
|
return LocalDate.now().isAfter(this.endDate);
|
|
}
|
|
|
|
public boolean canUpgradeTo(Plan newPlan) {
|
|
return this.status == SubscriptionStatus.ACTIVE
|
|
&& newPlan.isUpgradeFrom(this.planId);
|
|
}
|
|
|
|
private void ensureActive() {
|
|
if (this.status != SubscriptionStatus.ACTIVE) {
|
|
throw new InactiveSubscriptionException(this.id);
|
|
}
|
|
}
|
|
}
|
|
|
|
// application/usecases/CancelSubscriptionUseCase.java
|
|
public class CancelSubscriptionUseCase {
|
|
public void execute(SubscriptionId id) {
|
|
Subscription sub = repository.findById(id);
|
|
sub.cancel(); // Business logic in entity
|
|
repository.save(sub);
|
|
}
|
|
}
|
|
```
|
|
|
|
**Benefits:**
|
|
- Business rules live with the data they operate on
|
|
- Impossible to forget validation when manipulating data
|
|
- Entity documents its own capabilities and constraints
|
|
|
|
Reference: [Anemic Domain Model Anti-pattern](https://martinfowler.com/bliki/AnemicDomainModel.html)
|