ZacharyZhang-NY
e74dafcd36
Three independently ugly bugs that all fed the same log flood:
* Electron's `WebFrameMain.send` writes every "Render frame was disposed"
to stderr via `console.error`. When the worker fans a second
agent-event past a reloading renderer, we produced thousands of
identical lines and stalled the main loop on stderr I/O. Added a
`mainFrame.detached` guard so the send is short-circuited before
Electron's own catch block fires, and installed a targeted filter in
`suppress-warnings.ts` (now actually imported from the entry point)
so the specific `console.error("Error sending from webFrameMain:"…)`
noise never reaches the terminal. Any other payload still surfaces.
* `dispatchAgentMessage` accepted the human-reader sentinel as a wake
target when an agent replied to `__board__` — `wakeAgentIfPossible`
then called `db.getAgent("__board__")`, threw, and the dispatcher
kept repeating on every send. Strip `HUMAN_SENDER_ID` at
`resolveMessageWakeTargets`, and keep a defense-in-depth guard in the
heartbeat so a stray caller (future automation fan-out) cannot
reintroduce the crash.
* Pi's skills loader rejects any SKILL.md whose frontmatter `name`
diverges from its parent directory. The four bundled `my-writing-style`
copies declared `name: writing-style-skill`, so every install emitted
a warning and dropped the skill. They also lived as orphan gitlinks
(mode 160000 without .gitmodules), and the global `*.md` gitignore
hid every other SKILL.md from version control. Fixed the frontmatter
to match the dir, converted the dangling submodules to plain trees,
and allowlisted `builtin-skills/**/*.md` so a fresh clone carries the
catalogue instead of silently losing it.
39 lines
1.1 KiB
Markdown
39 lines
1.1 KiB
Markdown
---
|
|
title: Use Pronounceable Names
|
|
impact: HIGH
|
|
impactDescription: enables verbal communication about code
|
|
tags: name, pronounceable, communication, readability
|
|
---
|
|
|
|
## Use Pronounceable Names
|
|
|
|
Use pronounceable names. If you cannot pronounce a name, you cannot discuss it without sounding foolish. Programming is a social activity; names should facilitate discussion.
|
|
|
|
**Incorrect (unpronounceable abbreviations):**
|
|
|
|
```java
|
|
class DtaRcrd102 {
|
|
private Date genymdhms; // generation year, month, day, hour, minute, second
|
|
private Date modymdhms;
|
|
private final String pszqint = "102";
|
|
}
|
|
|
|
// In conversation: "Hey, look at this dee-tee-ay-arr-cee-arr-dee"
|
|
```
|
|
|
|
**Correct (pronounceable names):**
|
|
|
|
```java
|
|
class Customer {
|
|
private Date generationTimestamp;
|
|
private Date modificationTimestamp;
|
|
private final String recordId = "102";
|
|
}
|
|
|
|
// In conversation: "Hey, look at this Customer record"
|
|
```
|
|
|
|
The pronounceable version enables natural conversation: "Hey, when did we modify this customer's generation timestamp?"
|
|
|
|
Reference: [Clean Code, Chapter 2: Meaningful Names](https://www.oreilly.com/library/view/clean-code-a/9780136083238/)
|