ZacharyZhang-NY
e74dafcd36
Three independently ugly bugs that all fed the same log flood:
* Electron's `WebFrameMain.send` writes every "Render frame was disposed"
to stderr via `console.error`. When the worker fans a second
agent-event past a reloading renderer, we produced thousands of
identical lines and stalled the main loop on stderr I/O. Added a
`mainFrame.detached` guard so the send is short-circuited before
Electron's own catch block fires, and installed a targeted filter in
`suppress-warnings.ts` (now actually imported from the entry point)
so the specific `console.error("Error sending from webFrameMain:"…)`
noise never reaches the terminal. Any other payload still surfaces.
* `dispatchAgentMessage` accepted the human-reader sentinel as a wake
target when an agent replied to `__board__` — `wakeAgentIfPossible`
then called `db.getAgent("__board__")`, threw, and the dispatcher
kept repeating on every send. Strip `HUMAN_SENDER_ID` at
`resolveMessageWakeTargets`, and keep a defense-in-depth guard in the
heartbeat so a stray caller (future automation fan-out) cannot
reintroduce the crash.
* Pi's skills loader rejects any SKILL.md whose frontmatter `name`
diverges from its parent directory. The four bundled `my-writing-style`
copies declared `name: writing-style-skill`, so every install emitted
a warning and dropped the skill. They also lived as orphan gitlinks
(mode 160000 without .gitmodules), and the global `*.md` gitignore
hid every other SKILL.md from version control. Fixed the frontmatter
to match the dir, converted the dangling submodules to plain trees,
and allowlisted `builtin-skills/**/*.md` so a fresh clone carries the
catalogue instead of silently losing it.
697 B
697 B
Clippy Lint → Rule Mapping
| Clippy Lint | Category | Fix |
|---|---|---|
unwrap_used |
Error | Use ? or expect() |
needless_clone |
Perf | Use reference |
await_holding_lock |
Async | Scope guard before await |
linkedlist |
Perf | Use Vec/VecDeque |
wildcard_imports |
Style | Explicit imports |
missing_safety_doc |
Safety | Add # Safety doc |
undocumented_unsafe_blocks |
Safety | Add // SAFETY: |
transmute_ptr_to_ptr |
Safety | Use pointer::cast() |
large_stack_arrays |
Mem | Use Vec or Box |
too_many_arguments |
Design | Use struct params |
For unsafe-related lints → see unsafe-checker skill.