Drop the fake reload glyph behavior on split-pane headers

The split-pane reload glyph had `cursor_pointer` + an `on_click` that
called `select_tab` — clicking the reload button just re-selected the
already-active tab. That's a fake handler.

Make the glyph visibly disabled (INK_5, no cursor, no click) until a
real per-tab reload action lands in BrowserCore. `refresh_tab` exists
but is `pub(super)` and only flips the discard state; surfacing it as
"reload" would mislead.
This commit is contained in:
2026-05-09 21:59:50 -04:00
parent 432879b27f
commit 2ceb00a95a
@@ -67,17 +67,16 @@ pub(crate) fn render_split_pane_header(
.into_any_element() .into_any_element()
} }
fn render_reload_glyph(tab_id: TabId, cx: &mut Context<ElyShell>) -> AnyElement { /// Reload affordance on each split-pane header. Real page reload isn't
let id = format!("split-pane-reload-{}", tab_id.as_str()); /// exposed through `BrowserCore` yet — `refresh_tab` is `pub(super)`
/// and only flips the discard state. Render the glyph in the disabled
/// `INK_5` color and skip cursor + on_click rather than ship a button
/// that pretends to reload by re-selecting the tab. Wire a real
/// reload action when one lands.
fn render_reload_glyph(_tab_id: TabId, _cx: &mut Context<ElyShell>) -> AnyElement {
div() div()
.id(SharedString::from(id)) .text_color(rgb(colors::INK_5))
.text_color(rgb(colors::INK_4))
.text_size(px(11.0)) .text_size(px(11.0))
.cursor_pointer()
.hover(|style| style.text_color(rgb(colors::INK)))
.on_click(cx.listener(move |shell, _, window, cx| {
shell.select_tab(&tab_id, window, cx);
}))
.child(IconName::Redo2) .child(IconName::Redo2)
.into_any_element() .into_any_element()
} }