T04: reviewed, ticked

TASKS.md

@@ -16,7 +16,7 @@ Progress truth. Top to bottom, one at a time. A task is ticked only after its co
 
 ## 5. Terminal engine
 
-- [ ] T04 PTY: spawn through alacritty's event loop, OSC 7 tap on the reader, child id, events to the app; tests.
+- [x] T04 PTY: spawn through alacritty's event loop, OSC 7 tap on the reader, child id, events to the app; tests.
 - [ ] T05 Shell integration for zsh, bash, fish, PowerShell, injected at launch; tests that zsh and bash report their folder.
 - [ ] T06 Terminal view: frame from the grid, colors and styles, wide and combining cells, cursor shapes and blink, font, line height, padding, resize.
 - [ ] T07 Box drawing and block elements painted as geometry; tests.

tasks/reviews.md

@@ -15,3 +15,10 @@ Each task gets at most three codex rounds. Each round: the commit, the verdict,
 ## T03
 
 - Round 1, 7d4d535: PASS. Theme files match upstream 21f281d byte for byte.
+
+## T04
+
+- Round 1, 62e50fe: FAIL. A folder without enter permission started the shell elsewhere; no pid for the app; folder and exit unlogged; grid and pty sizes split past the kernel's cap. Fixed in 96ae85b.
+- Round 2, 96ae85b: FAIL. The permission check raced alacritty's chdir, whose result alacritty ignores; closing a live pty logged nothing. Fixed in fff436c: ELYTerminal's own Unix pty, a checked chdir in pre_exec that fails the spawn, closing and hung-up logs with a test.
+- Round 3, fff436c: FAIL. Drop waited on the program while holding the master, so a program ignoring SIGHUP never ended. Fixed in 0e7f309: the master closes before the wait; a test that traps HUP went red, then green.
+- The review cap of three rounds is reached. The round-3 fix stands on its red-green test, not a fourth round.