Files
Ely-GPUI-Components/tasks/github.md
T
ZacharyZhang-NY 0f468e8661
CI / crate (push) Failing after 2s
CI / platforms (windows-latest) (push) Failing after 22s
CI / site (push) Failing after 24s
CI / platforms (ubuntu-24.04) (push) Failing after 1m58s
CI / platforms (macos-15-intel) (push) Canceled after 0s
CI / platforms (ubuntu-24.04-arm) (push) Canceled after 0s
CI / platforms (windows-11-arm) (push) Canceled after 0s
G15: the sixth review passed the last fix
2026-10-08 22:11:50 -04:00

2.0 KiB

GitHub round, 2026-10-03

  • G1 PR #1: build on Windows with escape_args; review, verify, merge, answer CodeRabbit
  • G2 Issue #2: tree guides line up under the chevron and run unbroken across rows
  • G3 Issue #3: Checkbox, Switch, Radio, Slider and Select name their role, label and state
  • G4 Push, comment on #2 and #3, close #2
  • G5 PR #4: Icon::from_path draws an app's SVG; a path the asset source lacks fails at render

GitHub round, 2026-10-05

  • G6 Issue #7: an IME composition restarts the caret's blink, as every edit does; its ranges are logged; tested
  • G7 Issue #6: shell::ColumnShell, a sidebar that runs to the window's top with the traffic lights, beside one or two panes that bring their own headers; tested
  • G8 Issue #6: a Layout story, stories.json, AGENTS.md and the PRD line; the story runs live on the site
  • G9 Push, deploy, reply on #6 and #7, close #6

GitHub round, 2026-10-08

  • G10 CI: cargo fmt on the files the last commits left unformatted; then the narrow-layout commits: fmt, and Theme::hairline for their raw px
  • G11 Issue #7: a caret is a whole number of device pixels wide at a device pixel, so it never shows thin then thick; tested
  • G12 Issue #7: an IME asks for its candidate box past the laid-out text; the box clamps to the last layout, as bounds_for does; tested
  • G13 Issue #12: a floating option list occludes, so the wheel scrolls the list and not the page under it; tested
  • G14 Issue #7: BlockEditor scrolls in its own ScrollArea with its scrollbar and keeps the caret in view as blocks are added; tested
  • G15 Issue #7: BlockEditor turns into Markdown and back; tested. Six reviews: the fifth finding (a slash ended an unquoted HTML value) fixed and tested; the sixth, at the owner's word, passed
  • G16 Issue #7: a selection across blocks: drag or Shift-press selects, copy, cut, delete and typing act on it, undo restores; tested
  • G17 Push, reply on #7 and #12