ZacharyZhang-NY/ElyOffice
3
15 Fork 0
Code Issues 2 Pull Requests Actions Packages Projects Releases 9 Wiki Activity

R4.11: round 2 verdict

Browse Source 
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This commit is contained in:
ZacharyZhang-NYandClaude Opus 5.5 committed 2026-10-14 22:49:13 -04:00
1 parent fa02f1a323
commit fef5735267
1 file changed
+3
Download Patch File Download Diff File Expand all files Collapse all files
tasks/reviews/R4.11-r2.md
+3
View File
@@ -0,0 +1,3 @@
FAIL
1. `.work/R4.11/lib.ps1:39` — [P2] Restore-Data deletes its backup even when restoring an originally absent file fails. The removal branch at line 37 suppresses every deletion error with `-ErrorAction SilentlyContinue`. Back up with `settings.json` absent, create that file during the run, and hold it open without delete sharing: Restore-Data returns normally, leaves the generated settings in place, and deletes the backup. Reproduced with the unchanged functions and disposable directories; evidence: `.work/R4.11-r2/restore-errors.log`. Propagate deletion failures other than an already absent file, retain the backup until every file is restored successfully, and add this failure case to the regression.